From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4A460C4332F for ; Wed, 16 Nov 2022 21:00:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234520AbiKPVA0 (ORCPT ); Wed, 16 Nov 2022 16:00:26 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44278 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238934AbiKPVAE (ORCPT ); Wed, 16 Nov 2022 16:00:04 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 075C367F4A for ; Wed, 16 Nov 2022 12:56:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1668632146; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=SPti+yxgwhQAS4coWaRzF7Rb17MYo3d8okdAXtECqoE=; b=hWlaTCbHL4L6lmqOFL4L+xliqZo/rk6BU6kJRJh7CPjKLIlh6EmH3OF36ZD6R0jsIWvJDy hovWrzPXQNDk0i/9YNOXq6snr/0d58chwokGduWbiN1MTJeg8waVJprtYURaCJvzpzQPOi Zi4jmxpbJepzb2roG6dn9GYOF0bm4+A= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-97--lNYNX_EMpCNG8KENODIzA-1; Wed, 16 Nov 2022 15:55:41 -0500 X-MC-Unique: -lNYNX_EMpCNG8KENODIzA-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 58324185A792; Wed, 16 Nov 2022 20:55:40 +0000 (UTC) Received: from RHTPC1VM0NT (unknown [10.22.19.14]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 797982027064; Wed, 16 Nov 2022 20:55:38 +0000 (UTC) From: Aaron Conole To: Xin Long Cc: network dev , dev@openvswitch.org, davem@davemloft.net, kuba@kernel.org, Eric Dumazet , Paolo Abeni , Pravin B Shelar , Jamal Hadi Salim , Cong Wang , Jiri Pirko , Pablo Neira Ayuso , Florian Westphal , Marcelo Ricardo Leitner , Davide Caratti , Eelco Chaudron Subject: Re: [PATCH net-next 1/5] openvswitch: delete the unncessary skb_pull_rcsum call in ovs_ct_nat_execute References: <83692c116f1d5d5ee03ce8386b32cced78c9a022.1668527318.git.lucien.xin@gmail.com> Date: Wed, 16 Nov 2022 15:55:36 -0500 In-Reply-To: <83692c116f1d5d5ee03ce8386b32cced78c9a022.1668527318.git.lucien.xin@gmail.com> (Xin Long's message of "Tue, 15 Nov 2022 10:50:53 -0500") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 3.1 on 10.11.54.4 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Xin Long writes: > The calls to ovs_ct_nat_execute() are as below: > > ovs_ct_execute() > ovs_ct_lookup() > __ovs_ct_lookup() > ovs_ct_nat() > ovs_ct_nat_execute() > ovs_ct_commit() > __ovs_ct_lookup() > ovs_ct_nat() > ovs_ct_nat_execute() > > and since skb_pull_rcsum() and skb_push_rcsum() are already > called in ovs_ct_execute(), there's no need to do it again > in ovs_ct_nat_execute(). > > Signed-off-by: Xin Long > --- LGTM Acked-by: Aaron Conole