Re: [PATCH 1/1] libbpf: Delete an unneeded bool conversion

From: "Leizhen (ThunderTown)" <thunder.leizhen@huawei.com>
To: Andrii Nakryiko <andrii.nakryiko@gmail.com>,
	Leon Romanovsky <leon@kernel.org>
Cc: Alexei Starovoitov <ast@kernel.org>,
	Daniel Borkmann <daniel@iogearbox.net>,
	Andrii Nakryiko <andrii@kernel.org>,
	Martin KaFai Lau <kafai@fb.com>, Song Liu <songliubraving@fb.com>,
	Yonghong Song <yhs@fb.com>,
	John Fastabend <john.fastabend@gmail.com>,
	KP Singh <kpsingh@kernel.org>, netdev <netdev@vger.kernel.org>,
	bpf <bpf@vger.kernel.org>
Subject: Re: [PATCH 1/1] libbpf: Delete an unneeded bool conversion
Date: Thu, 13 May 2021 10:14:00 +0800	[thread overview]
Message-ID: <f82343ec-9d67-d033-dd07-813e7d981c4f@huawei.com> (raw)
In-Reply-To: <CAEf4BzaYsjWh_10a4yeSVpAAwC-f=zUNANb10VN2xZ1b5dsY-A@mail.gmail.com>

On 2021/5/13 3:02, Andrii Nakryiko wrote:
> On Mon, May 10, 2021 at 10:09 PM Leon Romanovsky <leon@kernel.org> wrote:
>>
>> On Mon, May 10, 2021 at 11:00:29AM -0700, Andrii Nakryiko wrote:
>>> On Mon, May 10, 2021 at 5:43 AM Zhen Lei <thunder.leizhen@huawei.com> wrote:
>>>>
>>>> The result of an expression consisting of a single relational operator is
>>>> already of the bool type and does not need to be evaluated explicitly.
>>>>
>>>> No functional change.
>>>>
>>>> Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
>>>> ---
>>>
>>> See [0] and [1].
>>>
>>>   [0] https://lore.kernel.org/bpf/CAEf4BzYgLf5g3oztbA-CJR4gQ7AVKQAGrsHWCOgTtUMUM-Mxfg@mail.gmail.com/
>>>   [1] https://lore.kernel.org/bpf/CAEf4BzZQ6=-h3g1duXFwDLr92z7nE6ajv8Rz_Zv=qx=-F3sRVA@mail.gmail.com/
>>
>> How long do you plan to fight with such patches?
> 
> As long as necessary. There are better ways to contribute to libbpf
> than doing cosmetic changes to the perfectly correct code.

No small stream, no river and sea.

There are no improvements to functionality, but may slightly speed up compilation.
With more such accumulations, it is possible that the compilation of allmodconfig
results in a second-level improvement.

I don't know if you agree, at least I think so.

> 
>>
>> Thanks
>>
>>>
>>>>  tools/lib/bpf/libbpf.c | 2 +-
>>>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>>>
>>>> diff --git a/tools/lib/bpf/libbpf.c b/tools/lib/bpf/libbpf.c
>>>> index e2a3cf4378140f2..fa02213c451f4d2 100644
>>>> --- a/tools/lib/bpf/libbpf.c
>>>> +++ b/tools/lib/bpf/libbpf.c
>>>> @@ -1504,7 +1504,7 @@ static int set_kcfg_value_tri(struct extern_desc *ext, void *ext_val,
>>>>                                 ext->name, value);
>>>>                         return -EINVAL;
>>>>                 }
>>>> -               *(bool *)ext_val = value == 'y' ? true : false;
>>>> +               *(bool *)ext_val = value == 'y';
>>>>                 break;
>>>>         case KCFG_TRISTATE:
>>>>                 if (value == 'y')
>>>> --
>>>> 2.26.0.106.g9fadedd
>>>>
>>>>
> 
> .
> 