From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5F2CBC33CAF for ; Wed, 22 Jan 2020 14:37:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 30E4A2465B for ; Wed, 22 Jan 2020 14:37:47 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="sVFv0qgu" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729129AbgAVOho (ORCPT ); Wed, 22 Jan 2020 09:37:44 -0500 Received: from fllv0015.ext.ti.com ([198.47.19.141]:49630 "EHLO fllv0015.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725972AbgAVOho (ORCPT ); Wed, 22 Jan 2020 09:37:44 -0500 Received: from lelv0266.itg.ti.com ([10.180.67.225]) by fllv0015.ext.ti.com (8.15.2/8.15.2) with ESMTP id 00MEbSg1059865; Wed, 22 Jan 2020 08:37:28 -0600 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1579703848; bh=ExCKsULHAY09wbOO5eobOUvQLsBWiXPX0ybK/2ZK/to=; h=Subject:To:CC:References:From:Date:In-Reply-To; b=sVFv0qguYaSgtrDDtyh7c9sU7oqMHY6VpoQRS9BBgR9GtXBXuL/XeHnit+SO3Ycg+ afvW7NgWnlgEmwyh4przgqq7u86VzyKhRq3HC/Y6nEdHyDzw8ejhWTIcOLqDr0k/uJ gxq1gqFfsF9vyxFKx1LUotUt/t26JBT3BlteIDXg= Received: from DLEE103.ent.ti.com (dlee103.ent.ti.com [157.170.170.33]) by lelv0266.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 00MEbSLs087066 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 22 Jan 2020 08:37:28 -0600 Received: from DLEE110.ent.ti.com (157.170.170.21) by DLEE103.ent.ti.com (157.170.170.33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1847.3; Wed, 22 Jan 2020 08:37:28 -0600 Received: from fllv0040.itg.ti.com (10.64.41.20) by DLEE110.ent.ti.com (157.170.170.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1847.3 via Frontend Transport; Wed, 22 Jan 2020 08:37:28 -0600 Received: from [10.250.65.13] (ileax41-snat.itg.ti.com [10.172.224.153]) by fllv0040.itg.ti.com (8.15.2/8.15.2) with ESMTP id 00MEbRQ4083641; Wed, 22 Jan 2020 08:37:27 -0600 Subject: Re: [PATCH 1/3] dt-bindings: net: can: m_can: Add Documentation for stb-gpios To: Sekhar Nori , Faiz Abbas , , , , , CC: , , , , , , , , References: <20200122080310.24653-1-faiz_abbas@ti.com> <20200122080310.24653-2-faiz_abbas@ti.com> <8fc7c343-267d-c91c-0381-60990cfc35e8@ti.com> From: Dan Murphy Message-ID: Date: Wed, 22 Jan 2020 08:34:20 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: <8fc7c343-267d-c91c-0381-60990cfc35e8@ti.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Sekhar On 1/22/20 8:24 AM, Sekhar Nori wrote: > On 22/01/20 7:05 PM, Dan Murphy wrote: >> Faiz >> >> On 1/22/20 2:03 AM, Faiz Abbas wrote: >>> The CAN transceiver on some boards has an STB pin which is >>> used to control its standby mode. Add an optional property >>> stb-gpios to toggle the same. >>> >>> Signed-off-by: Faiz Abbas >>> Signed-off-by: Sekhar Nori >>> --- >>>   Documentation/devicetree/bindings/net/can/m_can.txt | 2 ++ >>>   1 file changed, 2 insertions(+) >>> >>> diff --git a/Documentation/devicetree/bindings/net/can/m_can.txt >>> b/Documentation/devicetree/bindings/net/can/m_can.txt >>> index ed614383af9c..cc8ba3f7a2aa 100644 >>> --- a/Documentation/devicetree/bindings/net/can/m_can.txt >>> +++ b/Documentation/devicetree/bindings/net/can/m_can.txt >>> @@ -48,6 +48,8 @@ Optional Subnode: >>>                 that can be used for CAN/CAN-FD modes. See >>> >>> Documentation/devicetree/bindings/net/can/can-transceiver.txt >>>                 for details. >>> +stb-gpios        : gpio node to toggle the STB (standby) signal on >>> the transceiver >>> + >> The m_can.txt is for the m_can framework.  If this is specific to the >> platform then it really does not belong here. >> >> If the platform has specific nodes then maybe we need a >> m_can_platform.txt binding for specific platform nodes.  But I leave >> that decision to Rob. > Since this is transceiver enable, should this not be in > Documentation/devicetree/bindings/net/can/can-transceiver.txt? +1 Dan