* [PATCH v6 net-next 0/2] Fixed warnings
@ 2023-01-06 8:29 Divya Koppera
2023-01-06 8:29 ` [PATCH v6 net-next 1/2] net: phy: micrel: Fixed error related to uninitialized symbol ret Divya Koppera
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Divya Koppera @ 2023-01-06 8:29 UTC (permalink / raw)
To: andrew, hkallweit1, linux, davem, edumazet, kuba, pabeni, netdev,
linux-kernel, richardcochran, alexanderduyck
Cc: UNGLinuxDriver
Fixed warnings related to PTR_ERR and initialization.
Divya Koppera (2):
net: phy: micrel: Fixed error related to uninitialized symbol ret
net: phy: micrel: Fix warn: passing zero to PTR_ERR
drivers/net/phy/micrel.c | 13 +++++++------
1 file changed, 7 insertions(+), 6 deletions(-)
--
2.17.1
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH v6 net-next 1/2] net: phy: micrel: Fixed error related to uninitialized symbol ret
2023-01-06 8:29 [PATCH v6 net-next 0/2] Fixed warnings Divya Koppera
@ 2023-01-06 8:29 ` Divya Koppera
2023-01-06 9:17 ` Arun.Ramadoss
2023-01-06 8:29 ` [PATCH v6 net-next 2/2] net: phy: micrel: Fix warn: passing zero to PTR_ERR Divya Koppera
2023-01-09 7:30 ` [PATCH v6 net-next 0/2] Fixed warnings patchwork-bot+netdevbpf
2 siblings, 1 reply; 5+ messages in thread
From: Divya Koppera @ 2023-01-06 8:29 UTC (permalink / raw)
To: andrew, hkallweit1, linux, davem, edumazet, kuba, pabeni, netdev,
linux-kernel, richardcochran, alexanderduyck
Cc: UNGLinuxDriver
Initialized return variable
Fixes Old smatch warnings:
drivers/net/phy/micrel.c:1750 ksz886x_cable_test_get_status() error:
uninitialized symbol 'ret'.
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: Divya Koppera <Divya.Koppera@microchip.com>
---
v5 -> v6:
- Removed fixes tag as this is fixing static analysis issus and not
a real fix.
v4 -> v5:
- No changes, added reviewed by tag.
v3 -> v4:
- Split the patch for different warnings.
v1 -> v3:
- No changes
---
drivers/net/phy/micrel.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/phy/micrel.c b/drivers/net/phy/micrel.c
index 26ce0c5defcd..1bcdb828db56 100644
--- a/drivers/net/phy/micrel.c
+++ b/drivers/net/phy/micrel.c
@@ -2088,7 +2088,8 @@ static int ksz886x_cable_test_get_status(struct phy_device *phydev,
const struct kszphy_type *type = phydev->drv->driver_data;
unsigned long pair_mask = type->pair_mask;
int retries = 20;
- int pair, ret;
+ int ret = 0;
+ int pair;
*finished = false;
--
2.17.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH v6 net-next 2/2] net: phy: micrel: Fix warn: passing zero to PTR_ERR
2023-01-06 8:29 [PATCH v6 net-next 0/2] Fixed warnings Divya Koppera
2023-01-06 8:29 ` [PATCH v6 net-next 1/2] net: phy: micrel: Fixed error related to uninitialized symbol ret Divya Koppera
@ 2023-01-06 8:29 ` Divya Koppera
2023-01-09 7:30 ` [PATCH v6 net-next 0/2] Fixed warnings patchwork-bot+netdevbpf
2 siblings, 0 replies; 5+ messages in thread
From: Divya Koppera @ 2023-01-06 8:29 UTC (permalink / raw)
To: andrew, hkallweit1, linux, davem, edumazet, kuba, pabeni, netdev,
linux-kernel, richardcochran, alexanderduyck
Cc: UNGLinuxDriver
Handle the NULL pointer case
Fixes New smatch warnings:
drivers/net/phy/micrel.c:2613 lan8814_ptp_probe_once() warn: passing zero to 'PTR_ERR'
vim +/PTR_ERR +2613 drivers/net/phy/micrel.c
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Alexander Duyck <alexanderduyck@fb.com>
Signed-off-by: Divya Koppera <Divya.Koppera@microchip.com>
---
v5 -> v6:
- Removed fixes tag as this is to fix static analysis issues and not
real fix.
v4 -> v5:
- Removed run time check and added compile time check for PHC
v3 -> v4:
- Split the patch for different warnings
- Renamed variable from shared_priv to shared.
v2 -> v3:
- Changed subject line from net to net-next
- Removed config check for ptp and clock configuration
instead added null check for ptp_clock
- Fixed one more warning related to initialisaton.
v1 -> v2:
- Handled NULL pointer case
- Changed subject line with net-next to net
---
drivers/net/phy/micrel.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/net/phy/micrel.c b/drivers/net/phy/micrel.c
index 1bcdb828db56..650ef53fcf20 100644
--- a/drivers/net/phy/micrel.c
+++ b/drivers/net/phy/micrel.c
@@ -3017,10 +3017,6 @@ static int lan8814_ptp_probe_once(struct phy_device *phydev)
{
struct lan8814_shared_priv *shared = phydev->shared->priv;
- if (!IS_ENABLED(CONFIG_PTP_1588_CLOCK) ||
- !IS_ENABLED(CONFIG_NETWORK_PHY_TIMESTAMPING))
- return 0;
-
/* Initialise shared lock for clock*/
mutex_init(&shared->shared_lock);
@@ -3040,12 +3036,16 @@ static int lan8814_ptp_probe_once(struct phy_device *phydev)
shared->ptp_clock = ptp_clock_register(&shared->ptp_clock_info,
&phydev->mdio.dev);
- if (IS_ERR_OR_NULL(shared->ptp_clock)) {
+ if (IS_ERR(shared->ptp_clock)) {
phydev_err(phydev, "ptp_clock_register failed %lu\n",
PTR_ERR(shared->ptp_clock));
return -EINVAL;
}
+ /* Check if PHC support is missing at the configuration level */
+ if (!shared->ptp_clock)
+ return 0;
+
phydev_dbg(phydev, "successfully registered ptp clock\n");
shared->phydev = phydev;
--
2.17.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH v6 net-next 1/2] net: phy: micrel: Fixed error related to uninitialized symbol ret
2023-01-06 8:29 ` [PATCH v6 net-next 1/2] net: phy: micrel: Fixed error related to uninitialized symbol ret Divya Koppera
@ 2023-01-06 9:17 ` Arun.Ramadoss
0 siblings, 0 replies; 5+ messages in thread
From: Arun.Ramadoss @ 2023-01-06 9:17 UTC (permalink / raw)
To: andrew, linux-kernel, linux, Divya.Koppera, kuba, edumazet,
pabeni, richardcochran, netdev, alexanderduyck, davem,
hkallweit1
Cc: UNGLinuxDriver
Hi Divya,
On Fri, 2023-01-06 at 13:59 +0530, Divya Koppera wrote:
> Initialized return variable
>
> Fixes Old smatch warnings:
> drivers/net/phy/micrel.c:1750 ksz886x_cable_test_get_status() error:
> uninitialized symbol 'ret'.
>
> Reported-by: kernel test robot <lkp@intel.com>
> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
> Reviewed-by: Andrew Lunn <andrew@lunn.ch>
> Signed-off-by: Divya Koppera <Divya.Koppera@microchip.com>
I think, Reviewed-by tag should come after signed-off tag. It should be
in chronological order.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v6 net-next 0/2] Fixed warnings
2023-01-06 8:29 [PATCH v6 net-next 0/2] Fixed warnings Divya Koppera
2023-01-06 8:29 ` [PATCH v6 net-next 1/2] net: phy: micrel: Fixed error related to uninitialized symbol ret Divya Koppera
2023-01-06 8:29 ` [PATCH v6 net-next 2/2] net: phy: micrel: Fix warn: passing zero to PTR_ERR Divya Koppera
@ 2023-01-09 7:30 ` patchwork-bot+netdevbpf
2 siblings, 0 replies; 5+ messages in thread
From: patchwork-bot+netdevbpf @ 2023-01-09 7:30 UTC (permalink / raw)
To: Divya Koppera
Cc: andrew, hkallweit1, linux, davem, edumazet, kuba, pabeni, netdev,
linux-kernel, richardcochran, alexanderduyck, UNGLinuxDriver
Hello:
This series was applied to netdev/net-next.git (master)
by David S. Miller <davem@davemloft.net>:
On Fri, 6 Jan 2023 13:59:03 +0530 you wrote:
> Fixed warnings related to PTR_ERR and initialization.
>
> Divya Koppera (2):
> net: phy: micrel: Fixed error related to uninitialized symbol ret
> net: phy: micrel: Fix warn: passing zero to PTR_ERR
>
> drivers/net/phy/micrel.c | 13 +++++++------
> 1 file changed, 7 insertions(+), 6 deletions(-)
>
> [...]
Here is the summary with links:
- [v6,net-next,1/2] net: phy: micrel: Fixed error related to uninitialized symbol ret
https://git.kernel.org/netdev/net-next/c/d50ede4f53e1
- [v6,net-next,2/2] net: phy: micrel: Fix warn: passing zero to PTR_ERR
https://git.kernel.org/netdev/net-next/c/3f88d7d1be42
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2023-01-09 7:30 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-01-06 8:29 [PATCH v6 net-next 0/2] Fixed warnings Divya Koppera
2023-01-06 8:29 ` [PATCH v6 net-next 1/2] net: phy: micrel: Fixed error related to uninitialized symbol ret Divya Koppera
2023-01-06 9:17 ` Arun.Ramadoss
2023-01-06 8:29 ` [PATCH v6 net-next 2/2] net: phy: micrel: Fix warn: passing zero to PTR_ERR Divya Koppera
2023-01-09 7:30 ` [PATCH v6 net-next 0/2] Fixed warnings patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).