From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C4ADEC4338F for ; Tue, 3 Aug 2021 11:24:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9BE0460EE7 for ; Tue, 3 Aug 2021 11:24:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235497AbhHCLZB (ORCPT ); Tue, 3 Aug 2021 07:25:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40508 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235254AbhHCLZA (ORCPT ); Tue, 3 Aug 2021 07:25:00 -0400 Received: from mail-qt1-x829.google.com (mail-qt1-x829.google.com [IPv6:2607:f8b0:4864:20::829]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C1082C061757 for ; Tue, 3 Aug 2021 04:24:49 -0700 (PDT) Received: by mail-qt1-x829.google.com with SMTP id l24so13684327qtj.4 for ; Tue, 03 Aug 2021 04:24:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mojatatu-com.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=2P5RHXeXCy8afq7uLYOoI4479PxrXrrMNoK9Swy9ltA=; b=AR4Bv0Or6IBsAiUq8cv+KVCsRRZU/OufZ4DnBS6kicovruKMv/d27m9t28Ruse8s5K K4z6V6MDmJdSOHX9m1tQsNwy6tFJ7JElZjI9dET1J9FYZ3OrSqLfWw2yMV45IkW8gWZi Nf7yJwb4ftocrKJEILnFdagnV6LWEpS+EhkCC+7bt3DY9BgqZp9rhgLcPmk4T+4qflfy 4FkyedQ1oPl1sQRH9b1JlreMbLsBBr+N/BAtHC14wxqM3KJ25m+C8aWoRkPKsSV/Nisu 8uXZ7hwpUCYyMtiZTuVhB26zMXOLu2S8kLUWxGhJyB3r34KMsyFxVJCp2t6Htyw7wHWn xZYg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=2P5RHXeXCy8afq7uLYOoI4479PxrXrrMNoK9Swy9ltA=; b=KhvqRLZwjuHccM3GZpTjM11EUNu8OQqpCKNMqggef3MJtnCYlCr47TpIkgo0oRh9AB kiJ1LuBLdNPA1g/NLamEEVz0px4bEJ/O4tArK1zIaUSCRbe/rsFIR1Vtr7Mr8jQPLAQK PdGxghIwuh8OtmvQeJvf5lBeEiPj/RrfPALZAoGg5tdcJIKaWX9+IgI3o3k5cKbHKCKK dIVRmsaLyqhJhO/K2HTTOXaD3ZrO1l2w+R/aH+ttxEVVFLU/2ihWKUQ8y7xGQswSHAlI gNsnqwHNXVYBzImAmpX6NrYlcS8U1TuGObyMdcg038LMtJSZTT/DoYYrImoMErOUmWTO 4RDQ== X-Gm-Message-State: AOAM532FIUEOqa5myfqY9FzSkFmiz4XFPFjGYt6xtisZLkbUVGmBahZd 0+hRpORjA08qHzlrUduSHanzeA== X-Google-Smtp-Source: ABdhPJxWEyhm2WvVuirrDe+QVFsehrGwo9edHgMMpXu9yzZmdwi+kZdqX0Y1Gz24e6Tl1P82l2SaVg== X-Received: by 2002:ac8:59c6:: with SMTP id f6mr6801410qtf.232.1627989888716; Tue, 03 Aug 2021 04:24:48 -0700 (PDT) Received: from [192.168.1.171] (bras-base-kntaon1617w-grc-28-184-148-47-47.dsl.bell.ca. [184.148.47.47]) by smtp.googlemail.com with ESMTPSA id i67sm7900124qkd.90.2021.08.03.04.24.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 03 Aug 2021 04:24:48 -0700 (PDT) Subject: Re: [PATCH net-next 3/3] flow_offload: add process to update action stats from hardware To: Simon Horman , David Miller , Jakub Kicinski Cc: Cong Wang , Jiri Pirko , netdev@vger.kernel.org, oss-drivers@corigine.com, Baowen Zheng , Louis Peens References: <20210722091938.12956-1-simon.horman@corigine.com> <20210722091938.12956-4-simon.horman@corigine.com> From: Jamal Hadi Salim Message-ID: Date: Tue, 3 Aug 2021 07:24:47 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: <20210722091938.12956-4-simon.horman@corigine.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 2021-07-22 5:19 a.m., Simon Horman wrote: [..] > /* offload the tc command after deleted */ > int tcf_action_offload_del_post(struct flow_offload_action *fl_act, > struct tc_action *actions[], > @@ -1255,6 +1293,9 @@ int tcf_action_copy_stats(struct sk_buff *skb, struct tc_action *p, > if (p == NULL) > goto errout; > > + /* update hw stats for this action */ > + tcf_action_update_hw_stats(p); This is more a curiosity than a comment on the patch: Is the driver polling for these stats synchronously and what we get here is the last update or do we end up invoking beyond the driver when requesting for the stats? Overall commentary from looking at the patch set: I believe your patches will support the individual tc actions add/del/get/dump command line requests. What is missing is an example usage all the way to the driver. I am sure you have additional patches that put this to good use. My suggestion is to test that cli with that pov against your overall patches and show this in your commit logs - even if those patches are to follow later. cheers, jamal