From: Yonghong Song <yhs@fb.com>
To: Hao Luo <haoluo@google.com>, <netdev@vger.kernel.org>,
<bpf@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-kselftest@vger.kernel.org>
Cc: Shuah Khan <shuah@kernel.org>,
Alexei Starovoitov <ast@kernel.org>,
Andrii Nakryiko <andriin@fb.com>,
Daniel Borkmann <daniel@iogearbox.net>,
Martin KaFai Lau <kafai@fb.com>, Song Liu <songliubraving@fb.com>,
John Fastabend <john.fastabend@gmail.com>,
KP Singh <kpsingh@chromium.org>,
Quentin Monnet <quentin@isovalent.com>,
Steven Rostedt <rostedt@goodmis.org>,
Ingo Molnar <mingo@redhat.com>, Andrey Ignatov <rdna@fb.com>,
Jakub Sitnicki <jakub@cloudflare.com>
Subject: Re: [PATCH bpf-next v1 7/8] bpf: Propagate bpf_per_cpu_ptr() to /tools
Date: Thu, 20 Aug 2020 10:30:35 -0700 [thread overview]
Message-ID: <f9df603c-f909-a90e-6d92-a661cd1248d7@fb.com> (raw)
In-Reply-To: <20200819224030.1615203-8-haoluo@google.com>
On 8/19/20 3:40 PM, Hao Luo wrote:
> Sync tools/include/linux/uapi/bpf.h with include/linux/uapi/bpf.h
This can be folded into the previous patch.
>
> Signed-off-by: Hao Luo <haoluo@google.com>
> ---
> tools/include/uapi/linux/bpf.h | 15 +++++++++++++++
> 1 file changed, 15 insertions(+)
>
> diff --git a/tools/include/uapi/linux/bpf.h b/tools/include/uapi/linux/bpf.h
> index 468376f2910b..7e3dfb2bbb86 100644
> --- a/tools/include/uapi/linux/bpf.h
> +++ b/tools/include/uapi/linux/bpf.h
> @@ -3415,6 +3415,20 @@ union bpf_attr {
> * A non-negative value equal to or less than *size* on success,
> * or a negative error in case of failure.
> *
> + * void *bpf_per_cpu_ptr(const void *ptr, u32 cpu)
> + * Description
> + * Take the address of a percpu ksym and return a pointer pointing
> + * to the variable on *cpu*. A ksym is an extern variable decorated
> + * with '__ksym'. A ksym is percpu if there is a global percpu var
> + * (either static or global) defined of the same name in the kernel.
> + *
> + * bpf_per_cpu_ptr() has the same semantic as per_cpu_ptr() in the
> + * kernel, except that bpf_per_cpu_ptr() may return NULL. This
> + * happens if *cpu* is larger than nr_cpu_ids. The caller of
> + * bpf_per_cpu_ptr() must check the returned value.
> + * Return
> + * A generic pointer pointing to the variable on *cpu*.
> + *
> */
> #define __BPF_FUNC_MAPPER(FN) \
> FN(unspec), \
> @@ -3559,6 +3573,7 @@ union bpf_attr {
> FN(skc_to_tcp_request_sock), \
> FN(skc_to_udp6_sock), \
> FN(get_task_stack), \
> + FN(bpf_per_cpu_ptr), \
> /* */
>
> /* integer value in 'imm' field of BPF_CALL instruction selects which helper
>
next prev parent reply other threads:[~2020-08-20 17:31 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-19 22:40 [PATCH bpf-next v1 0/8] bpf: BTF support for ksyms Hao Luo
2020-08-19 22:40 ` [PATCH bpf-next v1 1/8] bpf: Introduce pseudo_btf_id Hao Luo
2020-08-20 15:22 ` Yonghong Song
2020-08-20 17:04 ` Hao Luo
2020-08-25 0:05 ` Hao Luo
2020-08-25 0:43 ` Yonghong Song
2020-08-20 16:43 ` Yonghong Song
2020-08-20 21:53 ` Alexei Starovoitov
2020-08-21 2:22 ` Hao Luo
2020-08-19 22:40 ` [PATCH bpf-next v1 2/8] bpf: Propagate BPF_PSEUDO_BTF_ID to uapi headers in /tools Hao Luo
2020-08-20 16:44 ` Yonghong Song
2020-08-19 22:40 ` [PATCH bpf-next v1 3/8] bpf: Introduce help function to validate ksym's type Hao Luo
2020-08-20 17:20 ` Yonghong Song
2020-08-21 21:50 ` Andrii Nakryiko
2020-08-22 0:43 ` Hao Luo
2020-08-22 2:43 ` Andrii Nakryiko
2020-08-22 7:04 ` Hao Luo
2020-08-19 22:40 ` [PATCH bpf-next v1 4/8] bpf/libbpf: BTF support for typed ksyms Hao Luo
2020-08-21 22:37 ` Andrii Nakryiko
2020-08-27 22:29 ` Hao Luo
2020-09-01 18:11 ` Andrii Nakryiko
2020-09-01 20:35 ` Hao Luo
2020-09-01 23:54 ` Andrii Nakryiko
2020-09-02 0:46 ` Hao Luo
2020-08-19 22:40 ` [PATCH bpf-next v1 5/8] bpf/selftests: ksyms_btf to test " Hao Luo
2020-08-20 17:28 ` Yonghong Song
2020-08-21 23:03 ` Andrii Nakryiko
2020-08-22 7:26 ` Hao Luo
2020-08-22 7:35 ` Andrii Nakryiko
2020-08-19 22:40 ` [PATCH bpf-next v1 6/8] bpf: Introduce bpf_per_cpu_ptr() Hao Luo
2020-08-22 3:26 ` Andrii Nakryiko
2020-08-22 3:31 ` Andrii Nakryiko
2020-08-22 7:49 ` Hao Luo
2020-08-22 7:55 ` Andrii Nakryiko
2020-08-25 1:03 ` Hao Luo
2020-08-19 22:40 ` [PATCH bpf-next v1 7/8] bpf: Propagate bpf_per_cpu_ptr() to /tools Hao Luo
2020-08-20 17:30 ` Yonghong Song [this message]
2020-08-19 22:40 ` [PATCH bpf-next v1 8/8] bpf/selftests: Test for bpf_per_cpu_ptr() Hao Luo
2020-08-22 3:30 ` Andrii Nakryiko
2020-08-28 3:42 ` Hao Luo
2020-09-01 18:12 ` Andrii Nakryiko
2020-09-01 19:47 ` Hao Luo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f9df603c-f909-a90e-6d92-a661cd1248d7@fb.com \
--to=yhs@fb.com \
--cc=andriin@fb.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=haoluo@google.com \
--cc=jakub@cloudflare.com \
--cc=john.fastabend@gmail.com \
--cc=kafai@fb.com \
--cc=kpsingh@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=quentin@isovalent.com \
--cc=rdna@fb.com \
--cc=rostedt@goodmis.org \
--cc=shuah@kernel.org \
--cc=songliubraving@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).