From: Jeff Johnson <quic_jjohnson@quicinc.com>
To: Pavel Skripkin <paskripkin@gmail.com>,
<ath9k-devel@qca.qualcomm.com>, <kvalo@kernel.org>,
<davem@davemloft.net>, <kuba@kernel.org>, <toke@toke.dk>,
<linville@tuxdriver.com>
Cc: <linux-wireless@vger.kernel.org>, <netdev@vger.kernel.org>,
<linux-kernel@vger.kernel.org>,
<syzbot+03110230a11411024147@syzkaller.appspotmail.com>,
<syzbot+c6dde1f690b60e0b9fbe@syzkaller.appspotmail.com>
Subject: Re: [PATCH v3 1/2] ath9k: fix use-after-free in ath9k_hif_usb_rx_cb
Date: Thu, 12 May 2022 09:05:13 -0700 [thread overview]
Message-ID: <fa713d4a-a3ef-2837-d220-857ed1e5538c@quicinc.com> (raw)
In-Reply-To: <80962aae265995d1cdb724f5362c556d494c7566.1644265120.git.paskripkin@gmail.com>
On 2/7/2022 12:24 PM, Pavel Skripkin wrote:
[...snip...]
>
> #ifdef CONFIG_ATH9K_HTC_DEBUGFS
> -
> -#define TX_STAT_INC(c) (hif_dev->htc_handle->drv_priv->debug.tx_stats.c++)
> -#define TX_STAT_ADD(c, a) (hif_dev->htc_handle->drv_priv->debug.tx_stats.c += a)
> -#define RX_STAT_INC(c) (hif_dev->htc_handle->drv_priv->debug.skbrx_stats.c++)
> -#define RX_STAT_ADD(c, a) (hif_dev->htc_handle->drv_priv->debug.skbrx_stats.c += a)
> +#define __STAT_SAVE(expr) (hif_dev->htc_handle->drv_priv ? (expr) : 0)
> +#define TX_STAT_INC(c) __STAT_SAVE(hif_dev->htc_handle->drv_priv->debug.tx_stats.c++)
> +#define TX_STAT_ADD(c, a) __STAT_SAVE(hif_dev->htc_handle->drv_priv->debug.tx_stats.c += a)
> +#define RX_STAT_INC(c) __STAT_SAVE(hif_dev->htc_handle->drv_priv->debug.skbrx_stats.c++)
> +#define RX_STAT_ADD(c, a) __STAT_SAVE(hif_dev->htc_handle->drv_priv->debug.skbrx_stats.c += a)
it is unfortunate that the existing macros don't abide by the coding style:
Things to avoid when using macros:
macros that depend on having a local variable with a magic name
the companion macros in ath9k/debug.h do the right thing
perhaps this could be given to Kernel Janitors for subsequent cleanup?
next prev parent reply other threads:[~2022-05-12 16:05 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-07 20:24 [PATCH v3 1/2] ath9k: fix use-after-free in ath9k_hif_usb_rx_cb Pavel Skripkin
2022-02-07 20:24 ` [PATCH v3 2/2] ath9k: htc: clean up *STAT_* macros Pavel Skripkin
2022-02-07 21:24 ` Jeff Johnson
2022-02-08 15:32 ` Toke Høiland-Jørgensen
2022-02-08 15:49 ` Pavel Skripkin
2022-02-08 14:47 ` [PATCH v3 1/2] ath9k: fix use-after-free in ath9k_hif_usb_rx_cb Toke Høiland-Jørgensen
2022-02-08 15:48 ` Pavel Skripkin
2022-05-02 6:10 ` Tetsuo Handa
2022-05-05 19:09 ` Pavel Skripkin
2022-05-05 23:31 ` Tetsuo Handa
2022-05-10 19:26 ` Pavel Skripkin
2022-05-11 4:50 ` Kalle Valo
2022-05-11 9:53 ` Toke Høiland-Jørgensen
2022-05-11 9:59 ` Kalle Valo
2022-05-12 12:49 ` Toke Høiland-Jørgensen
2022-05-12 12:55 ` Pavel Skripkin
2022-05-12 13:48 ` Toke Høiland-Jørgensen
2022-05-12 16:05 ` Jeff Johnson [this message]
2022-05-12 16:09 ` Pavel Skripkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fa713d4a-a3ef-2837-d220-857ed1e5538c@quicinc.com \
--to=quic_jjohnson@quicinc.com \
--cc=ath9k-devel@qca.qualcomm.com \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=kvalo@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=netdev@vger.kernel.org \
--cc=paskripkin@gmail.com \
--cc=syzbot+03110230a11411024147@syzkaller.appspotmail.com \
--cc=syzbot+c6dde1f690b60e0b9fbe@syzkaller.appspotmail.com \
--cc=toke@toke.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).