Netdev Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH] ice: set the value of global config lock timeout longer
@ 2021-04-19  9:31 Liwei Song
  2021-04-20 22:48 ` Nguyen, Anthony L
  0 siblings, 1 reply; 6+ messages in thread
From: Liwei Song @ 2021-04-19  9:31 UTC (permalink / raw)
  To: intel-wired-lan, jesse, anthony
  Cc: David, Jakub, netdev, linux-kernel, liwei.song

It may need hold Global Config Lock a longer time when download DDP
package file, extend the timeout value to 5000ms to ensure that
download can be finished before other AQ command got time to run,
this will fix the issue below when probe the device, 5000ms is a test
value that work with both Backplane and BreakoutCable NVM image:

ice 0000:f4:00.0: VSI 12 failed lan queue config, error ICE_ERR_CFG
ice 0000:f4:00.0: Failed to delete VSI 12 in FW - error: ICE_ERR_AQ_TIMEOUT
ice 0000:f4:00.0: probe failed due to setup PF switch: -12
ice: probe of 0000:f4:00.0 failed with error -12

Signed-off-by: Liwei Song <liwei.song@windriver.com>
---
 drivers/net/ethernet/intel/ice/ice_type.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/intel/ice/ice_type.h b/drivers/net/ethernet/intel/ice/ice_type.h
index 266036b7a49a..8a90c47e337d 100644
--- a/drivers/net/ethernet/intel/ice/ice_type.h
+++ b/drivers/net/ethernet/intel/ice/ice_type.h
@@ -63,7 +63,7 @@ enum ice_aq_res_ids {
 /* FW update timeout definitions are in milliseconds */
 #define ICE_NVM_TIMEOUT			180000
 #define ICE_CHANGE_LOCK_TIMEOUT		1000
-#define ICE_GLOBAL_CFG_LOCK_TIMEOUT	3000
+#define ICE_GLOBAL_CFG_LOCK_TIMEOUT	5000
 
 enum ice_aq_res_access_type {
 	ICE_RES_READ = 1,
-- 
2.17.1


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] ice: set the value of global config lock timeout longer
  2021-04-19  9:31 [PATCH] ice: set the value of global config lock timeout longer Liwei Song
@ 2021-04-20 22:48 ` Nguyen, Anthony L
  2021-04-21  2:29   ` Liwei Song
  0 siblings, 1 reply; 6+ messages in thread
From: Nguyen, Anthony L @ 2021-04-20 22:48 UTC (permalink / raw)
  To: liwei.song, intel-wired-lan, Brandeburg, Jesse
  Cc: davem, kuba, Venkataramanan, Anirudh, netdev, linux-kernel

On Mon, 2021-04-19 at 17:31 +0800, Liwei Song wrote:
> It may need hold Global Config Lock a longer time when download DDP
> package file, extend the timeout value to 5000ms to ensure that
> download can be finished before other AQ command got time to run,
> this will fix the issue below when probe the device, 5000ms is a test
> value that work with both Backplane and BreakoutCable NVM image:
> 
> ice 0000:f4:00.0: VSI 12 failed lan queue config, error ICE_ERR_CFG
> ice 0000:f4:00.0: Failed to delete VSI 12 in FW - error:
> ICE_ERR_AQ_TIMEOUT
> ice 0000:f4:00.0: probe failed due to setup PF switch: -12
> ice: probe of 0000:f4:00.0 failed with error -12

Hi Liwei,

We haven't encountered this issue before. Can you provide some more
info on your setup or how you're coming across this issue?

Perhaps, lspci output and some more of the dmesg log? We'd like to try
to reproduce this so we can invesitgate it further.

Thanks,
Tony

> Signed-off-by: Liwei Song <liwei.song@windriver.com>
> ---
>  drivers/net/ethernet/intel/ice/ice_type.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/intel/ice/ice_type.h
> b/drivers/net/ethernet/intel/ice/ice_type.h
> index 266036b7a49a..8a90c47e337d 100644
> --- a/drivers/net/ethernet/intel/ice/ice_type.h
> +++ b/drivers/net/ethernet/intel/ice/ice_type.h
> @@ -63,7 +63,7 @@ enum ice_aq_res_ids {
>  /* FW update timeout definitions are in milliseconds */
>  #define ICE_NVM_TIMEOUT			180000
>  #define ICE_CHANGE_LOCK_TIMEOUT		1000
> -#define ICE_GLOBAL_CFG_LOCK_TIMEOUT	3000
> +#define ICE_GLOBAL_CFG_LOCK_TIMEOUT	5000
>  
>  enum ice_aq_res_access_type {
>  	ICE_RES_READ = 1,

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] ice: set the value of global config lock timeout longer
  2021-04-20 22:48 ` Nguyen, Anthony L
@ 2021-04-21  2:29   ` Liwei Song
  2021-04-22 18:16     ` Nguyen, Anthony L
  0 siblings, 1 reply; 6+ messages in thread
From: Liwei Song @ 2021-04-21  2:29 UTC (permalink / raw)
  To: Nguyen, Anthony L, intel-wired-lan, Brandeburg, Jesse
  Cc: davem, kuba, Venkataramanan, Anirudh, netdev, linux-kernel



On 4/21/21 06:48, Nguyen, Anthony L wrote:
> On Mon, 2021-04-19 at 17:31 +0800, Liwei Song wrote:
>> It may need hold Global Config Lock a longer time when download DDP
>> package file, extend the timeout value to 5000ms to ensure that
>> download can be finished before other AQ command got time to run,
>> this will fix the issue below when probe the device, 5000ms is a test
>> value that work with both Backplane and BreakoutCable NVM image:
>>
>> ice 0000:f4:00.0: VSI 12 failed lan queue config, error ICE_ERR_CFG
>> ice 0000:f4:00.0: Failed to delete VSI 12 in FW - error:
>> ICE_ERR_AQ_TIMEOUT
>> ice 0000:f4:00.0: probe failed due to setup PF switch: -12
>> ice: probe of 0000:f4:00.0 failed with error -12
> 
> Hi Liwei,
> 
> We haven't encountered this issue before. Can you provide some more
> info on your setup or how you're coming across this issue?
> 
> Perhaps, lspci output and some more of the dmesg log? We'd like to try
> to reproduce this so we can invesitgate it further.

Hi Tony,

My board is Idaville ICE-D platform, it can be reproduced when
there is no QSFP Transceiver Module setup on it, it is not
happened on each "modprobe ice", about 1/8 rate to got that
error message when I loop run "modprobe -r ice && modprobe ice".
the port type is Backplane, and I haven't reproduce
it with Breakout mode. 

In Backplane mode:
root@intel-x86-64:~# time modprobe ice

real	0m25.990s
user	0m0.000s
sys	0m0.015s


In Breakout mode(don't have that issue)
root@intel-x86-64:~# time modprobe ice

real    0m1.323s
user    0m0.000s
sys     0m0.022s


The whole message when probe ice:

ice: Intel(R) Ethernet Connection E800 Series Linux Driver
ice: Copyright (c) 2018, Intel Corporation.
ice 0000:f4:00.0: The DDP package was successfully loaded: ICE OS Default Package version 1.3.16.0
ice 0000:f4:00.0: VSI 12 failed lan queue config, error ICE_ERR_CFG
ice 0000:f4:00.0: Failed to delete VSI 12 in FW - error: ICE_ERR_AQ_TIMEOUT
ice 0000:f4:00.0: probe failed due to setup PF switch: -12
ice: probe of 0000:f4:00.0 failed with error -12
ice 0000:f4:00.1: The DDP package was successfully loaded: ICE OS Default Package version 1.3.16.0
ice 0000:f4:00.1: DCB is enabled in the hardware, max number of TCs supported on this port are 8
ice 0000:f4:00.1: FW LLDP is disabled, DCBx/LLDP in SW mode.
ice 0000:f4:00.1: Commit DCB Configuration to the hardware
ice 0000:f4:00.1: 2.000 Gb/s available PCIe bandwidth (2.5 GT/s x1 link)
ice 0000:f4:00.2: DDP package already present on device: ICE OS Default Package version 1.3.16.0
ice 0000:f4:00.2: DCB is enabled in the hardware, max number of TCs supported on this port are 8
ice 0000:f4:00.2: FW LLDP is disabled, DCBx/LLDP in SW mode.
ice 0000:f4:00.2: Commit DCB Configuration to the hardware
ice 0000:f4:00.2: 2.000 Gb/s available PCIe bandwidth (2.5 GT/s x1 link)
ice 0000:f4:00.3: DDP package already present on device: ICE OS Default Package version 1.3.16.0
ice 0000:f4:00.3: DCB is enabled in the hardware, max number of TCs supported on this port are 8
ice 0000:f4:00.3: FW LLDP is disabled, DCBx/LLDP in SW mode.
ice 0000:f4:00.3: Commit DCB Configuration to the hardware
ice 0000:f4:00.3: 2.000 Gb/s available PCIe bandwidth (2.5 GT/s x1 link)



lspci:

f4:00.0 Ethernet controller [0200]: Intel Corporation Device [8086:124c]
	Subsystem: Intel Corporation Device [8086:0000]
	Flags: bus master, fast devsel, latency 0, IRQ 16, NUMA node 0
	Memory at 22ff0000000 (64-bit, prefetchable) [size=128M]
	Memory at 22ffc030000 (64-bit, prefetchable) [size=64K]
	Expansion ROM at d8000000 [disabled] [size=1M]
	Capabilities: [40] Power Management version 3
	Capabilities: [50] MSI: Enable- Count=1/1 Maskable+ 64bit+
	Capabilities: [70] MSI-X: Enable+ Count=512 Masked-
	Capabilities: [a0] Express Endpoint, MSI 00
	Capabilities: [e0] Vital Product Data
	Capabilities: [100] Advanced Error Reporting
	Capabilities: [148] Alternative Routing-ID Interpretation (ARI)
	Capabilities: [160] Single Root I/O Virtualization (SR-IOV)
	Capabilities: [1a0] Transaction Processing Hints
	Capabilities: [1b0] Access Control Services
	Kernel driver in use: ice
	Kernel modules: ice


ethtool info:

root@intel-x86-64:~# ethtool eth1
Settings for eth1:
	Supported ports: [ ]
	Supported link modes:   1000baseKX/Full 
	                        10000baseKR/Full 
	Supported pause frame use: Symmetric
	Supports auto-negotiation: Yes
	Supported FEC modes: None
	Advertised link modes:  1000baseKX/Full 
	                        10000baseKR/Full 
	Advertised pause frame use: No
	Advertised auto-negotiation: Yes
	Advertised FEC modes: None
	Speed: Unknown!
	Duplex: Unknown! (255)
	Port: Other
	PHYAD: 0
	Transceiver: internal
	Auto-negotiation: off
	Supports Wake-on: g
	Wake-on: d
	Current message level: 0x00000007 (7)
			       drv probe link
	Link detected: no


root@intel-x86-64:~# ethtool -i eth1
driver: ice
version: 5.12.0-rc5+
firmware-version: 1.24 0x80005e12 1.2817.0
expansion-rom-version: 
bus-info: 0000:f4:00.0
supports-statistics: yes
supports-test: yes
supports-eeprom-access: yes
supports-register-dump: yes
supports-priv-flags: yes

Thanks,
Liwei.

> 
> Thanks,
> Tony
> 
>> Signed-off-by: Liwei Song <liwei.song@windriver.com>
>> ---
>>  drivers/net/ethernet/intel/ice/ice_type.h | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/net/ethernet/intel/ice/ice_type.h
>> b/drivers/net/ethernet/intel/ice/ice_type.h
>> index 266036b7a49a..8a90c47e337d 100644
>> --- a/drivers/net/ethernet/intel/ice/ice_type.h
>> +++ b/drivers/net/ethernet/intel/ice/ice_type.h
>> @@ -63,7 +63,7 @@ enum ice_aq_res_ids {
>>  /* FW update timeout definitions are in milliseconds */
>>  #define ICE_NVM_TIMEOUT			180000
>>  #define ICE_CHANGE_LOCK_TIMEOUT		1000
>> -#define ICE_GLOBAL_CFG_LOCK_TIMEOUT	3000
>> +#define ICE_GLOBAL_CFG_LOCK_TIMEOUT	5000
>>  
>>  enum ice_aq_res_access_type {
>>  	ICE_RES_READ = 1,

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] ice: set the value of global config lock timeout longer
  2021-04-21  2:29   ` Liwei Song
@ 2021-04-22 18:16     ` Nguyen, Anthony L
  2021-05-04  0:44       ` Nguyen, Anthony L
  0 siblings, 1 reply; 6+ messages in thread
From: Nguyen, Anthony L @ 2021-04-22 18:16 UTC (permalink / raw)
  To: liwei.song, intel-wired-lan, Brandeburg, Jesse
  Cc: davem, kuba, Venkataramanan, Anirudh, netdev, linux-kernel

On Wed, 2021-04-21 at 10:29 +0800, Liwei Song wrote:
> 
> On 4/21/21 06:48, Nguyen, Anthony L wrote:
> > On Mon, 2021-04-19 at 17:31 +0800, Liwei Song wrote:
> > > It may need hold Global Config Lock a longer time when download
> > > DDP
> > > package file, extend the timeout value to 5000ms to ensure that
> > > download can be finished before other AQ command got time to run,
> > > this will fix the issue below when probe the device, 5000ms is a
> > > test
> > > value that work with both Backplane and BreakoutCable NVM image:
> > > 
> > > ice 0000:f4:00.0: VSI 12 failed lan queue config, error
> > > ICE_ERR_CFG
> > > ice 0000:f4:00.0: Failed to delete VSI 12 in FW - error:
> > > ICE_ERR_AQ_TIMEOUT
> > > ice 0000:f4:00.0: probe failed due to setup PF switch: -12
> > > ice: probe of 0000:f4:00.0 failed with error -12
> > 
> > Hi Liwei,
> > 
> > We haven't encountered this issue before. Can you provide some more
> > info on your setup or how you're coming across this issue?
> > 
> > Perhaps, lspci output and some more of the dmesg log? We'd like to
> > try
> > to reproduce this so we can invesitgate it further.
> 
> Hi Tony,
> 
> My board is Idaville ICE-D platform, it can be reproduced when
> there is no QSFP Transceiver Module setup on it, it is not
> happened on each "modprobe ice", about 1/8 rate to got that
> error message when I loop run "modprobe -r ice && modprobe ice".
> the port type is Backplane, and I haven't reproduce
> it with Breakout mode. 

Hi Liwei, 

Thanks for the additional information. I've provided this to our
validation team and asked they try to reproduce so we can look into it further.

Thanks,
Tony

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] ice: set the value of global config lock timeout longer
  2021-04-22 18:16     ` Nguyen, Anthony L
@ 2021-05-04  0:44       ` Nguyen, Anthony L
  2021-05-06  1:54         ` Liwei Song
  0 siblings, 1 reply; 6+ messages in thread
From: Nguyen, Anthony L @ 2021-05-04  0:44 UTC (permalink / raw)
  To: liwei.song, intel-wired-lan, Brandeburg, Jesse
  Cc: davem, kuba, Venkataramanan, Anirudh, netdev, linux-kernel

On Thu, 2021-04-22 at 11:16 -0700, Tony Nguyen wrote:
> On Wed, 2021-04-21 at 10:29 +0800, Liwei Song wrote:
> > 
> > On 4/21/21 06:48, Nguyen, Anthony L wrote:
> > > On Mon, 2021-04-19 at 17:31 +0800, Liwei Song wrote:
> > > > It may need hold Global Config Lock a longer time when download
> > > > DDP
> > > > package file, extend the timeout value to 5000ms to ensure that
> > > > download can be finished before other AQ command got time to
> > > > run,
> > > > this will fix the issue below when probe the device, 5000ms is
> > > > a
> > > > test
> > > > value that work with both Backplane and BreakoutCable NVM
> > > > image:
> > > > 
> > > > ice 0000:f4:00.0: VSI 12 failed lan queue config, error
> > > > ICE_ERR_CFG
> > > > ice 0000:f4:00.0: Failed to delete VSI 12 in FW - error:
> > > > ICE_ERR_AQ_TIMEOUT
> > > > ice 0000:f4:00.0: probe failed due to setup PF switch: -12
> > > > ice: probe of 0000:f4:00.0 failed with error -12
> > > 
> > > Hi Liwei,
> > > 
> > > We haven't encountered this issue before. Can you provide some
> > > more
> > > info on your setup or how you're coming across this issue?
> > > 
> > > Perhaps, lspci output and some more of the dmesg log? We'd like
> > > to
> > > try
> > > to reproduce this so we can invesitgate it further.
> > 
> > Hi Tony,
> > 
> > My board is Idaville ICE-D platform, it can be reproduced when
> > there is no QSFP Transceiver Module setup on it, it is not
> > happened on each "modprobe ice", about 1/8 rate to got that
> > error message when I loop run "modprobe -r ice && modprobe ice".
> > the port type is Backplane, and I haven't reproduce
> > it with Breakout mode. 
> 
> Hi Liwei, 
> 
> Thanks for the additional information. I've provided this to our
> validation team and asked they try to reproduce so we can look into
> it further.

Hi Liwei,

We were able to reproduce the issue. We found that this doesn't occur
on newer NVMs, however, it will still be awhile until those newer ones
are available.

In the interim, I'm going to have this patch tested to ensure it
doesn't cause any issues. If so, we'll use this value until the new
NVMs become available.

Thanks,
Tony

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] ice: set the value of global config lock timeout longer
  2021-05-04  0:44       ` Nguyen, Anthony L
@ 2021-05-06  1:54         ` Liwei Song
  0 siblings, 0 replies; 6+ messages in thread
From: Liwei Song @ 2021-05-06  1:54 UTC (permalink / raw)
  To: Nguyen, Anthony L, intel-wired-lan, Brandeburg, Jesse
  Cc: davem, kuba, Venkataramanan, Anirudh, netdev, linux-kernel



On 5/4/21 08:44, Nguyen, Anthony L wrote:
> On Thu, 2021-04-22 at 11:16 -0700, Tony Nguyen wrote:
>> On Wed, 2021-04-21 at 10:29 +0800, Liwei Song wrote:
>>>
>>> On 4/21/21 06:48, Nguyen, Anthony L wrote:
>>>> On Mon, 2021-04-19 at 17:31 +0800, Liwei Song wrote:
>>>>> It may need hold Global Config Lock a longer time when download
>>>>> DDP
>>>>> package file, extend the timeout value to 5000ms to ensure that
>>>>> download can be finished before other AQ command got time to
>>>>> run,
>>>>> this will fix the issue below when probe the device, 5000ms is
>>>>> a
>>>>> test
>>>>> value that work with both Backplane and BreakoutCable NVM
>>>>> image:
>>>>>
>>>>> ice 0000:f4:00.0: VSI 12 failed lan queue config, error
>>>>> ICE_ERR_CFG
>>>>> ice 0000:f4:00.0: Failed to delete VSI 12 in FW - error:
>>>>> ICE_ERR_AQ_TIMEOUT
>>>>> ice 0000:f4:00.0: probe failed due to setup PF switch: -12
>>>>> ice: probe of 0000:f4:00.0 failed with error -12
>>>>
>>>> Hi Liwei,
>>>>
>>>> We haven't encountered this issue before. Can you provide some
>>>> more
>>>> info on your setup or how you're coming across this issue?
>>>>
>>>> Perhaps, lspci output and some more of the dmesg log? We'd like
>>>> to
>>>> try
>>>> to reproduce this so we can invesitgate it further.
>>>
>>> Hi Tony,
>>>
>>> My board is Idaville ICE-D platform, it can be reproduced when
>>> there is no QSFP Transceiver Module setup on it, it is not
>>> happened on each "modprobe ice", about 1/8 rate to got that
>>> error message when I loop run "modprobe -r ice && modprobe ice".
>>> the port type is Backplane, and I haven't reproduce
>>> it with Breakout mode. 
>>
>> Hi Liwei, 
>>
>> Thanks for the additional information. I've provided this to our
>> validation team and asked they try to reproduce so we can look into
>> it further.
> 
> Hi Liwei,
> 
> We were able to reproduce the issue. We found that this doesn't occur
> on newer NVMs, however, it will still be awhile until those newer ones
> are available.
> 
> In the interim, I'm going to have this patch tested to ensure it
> doesn't cause any issues. If so, we'll use this value until the new
> NVMs become available.

Hi Tony,

Got it, and thanks for the update.

Liwei.


> 
> Thanks,
> Tony
> 

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, back to index

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-19  9:31 [PATCH] ice: set the value of global config lock timeout longer Liwei Song
2021-04-20 22:48 ` Nguyen, Anthony L
2021-04-21  2:29   ` Liwei Song
2021-04-22 18:16     ` Nguyen, Anthony L
2021-05-04  0:44       ` Nguyen, Anthony L
2021-05-06  1:54         ` Liwei Song

Netdev Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/netdev/0 netdev/git/0.git
	git clone --mirror https://lore.kernel.org/netdev/1 netdev/git/1.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 netdev netdev/ https://lore.kernel.org/netdev \
		netdev@vger.kernel.org
	public-inbox-index netdev

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.netdev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git