From: Gal Pressman <galpress@amazon.com>
To: Leon Romanovsky <leon@kernel.org>
Cc: "David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Leon Romanovsky <leonro@mellanox.com>,
linux-netdev <netdev@vger.kernel.org>,
Arthur Kiyanovski <akiyano@amazon.com>,
Zorik Machulsky <zorik@amazon.com>,
Guy Tzalik <gtzalik@amazon.com>,
Alexander Matushevsky <matua@amazon.com>,
Sameeh Jubran <sameehj@amazon.com>,
Saeed Bishara <saeedb@amazon.com>
Subject: Re: [PATCH net-next 11/16] net/amazon: Ensure that driver version is aligned to the linux kernel
Date: Sun, 23 Feb 2020 10:54:29 +0200 [thread overview]
Message-ID: <fb459df1-a1f7-964c-74a9-2f8e7a4ba26b@amazon.com> (raw)
In-Reply-To: <20200220145855.255704-12-leon@kernel.org>
On 20/02/2020 16:58, Leon Romanovsky wrote:
> From: Leon Romanovsky <leonro@mellanox.com>
>
>
> Upstream drivers are managed inside global repository and released all
> together, this ensure that driver version is the same as linux kernel,
> so update amazon drivers to properly reflect it.
>
> Signed-off-by: Leon Romanovsky <leonro@mellanox.com>
> ---
> drivers/net/ethernet/amazon/ena/ena_ethtool.c | 1 -
> drivers/net/ethernet/amazon/ena/ena_netdev.c | 17 ++---------------
> drivers/net/ethernet/amazon/ena/ena_netdev.h | 11 -----------
> 3 files changed, 2 insertions(+), 27 deletions(-)
>
> diff --git a/drivers/net/ethernet/amazon/ena/ena_ethtool.c b/drivers/net/ethernet/amazon/ena/ena_ethtool.c
> index ced1d577b62a..19262f37db84 100644
> --- a/drivers/net/ethernet/amazon/ena/ena_ethtool.c
> +++ b/drivers/net/ethernet/amazon/ena/ena_ethtool.c
> @@ -404,7 +404,6 @@ static void ena_get_drvinfo(struct net_device *dev,
> struct ena_adapter *adapter = netdev_priv(dev);
>
> strlcpy(info->driver, DRV_MODULE_NAME, sizeof(info->driver));
> - strlcpy(info->version, DRV_MODULE_VERSION, sizeof(info->version));
> strlcpy(info->bus_info, pci_name(adapter->pdev),
> sizeof(info->bus_info));
> }
> diff --git a/drivers/net/ethernet/amazon/ena/ena_netdev.c b/drivers/net/ethernet/amazon/ena/ena_netdev.c
> index 0b2fd96b93d7..4faf81c456d8 100644
> --- a/drivers/net/ethernet/amazon/ena/ena_netdev.c
> +++ b/drivers/net/ethernet/amazon/ena/ena_netdev.c
> @@ -49,12 +49,9 @@
> #include <linux/bpf_trace.h>
> #include "ena_pci_id_tbl.h"
>
> -static char version[] = DEVICE_NAME " v" DRV_MODULE_VERSION "\n";
> -
> MODULE_AUTHOR("Amazon.com, Inc. or its affiliates");
> MODULE_DESCRIPTION(DEVICE_NAME);
> MODULE_LICENSE("GPL");
> -MODULE_VERSION(DRV_MODULE_VERSION);
>
> /* Time in jiffies before concluding the transmitter is hung. */
> #define TX_TIMEOUT (5 * HZ)
> @@ -3093,11 +3090,7 @@ static void ena_config_host_info(struct ena_com_dev *ena_dev,
> host_info->os_dist = 0;
> strncpy(host_info->os_dist_str, utsname()->release,
> sizeof(host_info->os_dist_str) - 1);
> - host_info->driver_version =
> - (DRV_MODULE_VER_MAJOR) |
> - (DRV_MODULE_VER_MINOR << ENA_ADMIN_HOST_INFO_MINOR_SHIFT) |
> - (DRV_MODULE_VER_SUBMINOR << ENA_ADMIN_HOST_INFO_SUB_MINOR_SHIFT) |
> - ("K"[0] << ENA_ADMIN_HOST_INFO_MODULE_TYPE_SHIFT);
> + host_info->driver_version = LINUX_VERSION_CODE;
Hey Leon,
I'm not sure it's safe to replace this one, adding ENA people..
next prev parent reply other threads:[~2020-02-23 8:54 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-20 14:58 [PATCH net-next 00/16] Clean driver, module and FW versions Leon Romanovsky
2020-02-20 14:58 ` [PATCH net-next 01/16] net/bond: Delete driver and module versions Leon Romanovsky
2020-02-20 14:58 ` [PATCH net-next 02/16] net/dummy: Ditch " Leon Romanovsky
2020-02-21 9:11 ` Sergei Shtylyov
2020-02-22 7:28 ` Leon Romanovsky
2020-02-20 14:58 ` [PATCH net-next 03/16] net/3com: Delete driver and module versions from 3com drivers Leon Romanovsky
2020-02-20 14:58 ` [PATCH net-next 04/16] net/adaptec: Clean driver versions Leon Romanovsky
2020-02-20 14:58 ` [PATCH net-next 05/16] net/aeroflex: Clean ethtool_info struct assignments Leon Romanovsky
2020-02-20 14:58 ` [PATCH net-next 06/16] net/agere: Delete unneeded driver version Leon Romanovsky
2020-02-20 14:58 ` [PATCH net-next 07/16] net/alacritech: Delete " Leon Romanovsky
2020-02-20 14:58 ` [PATCH net-next 08/16] net/allwinner: Remove " Leon Romanovsky
2020-02-20 14:58 ` [PATCH net-next 09/16] net/alteon: Properly report FW version Leon Romanovsky
2020-02-20 14:58 ` [PATCH net-next 10/16] net/althera: Delete hardcoded driver version Leon Romanovsky
2020-02-20 14:58 ` [PATCH net-next 11/16] net/amazon: Ensure that driver version is aligned to the linux kernel Leon Romanovsky
2020-02-23 8:54 ` Gal Pressman [this message]
2020-02-23 9:10 ` Leon Romanovsky
2020-02-20 14:58 ` [PATCH net-next 12/16] net/amd: Remove useless driver version Leon Romanovsky
2020-02-20 14:58 ` [PATCH net-next 13/16] net/apm: Remove useless driver version and properly mark lack of FW Leon Romanovsky
2020-02-20 14:58 ` [PATCH net-next 14/16] net/aquantia: Delete module version Leon Romanovsky
2020-02-20 14:58 ` [PATCH net-next 15/16] net/arc: Delete driver version Leon Romanovsky
2020-02-20 14:58 ` [PATCH net-next 16/16] net/atheros: Clean atheros code from " Leon Romanovsky
2020-02-21 1:17 ` [PATCH net-next 00/16] Clean driver, module and FW versions Jakub Kicinski
2020-02-21 19:35 ` David Miller
2020-02-22 7:27 ` Leon Romanovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fb459df1-a1f7-964c-74a9-2f8e7a4ba26b@amazon.com \
--to=galpress@amazon.com \
--cc=akiyano@amazon.com \
--cc=davem@davemloft.net \
--cc=gtzalik@amazon.com \
--cc=kuba@kernel.org \
--cc=leon@kernel.org \
--cc=leonro@mellanox.com \
--cc=matua@amazon.com \
--cc=netdev@vger.kernel.org \
--cc=saeedb@amazon.com \
--cc=sameehj@amazon.com \
--cc=zorik@amazon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).