netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Bernard f6bvp <f6bvp@free.fr>
To: edumazet@google.com
Cc: davem@davemloft.net, duoming@zju.edu.cn, f6bvp@free.fr,
	kuba@kernel.org, linux-hams@vger.kernel.org,
	linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
	pabeni@redhat.com, ralf@linux-mips.org
Subject: Re: [PATCH] net: rose: fix unregistered netdevice: waiting for rose0 to become free
Date: Sat, 23 Jul 2022 11:55:13 +0200	[thread overview]
Message-ID: <fb7544a1-f42e-9254-18cc-c9b071f4ca70@free.fr> (raw)
In-Reply-To: <CANn89i+-THx+jTzsLDxaX9diV4hz7z4mYqwn2CjtydFp+U4gow@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 177 bytes --]


I modified .config according to
CONFIG_NET_DEV_REFCNT_TRACKER=y
then compiled moduled and ran my usual AX25 and ROSE applications.

Attached is (I hope) relevant dmesg dump.



[-- Attachment #2: dmesg_tracker.txt --]
[-- Type: text/plain, Size: 13656 bytes --]


[    0.000000] microcode: microcode updated early to revision 0x26, date = 2019-11-12
[    0.000000] Linux version 5.18.11-F6BVP (root@ubuntu-f6bvp) (gcc (Ubuntu 11.2.0-19ubuntu1) 11.2.0, GNU ld (GNU Binutils for Ubuntu) 2.38) #3 SMP PREEMPT_DYNAMIC Sat Jul 23 01:14:23 CEST 2022
[    0.000000] Command line: BOOT_IMAGE=/boot/vmlinuz-5.18.11-F6BVP root=UUID=3ba9ef9f-79fe-49dd-b301-9a509571f7a6 ro quiet splash vt.handoff=7
[    0.000000] KERNEL supported cpus:
[    0.000000]   Intel GenuineIntel
[    0.000000]   AMD AuthenticAMD
[    0.000000]   Hygon HygonGenuine
[    0.000000]   Centaur CentaurHauls
[    0.000000]   zhaoxin   Shanghai  
...
[   48.485509] NET: Registered PF_AX25 protocol family
[   48.520677] NET: Registered PF_ROSE protocol family
[   56.854635] NET: Unregistered PF_ROSE protocol family
[   59.235217] NET: Unregistered PF_AX25 protocol family
[   69.314892] NET: Registered PF_AX25 protocol family
[   69.320617] mkiss: AX.25 Multikiss, Hans Albas PE1AYX
[   69.321340] mkiss: ax0: crc mode is auto.
[   69.321481] IPv6: ADDRCONF(NETDEV_CHANGE): ax0: link becomes ready
[   71.363304] NET: Registered PF_NETROM protocol family
[   73.477000] NET: Registered PF_ROSE protocol family
[   79.487926] mkiss: ax0: Trying crc-smack
[   79.488053] mkiss: ax0: Trying crc-flexnet
[  205.798723] reference already released.
[  205.798732] allocated in:
[  205.798734]  ax25_bind+0x1a2/0x230 [ax25]
[  205.798747]  __sys_bind+0xea/0x110
[  205.798753]  __x64_sys_bind+0x18/0x20
[  205.798758]  do_syscall_64+0x5c/0x80
[  205.798763]  entry_SYSCALL_64_after_hwframe+0x44/0xae
[  205.798768] freed in:
[  205.798770]  ax25_release+0x115/0x370 [ax25]
[  205.798778]  __sock_release+0x42/0xb0
[  205.798782]  sock_close+0x15/0x20
[  205.798785]  __fput+0x9f/0x260
[  205.798789]  ____fput+0xe/0x10
[  205.798792]  task_work_run+0x64/0xa0
[  205.798798]  exit_to_user_mode_prepare+0x18b/0x190
[  205.798804]  syscall_exit_to_user_mode+0x26/0x40
[  205.798808]  do_syscall_64+0x69/0x80
[  205.798812]  entry_SYSCALL_64_after_hwframe+0x44/0xae
[  205.798827] ------------[ cut here ]------------
[  205.798829] WARNING: CPU: 2 PID: 2605 at lib/ref_tracker.c:136 ref_tracker_free.cold+0x60/0x81
[  205.798837] Modules linked in: rose netrom mkiss ax25 rfcomm cmac algif_hash algif_skcipher af_alg bnep snd_hda_codec_hdmi nls_iso8859_1 i915 rtw88_8821ce rtw88_8821c x86_pkg_temp_thermal rtw88_pci intel_powerclamp rtw88_core snd_hda_codec_realtek snd_hda_codec_generic ledtrig_audio coretemp snd_hda_intel kvm_intel snd_intel_dspcfg mac80211 snd_hda_codec kvm i2c_algo_bit drm_buddy drm_dp_helper btusb drm_kms_helper snd_hwdep btrtl snd_hda_core btbcm joydev crct10dif_pclmul btintel crc32_pclmul ghash_clmulni_intel mei_hdcp btmtk intel_rapl_msr aesni_intel bluetooth input_leds snd_pcm crypto_simd syscopyarea processor_thermal_device_pci_legacy sysfillrect cryptd intel_soc_dts_iosf snd_seq sysimgblt ecdh_generic fb_sys_fops rapl libarc4 processor_thermal_device intel_cstate processor_thermal_rfim cec snd_timer ecc snd_seq_device cfg80211 processor_thermal_mbox mei_me processor_thermal_rapl mei rc_core at24 snd intel_pch_thermal intel_rapl_common ttm soundcore int340x_thermal_zone video
[  205.798948]  mac_hid acpi_pad sch_fq_codel ipmi_devintf ipmi_msghandler drm msr parport_pc ppdev lp parport ramoops pstore_blk reed_solomon pstore_zone efi_pstore ip_tables x_tables autofs4 hid_generic usbhid hid i2c_i801 i2c_smbus r8169 xhci_pci ahci libahci realtek lpc_ich xhci_pci_renesas [last unloaded: ax25]
[  205.798992] CPU: 2 PID: 2605 Comm: ax25ipd Not tainted 5.18.11-F6BVP #3
[  205.798996] Hardware name: To be filled by O.E.M. To be filled by O.E.M./CK3, BIOS 5.011 09/16/2020
[  205.798999] RIP: 0010:ref_tracker_free.cold+0x60/0x81
[  205.799005] Code: e8 d2 01 9b ff 83 7b 18 00 74 14 48 c7 c7 2f d7 ff 98 e8 10 6e fc ff 8b 7b 18 e8 b8 01 9b ff 4c 89 ee 4c 89 e7 e8 5d fd 07 00 <0f> 0b b8 ea ff ff ff e9 30 05 9b ff 41 0f b6 f7 48 c7 c7 a0 fa 4e
[  205.799008] RSP: 0018:ffffaf5281073958 EFLAGS: 00010286
[  205.799011] RAX: 0000000080000000 RBX: ffff9a0bd687ebe0 RCX: 0000000000000000
[  205.799014] RDX: 0000000000000001 RSI: 0000000000000282 RDI: 00000000ffffffff
[  205.799016] RBP: ffffaf5281073a10 R08: 0000000000000003 R09: fffffffffffd5618
[  205.799019] R10: 0000000000ffff10 R11: 000000000000000f R12: ffff9a0bc53384d0
[  205.799022] R13: 0000000000000282 R14: 00000000ae000001 R15: 0000000000000001
[  205.799024] FS:  0000000000000000(0000) GS:ffff9a0d0f300000(0000) knlGS:0000000000000000
[  205.799028] CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
[  205.799031] CR2: 00007ff6b8311554 CR3: 000000001ac10004 CR4: 00000000001706e0
[  205.799033] Call Trace:
[  205.799035]  <TASK>
[  205.799038]  ? ax25_dev_device_down+0xd9/0x1b0 [ax25]
[  205.799047]  ? ax25_device_event+0x9f/0x270 [ax25]
[  205.799055]  ? raw_notifier_call_chain+0x49/0x60
[  205.799060]  ? call_netdevice_notifiers_info+0x52/0xa0
[  205.799065]  ? dev_close_many+0xc8/0x120
[  205.799070]  ? unregister_netdevice_many+0x13d/0x890
[  205.799073]  ? unregister_netdevice_queue+0x90/0xe0
[  205.799076]  ? unregister_netdev+0x1d/0x30
[  205.799080]  ? mkiss_close+0x7c/0xc0 [mkiss]
[  205.799084]  ? tty_ldisc_close+0x2e/0x40
[  205.799089]  ? tty_ldisc_hangup+0x137/0x210
[  205.799092]  ? __tty_hangup.part.0+0x208/0x350
[  205.799098]  ? tty_vhangup+0x15/0x20
[  205.799103]  ? pty_close+0x127/0x160
[  205.799108]  ? tty_release+0x139/0x5e0
[  205.799112]  ? __fput+0x9f/0x260
[  205.799118]  ax25_dev_device_down+0xd9/0x1b0 [ax25]
[  205.799126]  ax25_device_event+0x9f/0x270 [ax25]
[  205.799135]  raw_notifier_call_chain+0x49/0x60
[  205.799140]  call_netdevice_notifiers_info+0x52/0xa0
[  205.799146]  dev_close_many+0xc8/0x120
[  205.799152]  unregister_netdevice_many+0x13d/0x890
[  205.799157]  unregister_netdevice_queue+0x90/0xe0
[  205.799161]  unregister_netdev+0x1d/0x30
[  205.799165]  mkiss_close+0x7c/0xc0 [mkiss]
[  205.799170]  tty_ldisc_close+0x2e/0x40
[  205.799173]  tty_ldisc_hangup+0x137/0x210
[  205.799178]  __tty_hangup.part.0+0x208/0x350
[  205.799184]  tty_vhangup+0x15/0x20
[  205.799188]  pty_close+0x127/0x160
[  205.799193]  tty_release+0x139/0x5e0
[  205.799199]  __fput+0x9f/0x260
[  205.799203]  ____fput+0xe/0x10
[  205.799208]  task_work_run+0x64/0xa0
[  205.799213]  do_exit+0x33b/0xab0
[  205.799217]  ? __handle_mm_fault+0xc4f/0x15f0
[  205.799224]  do_group_exit+0x35/0xa0
[  205.799228]  __x64_sys_exit_group+0x18/0x20
[  205.799232]  do_syscall_64+0x5c/0x80
[  205.799238]  ? handle_mm_fault+0xba/0x290
[  205.799242]  ? debug_smp_processor_id+0x17/0x20
[  205.799246]  ? fpregs_assert_state_consistent+0x26/0x50
[  205.799251]  ? exit_to_user_mode_prepare+0x49/0x190
[  205.799256]  ? irqentry_exit_to_user_mode+0x9/0x20
[  205.799260]  ? irqentry_exit+0x33/0x40
[  205.799263]  ? exc_page_fault+0x87/0x170
[  205.799268]  ? asm_exc_page_fault+0x8/0x30
[  205.799273]  entry_SYSCALL_64_after_hwframe+0x44/0xae
[  205.799277] RIP: 0033:0x7ff6b80eaca1
[  205.799281] Code: Unable to access opcode bytes at RIP 0x7ff6b80eac77.
[  205.799283] RSP: 002b:00007fff6dfd4738 EFLAGS: 00000246 ORIG_RAX: 00000000000000e7
[  205.799287] RAX: ffffffffffffffda RBX: 00007ff6b8215a00 RCX: 00007ff6b80eaca1
[  205.799290] RDX: 000000000000003c RSI: 00000000000000e7 RDI: 0000000000000001
[  205.799293] RBP: 0000000000000001 R08: ffffffffffffff80 R09: 0000000000000028
[  205.799295] R10: 0000000000000000 R11: 0000000000000246 R12: 00007ff6b8215a00
[  205.799298] R13: 0000000000000000 R14: 00007ff6b821aee8 R15: 00007ff6b821af00
[  205.799304]  </TASK>
[  205.799306] ---[ end trace 0000000000000000 ]---
[  205.823488] leaked reference.
[  205.823500]  ax25_dev_device_up+0x6b/0x160 [ax25]
[  205.823514]  ax25_device_event+0x1c6/0x270 [ax25]
[  205.823522]  raw_notifier_call_chain+0x49/0x60
[  205.823529]  call_netdevice_notifiers_info+0x52/0xa0
[  205.823535]  __dev_notify_flags+0x58/0xe0
[  205.823538]  dev_change_flags+0x51/0x60
[  205.823542]  devinet_ioctl+0x614/0x810
[  205.823546]  inet_ioctl+0x165/0x190
[  205.823548]  sock_do_ioctl+0x45/0x100
[  205.823552]  sock_ioctl+0xef/0x310
[  205.823555]  __x64_sys_ioctl+0x91/0xc0
[  205.823559]  do_syscall_64+0x5c/0x80
[  205.823565]  entry_SYSCALL_64_after_hwframe+0x44/0xae
[  205.823586] ------------[ cut here ]------------
[  205.823589] WARNING: CPU: 2 PID: 2605 at lib/ref_tracker.c:39 ref_tracker_dir_exit.cold+0x66/0x72
[  205.823599] Modules linked in: rose netrom mkiss ax25 rfcomm cmac algif_hash algif_skcipher af_alg bnep snd_hda_codec_hdmi nls_iso8859_1 i915 rtw88_8821ce rtw88_8821c x86_pkg_temp_thermal rtw88_pci intel_powerclamp rtw88_core snd_hda_codec_realtek snd_hda_codec_generic ledtrig_audio coretemp snd_hda_intel kvm_intel snd_intel_dspcfg mac80211 snd_hda_codec kvm i2c_algo_bit drm_buddy drm_dp_helper btusb drm_kms_helper snd_hwdep btrtl snd_hda_core btbcm joydev crct10dif_pclmul btintel crc32_pclmul ghash_clmulni_intel mei_hdcp btmtk intel_rapl_msr aesni_intel bluetooth input_leds snd_pcm crypto_simd syscopyarea processor_thermal_device_pci_legacy sysfillrect cryptd intel_soc_dts_iosf snd_seq sysimgblt ecdh_generic fb_sys_fops rapl libarc4 processor_thermal_device intel_cstate processor_thermal_rfim cec snd_timer ecc snd_seq_device cfg80211 processor_thermal_mbox mei_me processor_thermal_rapl mei rc_core at24 snd intel_pch_thermal intel_rapl_common ttm soundcore int340x_thermal_zone video
[  205.823697]  mac_hid acpi_pad sch_fq_codel ipmi_devintf ipmi_msghandler drm msr parport_pc ppdev lp parport ramoops pstore_blk reed_solomon pstore_zone efi_pstore ip_tables x_tables autofs4 hid_generic usbhid hid i2c_i801 i2c_smbus r8169 xhci_pci ahci libahci realtek lpc_ich xhci_pci_renesas [last unloaded: ax25]
[  205.823732] CPU: 2 PID: 2605 Comm: ax25ipd Tainted: G        W         5.18.11-F6BVP #3
[  205.823736] Hardware name: To be filled by O.E.M. To be filled by O.E.M./CK3, BIOS 5.011 09/16/2020
[  205.823738] RIP: 0010:ref_tracker_dir_exit.cold+0x66/0x72
[  205.823744] Code: 00 00 00 ad de 49 89 44 24 08 4d 89 2c 24 49 89 dc e8 7d d8 67 ff 48 8b 03 4c 39 fb 75 13 48 8b 75 d0 4c 89 f7 e8 c9 fd 07 00 <0f> 0b e9 5f 04 9b ff 48 89 c3 eb 98 41 0f b6 f5 48 c7 c7 c0 fa 4e
[  205.823747] RSP: 0018:ffffaf5281073ba0 EFLAGS: 00010286
[  205.823750] RAX: 0000000080000000 RBX: ffff9a0bc53384e8 RCX: 0000000000000000
[  205.823753] RDX: 0000000000000001 RSI: 0000000000000286 RDI: 00000000ffffffff
[  205.823755] RBP: ffffaf5281073bd0 R08: ffff9a0be6c54a00 R09: 000000000080005f
[  205.823757] R10: 0000000000ffff10 R11: 0000000000000000 R12: ffff9a0bc53384e8
[  205.823759] R13: dead000000000100 R14: ffff9a0bc53384d0 R15: ffff9a0bc53384e8
[  205.823762] FS:  0000000000000000(0000) GS:ffff9a0d0f300000(0000) knlGS:0000000000000000
[  205.823764] CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
[  205.823766] CR2: 00007fc64c0945f8 CR3: 000000001ac10002 CR4: 00000000001706e0
[  205.823769] Call Trace:
[  205.823771]  <TASK>
[  205.823775]  free_netdev+0xf0/0x1d0
[  205.823783]  mkiss_close+0x9e/0xc0 [mkiss]
[  205.823788]  tty_ldisc_close+0x2e/0x40
[  205.823792]  tty_ldisc_hangup+0x137/0x210
[  205.823795]  __tty_hangup.part.0+0x208/0x350
[  205.823802]  tty_vhangup+0x15/0x20
[  205.823807]  pty_close+0x127/0x160
[  205.823811]  tty_release+0x139/0x5e0
[  205.823817]  __fput+0x9f/0x260
[  205.823822]  ____fput+0xe/0x10
[  205.823826]  task_work_run+0x64/0xa0
[  205.823832]  do_exit+0x33b/0xab0
[  205.823836]  ? __handle_mm_fault+0xc4f/0x15f0
[  205.823843]  do_group_exit+0x35/0xa0
[  205.823847]  __x64_sys_exit_group+0x18/0x20
[  205.823850]  do_syscall_64+0x5c/0x80
[  205.823855]  ? handle_mm_fault+0xba/0x290
[  205.823859]  ? debug_smp_processor_id+0x17/0x20
[  205.823862]  ? fpregs_assert_state_consistent+0x26/0x50
[  205.823866]  ? exit_to_user_mode_prepare+0x49/0x190
[  205.823873]  ? irqentry_exit_to_user_mode+0x9/0x20
[  205.823876]  ? irqentry_exit+0x33/0x40
[  205.823878]  ? exc_page_fault+0x87/0x170
[  205.823884]  ? asm_exc_page_fault+0x8/0x30
[  205.823888]  entry_SYSCALL_64_after_hwframe+0x44/0xae
[  205.823891] RIP: 0033:0x7ff6b80eaca1
[  205.823894] Code: Unable to access opcode bytes at RIP 0x7ff6b80eac77.
[  205.823896] RSP: 002b:00007fff6dfd4738 EFLAGS: 00000246 ORIG_RAX: 00000000000000e7
[  205.823899] RAX: ffffffffffffffda RBX: 00007ff6b8215a00 RCX: 00007ff6b80eaca1
[  205.823901] RDX: 000000000000003c RSI: 00000000000000e7 RDI: 0000000000000001
[  205.823903] RBP: 0000000000000001 R08: ffffffffffffff80 R09: 0000000000000028
[  205.823905] R10: 0000000000000000 R11: 0000000000000246 R12: 00007ff6b8215a00
[  205.823907] R13: 0000000000000000 R14: 00007ff6b821aee8 R15: 00007ff6b821af00
[  205.823912]  </TASK>
[  205.823913] ---[ end trace 0000000000000000 ]---
[  213.911503] NET: Unregistered PF_NETROM protocol family
[  216.051493] NET: Unregistered PF_ROSE protocol family
[  218.435464] NET: Unregistered PF_AX25 protocol family
[  254.591206] NET: Registered PF_AX25 protocol family
[  254.616523] NET: Registered PF_ROSE protocol family
[  262.939365] NET: Unregistered PF_ROSE protocol family
[  265.323355] NET: Unregistered PF_AX25 protocol family
[  275.399794] NET: Registered PF_AX25 protocol family
[  275.403834] mkiss: AX.25 Multikiss, Hans Albas PE1AYX
[  275.404600] mkiss: ax0: crc mode is auto.
[  275.404757] IPv6: ADDRCONF(NETDEV_CHANGE): ax0: link becomes ready
[  277.439314] NET: Registered PF_NETROM protocol family
[  279.545448] NET: Registered PF_ROSE protocol family
[  285.555364] mkiss: ax0: Trying crc-smack
[  285.555485] mkiss: ax0: Trying crc-flexnet
[17750.514430] kauditd_printk_skb: 16 callbacks suppressed


  reply	other threads:[~2022-07-23  9:55 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-11  1:31 [PATCH net v6] net: rose: fix null-ptr-deref caused by rose_kill_by_neigh Duoming Zhou
2022-07-12 11:00 ` Paolo Abeni
2022-07-13  7:50   ` duoming
2022-07-13  8:33     ` Paolo Abeni
2022-07-13  9:03       ` duoming
2022-07-14 14:11         ` Bernard f6bvp
2022-07-14 14:23           ` Dan Carpenter
     [not found]           ` <ab0eac7b-3041-6772-21dd-273e1b8fc43e@free.fr>
2022-07-15 22:43             ` [PATCH] net: rose: fix unregistered netdevice: waiting for rose0 to become free Jakub Kicinski
2022-07-22 16:41               ` Bernard f6bvp
2022-07-22 17:05                 ` Eric Dumazet
2022-07-23  9:55                   ` Bernard f6bvp [this message]
2022-07-23 11:21                   ` Bernard F6BVP
2022-07-26 13:44                     ` Eric Dumazet
2022-07-22 17:37                 ` Jakub Kicinski
2022-07-26 18:25                   ` [PATCH 1/1] " Bernard Pidoux
2022-07-27  9:06                     ` Eric Dumazet
2022-09-04 22:48                       ` f6bvp

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fb7544a1-f42e-9254-18cc-c9b071f4ca70@free.fr \
    --to=f6bvp@free.fr \
    --cc=davem@davemloft.net \
    --cc=duoming@zju.edu.cn \
    --cc=edumazet@google.com \
    --cc=kuba@kernel.org \
    --cc=linux-hams@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=ralf@linux-mips.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).