From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B203BC10F0E for ; Thu, 18 Apr 2019 11:43:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7B3ED2183F for ; Thu, 18 Apr 2019 11:43:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=cumulusnetworks.com header.i=@cumulusnetworks.com header.b="BiwKNgJd" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388804AbfDRLnK (ORCPT ); Thu, 18 Apr 2019 07:43:10 -0400 Received: from mail-wr1-f68.google.com ([209.85.221.68]:41121 "EHLO mail-wr1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387519AbfDRLnJ (ORCPT ); Thu, 18 Apr 2019 07:43:09 -0400 Received: by mail-wr1-f68.google.com with SMTP id r4so2570470wrq.8 for ; Thu, 18 Apr 2019 04:43:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cumulusnetworks.com; s=google; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-language:content-transfer-encoding; bh=xn/TSxA3Hpg8Jm0TZ+IfmXDIpoITD1JQVXEP7YvpISo=; b=BiwKNgJd7M07AS5sscxprW/NhiBYcJHOoWCDDctGecKOc4mWKP0n7gBzcVlYRo4AGo 3O/0nmWMjsH1LQ689p3GCBPXsRXq1DEe1JUnHrWp0FGqMyCIDVreGxr8wZ5SMRjDrlol 6P8jGHbhK802g44UWn3oJD7nYD8c/7jQ6kGgo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=xn/TSxA3Hpg8Jm0TZ+IfmXDIpoITD1JQVXEP7YvpISo=; b=K4lIWfW2uhv/HM5cbl7KGtraxBrb0NGh6KfxToArNa2zO4PySl4tcpx+nFy3QwTReI KSmo5QaA024dfz69E1uXN3omg6sb4cY+gY558id9FKl0kmFZSjbmawMI1O6yAa1bBOF+ AfnAoANTFb5G1V4eqwVofK00qG6zllj6VnupwoXxc2zcpr05oZtfdChZlhryunNQO/Qe Y39JBMw/ojArZSi5IAQqddahYm0kN7hNLqY3+EVo139sUCmn1lTb6X88DTWgDnRYHxG2 PBQzHtfhL2t1z2++fS1quExap8epTB2ANTrIjUnfFfpkkzsH+yC3WpFeCPTlohveRUwi n+XQ== X-Gm-Message-State: APjAAAU8wNbydTark693y9N9zLTHdq3mmHG9tOIGdSOvCO3G0EJkL9br oFaNc3dH6iY4tHLTvCsHv5ysAw1cc9Y= X-Google-Smtp-Source: APXvYqyKVEl1JPoP7wjZOQnPc8lic/B3SvyJna/lKs2V5VFlbWjG6d2JQ020JaDiEbMXQLJt+Fgu3A== X-Received: by 2002:adf:eb0c:: with SMTP id s12mr50530866wrn.229.1555587788016; Thu, 18 Apr 2019 04:43:08 -0700 (PDT) Received: from [192.168.51.243] ([93.152.141.58]) by smtp.gmail.com with ESMTPSA id o5sm1742375wmc.16.2019.04.18.04.43.07 (version=TLS1_3 cipher=AEAD-AES128-GCM-SHA256 bits=128/128); Thu, 18 Apr 2019 04:43:07 -0700 (PDT) Subject: Re: [PATCH net-next v2 0/5] net: support binding vlan dev link state to vlan member bridge ports To: Mike Manning , netdev@vger.kernel.org, roopa@cumulusnetworks.com References: <20190417181629.5791-1-mmanning@vyatta.att-mail.com> From: Nikolay Aleksandrov Message-ID: Date: Thu, 18 Apr 2019 14:43:06 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <20190417181629.5791-1-mmanning@vyatta.att-mail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 17/04/2019 21:16, Mike Manning wrote: > For vlan filtering on bridges, the bridge may also have vlan devices > as upper devices. For switches, these are used to provide L3 packet > processing for ports that are members of a given vlan. > > While it is correct that the admin state for these vlan devices is > either set directly for the device or inherited from the lower device, > the link state is also transferred from the lower device. So this is > always up if the bridge is in admin up state and there is at least one > bridge port that is up, regardless of the vlan that the port is in. > > The link state of the vlan device may need to track only the state of > the subset of ports that are also members of the corresponding vlan, > rather than that of all ports. > > This series provides an optional vlan flag so that the link state of > the vlan device is only up if there is at least one bridge port that is > up AND is a member of the corresponding vlan. > > > Mike Manning (5): > vlan: support binding link state to vlan member bridge ports > vlan: do not transfer link state in vlan bridge binding mode > bridge: support binding vlan dev link state to vlan member bridge > ports > bridge: update vlan dev state when port added to or deleted from vlan > bridge: update vlan dev link state for bridge netdev changes > > include/uapi/linux/if_vlan.h | 9 +- > net/8021q/vlan.c | 18 +++- > net/8021q/vlan_dev.c | 22 +++-- > net/8021q/vlan_netlink.c | 3 +- > net/bridge/br.c | 17 +++- > net/bridge/br_private.h | 14 +++ > net/bridge/br_vlan.c | 214 +++++++++++++++++++++++++++++++++++++++++++ > 7 files changed, 276 insertions(+), 21 deletions(-) > Hi Mike, Overall looks good, just one comment about patch 03. Also for v3 please include history of what changed between versions, it would make reviewing the set much easier. Thanks, Nik