From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 92307C48BE3 for ; Thu, 20 Jun 2019 20:54:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 35C0A2084E for ; Thu, 20 Jun 2019 20:54:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (4096-bit key) header.d=aplu.fr header.i=@aplu.fr header.b="puG/6pXR"; dkim=fail reason="signature verification failed" (4096-bit key) header.d=aplu.fr header.i=@aplu.fr header.b="puG/6pXR" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726797AbfFTUyF (ORCPT ); Thu, 20 Jun 2019 16:54:05 -0400 Received: from eva.aplu.fr ([91.224.149.41]:48942 "EHLO eva.aplu.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726758AbfFTUyD (ORCPT ); Thu, 20 Jun 2019 16:54:03 -0400 Received: from eva.aplu.fr (localhost [127.0.0.1]) by eva.aplu.fr (Postfix) with ESMTP id 6C0C1E23; Thu, 20 Jun 2019 22:54:01 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=aplu.fr; s=s4096; t=1561064041; bh=LtI+tPVMB4RYk2slsi4mBlOat6JXi7mCefXAD75d3Fk=; h=From:Subject:To:Cc:References:Date:In-Reply-To:From; b=puG/6pXRkzMSJohQkanknPlZH+FVI05ro5OWrlKWk2GahZM14Bd4y6W98lPUNe8m8 wSCxZANSblcOwMCjnXBLE/i0ZVILNg8RJE3EOo6JhPpVTta8rFxzBgm8II8miA6xP/ 0rOYhCJp0M8pJJ8ceYoIDMXSlKoy25Yg4diLuyHOh7CzoYq3zgm8SCcyGiVdjHlyrm dfEZGf413sGWuGG9X9EnZQMFzvFxriGXw/fngkNEp/5UiPapfOqTRM617KcNlF+rb1 fspgAtswFkJeN7umTxjpfHnMbROw0B30C/m5aEU2qKjcLm1/9gIFIB5K7P/UzYxKXJ WOaeDN4VvqpftCCgRECxkatMaVzKM3hOB3Bw/+Jv4mJ/0foNGj5Cb8fRebh1vhlC/A YGSNT52BlP+eVJZ2ouIdkzwGDHPnB2oyqvD/Pup/bszJdoSIeuwM2uOjFBE/2GAhfA nVekQwja0GZ7OlxrbO6RzeoTRn5KVAipwcdgWeEMegLf6682Mwr4PkvDlQiq4EKJaj oCOLpJ8EZP5NRmiXye5TTtbxuiVEHyiiKgEs36fku0p/Gz+KFoeag+SQtwS+MNFOhx j62ahir/NY75qfB8Vt90zNJljZVmY7yagGFXdlXVzFHzBNr6YmFUCMlGOMPKRw6GVI WKJYSFNHgzSkM3xumW96HuAU= Received: from [IPv6:2a03:7220:8081:2901::1003] (unknown [IPv6:2a03:7220:8081:2901::1003]) by eva.aplu.fr (Postfix) with ESMTPSA id D7D4DD25; Thu, 20 Jun 2019 22:54:00 +0200 (CEST) Authentication-Results: eva.aplu.fr; dmarc=fail (p=none dis=none) header.from=aplu.fr DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=aplu.fr; s=s4096; t=1561064041; bh=LtI+tPVMB4RYk2slsi4mBlOat6JXi7mCefXAD75d3Fk=; h=From:Subject:To:Cc:References:Date:In-Reply-To:From; b=puG/6pXRkzMSJohQkanknPlZH+FVI05ro5OWrlKWk2GahZM14Bd4y6W98lPUNe8m8 wSCxZANSblcOwMCjnXBLE/i0ZVILNg8RJE3EOo6JhPpVTta8rFxzBgm8II8miA6xP/ 0rOYhCJp0M8pJJ8ceYoIDMXSlKoy25Yg4diLuyHOh7CzoYq3zgm8SCcyGiVdjHlyrm dfEZGf413sGWuGG9X9EnZQMFzvFxriGXw/fngkNEp/5UiPapfOqTRM617KcNlF+rb1 fspgAtswFkJeN7umTxjpfHnMbROw0B30C/m5aEU2qKjcLm1/9gIFIB5K7P/UzYxKXJ WOaeDN4VvqpftCCgRECxkatMaVzKM3hOB3Bw/+Jv4mJ/0foNGj5Cb8fRebh1vhlC/A YGSNT52BlP+eVJZ2ouIdkzwGDHPnB2oyqvD/Pup/bszJdoSIeuwM2uOjFBE/2GAhfA nVekQwja0GZ7OlxrbO6RzeoTRn5KVAipwcdgWeEMegLf6682Mwr4PkvDlQiq4EKJaj oCOLpJ8EZP5NRmiXye5TTtbxuiVEHyiiKgEs36fku0p/Gz+KFoeag+SQtwS+MNFOhx j62ahir/NY75qfB8Vt90zNJljZVmY7yagGFXdlXVzFHzBNr6YmFUCMlGOMPKRw6GVI WKJYSFNHgzSkM3xumW96HuAU= From: Aymeric Subject: Re: network unstable on odroid-c1/meson8b. To: Heiner Kallweit Cc: netdev@vger.kernel.org, linux-amlogic@lists.infradead.org, Martin Blumenstingl References: <0df100ad-b331-43db-10a5-3257bd09938d@gmail.com> <1f34f3b6-2c70-9ff3-3f5a-597e4bd9c66f@gmail.com> Openpgp: preference=signencrypt Autocrypt: addr=mulx@aplu.fr; prefer-encrypt=mutual; keydata= mQINBFV9lJwBEACg8wMeoNKrIz/Hwd5z3kCHR8hGh0EDrodFNuNICJHU9ZiH6huCfxgFiaUn gZj/aRY0bwTEXamCk6DvY+oqjgFnMJj+uBrghC3Fsv5D8VLhGw57DvrBu8Wv8bBdqCoHnXHx 1tPsbzH4VxUuoeQ+h7vkU06kl+Q6gPYMR6lxLbjMymew1s0lnrteIO3twXFCFCIrrS+w60gR Gy/Ri963LvPnwPyHEk9iKoX5fZm533oU6It1wDKS4uuEIOqtiEO2HDj2EuPW8BFihGxTmaGc 1LdgYebndIANnpsBCVJqWH/NJucjiT6HQH1tNymbyefBW++bm2cXhE+DecWBHVKrscz1ZYrO HD8XKSnW4rfBFp9zigTuAptwxVIVHfDINpEasAJw4XAXPr5mKSJKjFkLvdAIOp9hnbJ8K1za mmdVR+Ss2C4uqmP06F2mjexyS1reTeVnb0DeXsCCdPEDOrFF4EppYT/kWIyjobVODEiUcf+V 5Bdl5185g8vTRjSJuj2RHzqdRoM6BrP2SYjdeL0OWaEn6GJnVh1KGHM2gNMtniSlYCXG1swR 3s2YNNrdA6ghmgFfcRm8pmdoeFVf6PnIL/VZmMpaWrMa3nn2pH2JE8QXyrbMrrhpKpjK1+iy MTyblpnrQQsWpUm+TmShiFWMFv8/9Kt4uJN2aVc//Gh4ZzepcQARAQABtB1BeW1lcmljIC8g QVBMVSA8bXVseEBhcGx1LmZyPokCNwQTAQgAIQIbAwIeAQIXgAUCVX2pXgULCQgHAwUVCgkI CwUWAgMBAAAKCRCtm5iFnQ7spzkcD/9/mJ+9xE5m1yeVCDKl6JPITA4hda5Dqae0RL+wUwUr 5kwoPZ4/QSJvBdHlUDyPCbwoUIxc/Adi5XzV7xI2fUMlNODOlvSiQvYEeTEtcfMYQF+3a9LA H8rYfcba0LJpWa8nT8lEBUkcQLJv91e7QfPz7BbpRH/8DBAUh8OUG7+MCGE9FushMSEpuh4Z +1XnDvZXGuvrewmlIbG+afjhu/MAS9IiiP0/SOS+BgPi/EenioOqpDcY1eNp6wAPwj3JDh2a aHfcSkMTciJO/42vvrHC6J0XcVt0mg0xZgom0oRvY8m6t4yac87mL6dFsDbzadlHqut9X5QZ aafRbexgqZ/BMdTl7qHjTmq7OjwHqoZmGBJh9Zfdt490D6e6fxXjtkPJJz+RJxmN0p+Kn3w4 Stlu/qDP3Tq8pu6DTq8/hK2sa5g1vQiY2dI3mM1B7MnPPTro+dfYy1FyJOC+kvXsIsH164V2 2f0duCobs9UJmqd2jqGAD+RiF/jhpbFk9FEUnMLtwPrnaZjBb3/vXBhK5/+oo/Nmvg+DZbyC CIyxD1wsgFwQAKyUpr3eNOR3ueEIrdHjLrj4Hd4y3z+Z0wCXSVEyD5oyKONbAtEzyyPz40xG Udj+1RqEuCSxQpBiVESfz+/BPI/TdnACKLOtMHqAnj6/ut4QLfnfLrcJvPXZ41dezbkCDQRV fZScARAAxZfd2uWFyQA15y7RFEdtKtW/7tMGWla6k5CvngA0iiCb71eg77sMTMlwZb7akBDg 6+XzcKSggRInQGOO9SL4N+sNHbBfHh7odADFzmqGjY32EFM43R31DJgPui5AQvsHD1zzF6vX JCervMwxZx4/62u/XNgVO2ZqnAqOr4qICnUREdnzdFL/azNQaFLcYjV4Aqu3F0d5djPT5dbx dqzj6/TI5GAXmd/LDCmZf9zN+z6ImSTwqr7JKzbV4a/f2e4PCsWkghXZx32QzLnL+Fm/HYRf yGUhBfK8/uagjaanY4Vl2Xz4tlthGZU1itcpN2s6cOf8DjtphfG3Ubdfut9BuE05RkngKhuH gd8CYnVzt7ggwJZbgTxjL0Galjk8kMjDJpHsBNGRinvgXdlRKw7WYybAjdYITIrZHSvurFyp lkuKDlZahcmD4ageTWNOCWjh5YXaP1yiNMMy6hHgaWVth+ieHWgiBstJD4HL1O5UOPBw+aLJ C1IIvDRMW6rMWQo224COMg5E0517CLjSnRa34Y1/5ctJpcH+wYqus9+vSySNoqYxDM7lHzmH 8FNmemHgkFxNShL5UA5vgG11B40yGNwTaKoAXNhOAcn2P94ns7UEmPu4lqayb2P1JQq+8ud/ FCWBYA2eFnyEHFJY4oFxP+o2yztPZncO7XpVmc++SGsAEQEAAYkCHwQYAQIACQUCVX2UnAIb DAAKCRCtm5iFnQ7spzwoEACK1hpkqjCt/Rz3PyK9soSR84210IgQYLCkPNa2VviA/RlLipne 1+xOke8RnsA7OqWbbAfOqxCh2jpvbxxaDg8zEZg1u4sEG9c0p5x8q9piv84kNGt3yP55SOop JfS4t1pgAPlk6lICXspNa27GQH9ugentsHpSCxeRDzG7/3bvlNJpDhZZqqOxdl9Hb8MvKgwo W/r3Tg/r44WaPIcpfA6QLgQITJoVS50xbrsby7YEUPt+uwjF8SFs/34MCQ17adHMnPmuhxRS /xGZcfis68wBIBylTswtmaSd71GTS1dgBY7KWpcoGph0B8+FyBuOUJVbnxoRVW+v1O9PAT29 r+PIgrOga5bAAd4Vr0OxtZyQQIPthkkKRS0UWz/LCzgNDp6NfG+k4Qc7PU9v02ZmkyrICyKM GF7uocuf5Cqrm6NXFSzXEalzg3HduOtA6vG3Q0iCKtxYDJijWdvxxoNeQckp8eI5bzwEaFi6 td1Vd14/6T+YxFN1z7SRYvjRJpbIoFibabIfNCY3DcVzI1eXYMqFYsyQu0IEqc4MlhYENjaP 2kioKscv60o7gyOt/LRd9nrPlY8QyZqbHA7RPFzDLvVBvcdid4HatVWeqchEgOXUp8K1MN/M GMkOdDL8YH/m2Zk/dvp+YaPcbcstXgclNzL8brWB0tGmn/Z+trwoqL/wAA== Message-ID: Date: Thu, 20 Jun 2019 22:54:00 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 MIME-Version: 1.0 In-Reply-To: <1f34f3b6-2c70-9ff3-3f5a-597e4bd9c66f@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Content-Language: fr X-AV-Checked: ClamAV using ClamSMTP Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Le 20/06/2019 à 17:53, Heiner Kallweit a écrit : > On 20.06.2019 09:55, Aymeric wrote: >> Hi, >> On 2019-06-20 00:14, Heiner Kallweit wrote: >>> On 19.06.2019 22:18, Aymeric wrote: >>>> Hello all, >>>> >>> Kernel 3.10 didn't have a dedicated RTL8211F PHY driver yet, therefore >>> I assume the genphy driver was used. Do you have a line with >>> "attached PHY driver" in dmesg output of the vendor kernel? >> No. >> Here is the full output of the dmesg from vendor kernel [¹]. >> >> I've also noticed something strange, it might be linked, but mac address of the board is set to a random value when using mainline kernel and I've to set it manually but not when using vendor kernel. >> >>> The dedicated PHY driver takes care of the tx delay, if the genphy >>> driver is used we have to rely on what uboot configured. >>> But if we indeed had an issue with a misconfigured delay, I think >>> the connection shouldn't be fine with just another link partner. >>> Just to have it tested you could make rtl8211f_config_init() in >>> drivers/net/phy/realtek.c a no-op (in current kernels). >>> >> I'm not an expert here, just adding a "return 0;" here[²] would be enough? >> >>> And you could compare at least the basic PHY registers 0x00 - 0x30 >>> with both kernel versions, e.g. with phytool. >>> >> They are not the same but I don't know what I'm looking for, so for kernel 3.10 [³] and for kernel 5.1.12 [⁴]. >> >> Aymeric >> >> [¹]: https://paste.aplu.fr/?38ef95b44ebdbfc3#G666/YbhgU+O+tdC/2HaimUCigm8ZTB44qvQip/HJ5A= >> [²]: https://github.com/torvalds/linux/blob/241e39004581475b2802cd63c111fec43bb0123e/drivers/net/phy/realtek.c#L164 >> [³]: https://paste.aplu.fr/?2dde1c32d5c68f4c#6xIa8MjTm6jpI6citEJAqFTLMMHDjFZRet/M00/EwjU= >> [⁴]: https://paste.aplu.fr/?32130e9bcb05dde7#N/xdnvb5GklcJtiOxMpTCm+9gsUliRwH8X3dcwSV+ng= >> > The vendor kernel has some, but not really much magic: > https://github.com/hardkernel/linux/blob/odroidc-3.10.y/drivers/amlogic/ethernet/phy/am_rtl8211f.c > The write to RTL8211F_PHYCR2 is overwritten later, therefore we don't have to consider it. > > The following should make the current Realtek PHY driver behave like in the vendor driver. > Could you test it? (sending again for mailing list, sorry, I forgot to force it in plaintext…) I've applied your patch and tried but it doesn't change anything. Here is dmesg output and phytool results. https://paste.aplu.fr/?9735c99907528929#SeCgwR45cgnbDA1tXIVBHCBT8RNct2r41jU6vsguLVc= -- Aymeric