From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yonghong Song Subject: Re: [PATCH bpf-next 5/7] bpf: btf: Rename btf_key_id and btf_value_id in bpf_map_info Date: Mon, 21 May 2018 14:18:29 -0700 Message-ID: References: <20180519001650.4043980-1-kafai@fb.com> <20180519001650.4043980-6-kafai@fb.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit Cc: Alexei Starovoitov , Daniel Borkmann , To: Martin KaFai Lau , Return-path: Received: from mx0a-00082601.pphosted.com ([67.231.145.42]:35482 "EHLO mx0a-00082601.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752242AbeEUVS7 (ORCPT ); Mon, 21 May 2018 17:18:59 -0400 In-Reply-To: <20180519001650.4043980-6-kafai@fb.com> Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: On 5/18/18 5:16 PM, Martin KaFai Lau wrote: > In "struct bpf_map_info", the name "btf_id", "btf_key_id" and "btf_value_id" > could cause confusion because the "id" of "btf_id" means the BPF obj id > given to the BTF object while > "btf_key_id" and "btf_value_id" means the BTF type id within > that BTF object. > > To make it clear, btf_key_id and btf_value_id are > renamed to btf_key_type_id and btf_value_type_id. > > Suggested-by: Daniel Borkmann > Signed-off-by: Martin KaFai Lau Acked-by: Yonghong Song