From: Daniel Borkmann <daniel@iogearbox.net>
To: Javier Honduvilla Coto <javierhonduco@fb.com>, netdev@vger.kernel.org
Cc: yhs@fb.com, kernel-team@fb.com
Subject: Re: [PATCH v3 bpf-next 0/3] bpf: add bpf_progenyof helper
Date: Thu, 7 Mar 2019 10:26:22 +0100 [thread overview]
Message-ID: <fc910d8a-3ad9-2626-ee38-72125c7f5b2c@iogearbox.net> (raw)
In-Reply-To: <20190305224759.2555660-1-javierhonduco@fb.com>
On 03/05/2019 11:47 PM, Javier Honduvilla Coto wrote:
> Hi all,
>
> This patch add the bpf_progenyof helper which receives a PID and returns
> 1 if the process currently being executed is in the process hierarchy,
> including itself or 0 if not.
>
> This is very useful in tracing programs when we want to filter by a
> given PID and all the children it might have. The current workarounds
> most people implement for this purpose have issues:
>
> - Attaching to process spawning syscalls and dynamically add those PIDs
> to some bpf map that would be used to filter is cumbersome and
> potentially racy.
> - Unrolling some loop to perform what this helper is doing consumes lots
> of instructions. That and the impossibility to jump backwards makes it
> really hard to be correct in really large process chains.
>
> Let me know what do you think!
>
> Thanks,
>
> ---
> Changed in V3:
> - Removed RCU read (un)locking as BPF programs alredy run in RCU locked
> context
> - progenyof(0) now returns 1, which, semantically makes more sense
> - Added new test case for PID 0 and changed sentinel value for errors
> - Rebase on latest bpf-next/master
> - Used my work email as somehow I accidentally used my personal one in v2
>
> Changed in V2:
> - Adding missing docs in include/uapi/linux/bpf.h
>
> Javier Honduvilla Coto (3):
> bpf: add bpf_progenyof helper
> bpf: sync kernel uapi headers
> bpf: add tests for bpf_progenyof
>
> include/linux/bpf.h | 1 +
> include/uapi/linux/bpf.h | 10 +-
> kernel/bpf/core.c | 1 +
> kernel/bpf/helpers.c | 32 +++
> kernel/trace/bpf_trace.c | 2 +
> tools/include/uapi/linux/bpf.h | 9 +-
> tools/testing/selftests/bpf/.gitignore | 1 +
> tools/testing/selftests/bpf/Makefile | 2 +-
> tools/testing/selftests/bpf/bpf_helpers.h | 1 +
> .../selftests/bpf/progs/test_progenyof_kern.c | 46 +++
> .../selftests/bpf/test_progenyof_user.c | 268 ++++++++++++++++++
> 11 files changed, 370 insertions(+), 3 deletions(-)
> create mode 100644 tools/testing/selftests/bpf/progs/test_progenyof_kern.c
> create mode 100644 tools/testing/selftests/bpf/test_progenyof_user.c
>
bpf-next is closed right now due to merge window, please resubmit once it
opens, thanks!
next prev parent reply other threads:[~2019-03-07 9:26 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-26 22:36 [PATCH bpf-next 0/3] bpf: add progenyof helper Javier Honduvilla Coto
2019-02-26 22:36 ` [PATCH bpf-next 1/3] bpf: add bpf_progenyof helper Javier Honduvilla Coto
2019-02-27 6:26 ` Martin Lau
2019-03-01 17:28 ` Javier Honduvilla Coto
2019-03-02 0:01 ` Martin Lau
2019-03-02 1:08 ` Javier Honduvilla Coto
2019-03-01 17:43 ` Javier Honduvilla Coto
2019-03-01 18:06 ` [PATCH v2 bpf-next 0/3] " Javier Honduvilla Coto
2019-03-01 18:06 ` [PATCH v2 bpf-next 1/3] " Javier Honduvilla Coto
2019-03-02 0:12 ` Martin Lau
2019-03-02 1:10 ` Javier Honduvilla Coto
2019-03-05 22:47 ` [PATCH v3 bpf-next 0/3] " Javier Honduvilla Coto
2019-03-05 22:47 ` [PATCH v3 bpf-next 1/3] " Javier Honduvilla Coto
2019-03-05 22:47 ` [PATCH v3 bpf-next 2/3] bpf: sync kernel uapi headers Javier Honduvilla Coto
2019-03-05 22:47 ` [PATCH v3 bpf-next 3/3] bpf: add tests for bpf_progenyof Javier Honduvilla Coto
2019-03-07 9:26 ` Daniel Borkmann [this message]
2019-03-22 22:42 ` [PATCH v3 bpf-next 0/3] bpf: add bpf_progenyof helper Javier Honduvilla Coto
2019-03-22 22:38 ` [PATCH v4 " Javier Honduvilla Coto
2019-03-22 22:38 ` [PATCH v4 bpf-next 1/3] " Javier Honduvilla Coto
2019-03-25 14:17 ` Daniel Borkmann
2019-03-27 15:57 ` Javier Honduvilla Coto
2019-03-27 20:44 ` Brendan Gregg
2019-03-27 16:02 ` Javier Honduvilla Coto
2019-03-22 22:38 ` [PATCH v4 bpf-next 2/3] bpf: sync kernel uapi headers Javier Honduvilla Coto
2019-03-22 22:38 ` [PATCH v4 bpf-next 3/3] bpf: add tests for bpf_progenyof Javier Honduvilla Coto
2019-04-10 20:36 ` [PATCH v5 bpf-next 0/3] bpf: add bpf_descendant_of helper Javier Honduvilla Coto
2019-04-10 20:36 ` [PATCH v5 bpf-next 1/3] " Javier Honduvilla Coto
2019-04-11 21:55 ` Daniel Borkmann
2019-04-12 0:20 ` Javier Honduvilla Coto
2019-04-10 20:36 ` [PATCH v5 bpf-next 2/3] bpf: sync kernel uapi headers Javier Honduvilla Coto
2019-04-10 20:36 ` [PATCH v5 bpf-next 3/3] bpf: add tests for bpf_descendant_of Javier Honduvilla Coto
2019-04-11 17:59 ` [PATCH v5 bpf-next 0/3] bpf: add bpf_descendant_of helper Song Liu
2019-07-10 18:00 ` [PATCH v6 " Javier Honduvilla Coto
2019-07-10 18:00 ` [PATCH v6 bpf-next 1/3] " Javier Honduvilla Coto
2019-07-10 18:00 ` [PATCH v6 bpf-next 2/3] bpf: sync kernel uapi headers Javier Honduvilla Coto
2019-07-10 18:00 ` [PATCH v6 bpf-next 3/3] bpf: add tests for bpf_descendant_of Javier Honduvilla Coto
2019-07-10 19:25 ` Andrii Nakryiko
2019-07-12 12:41 ` [PATCH v6 bpf-next 0/3] bpf: add bpf_descendant_of helper Daniel Borkmann
2019-03-01 18:06 ` [PATCH v2 bpf-next 2/3] bpf: sync kernel uapi headers Javier Honduvilla Coto
2019-03-01 18:06 ` [PATCH v2 bpf-next 3/3] bpf: add tests for bpf_progenyof Javier Honduvilla Coto
2019-02-26 22:36 ` [PATCH bpf-next 2/3] bpf: sync kernel uapi headers Javier Honduvilla Coto
2019-02-26 22:36 ` [PATCH bpf-next 3/3] bpf: add tests for bpf_progenyof Javier Honduvilla Coto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fc910d8a-3ad9-2626-ee38-72125c7f5b2c@iogearbox.net \
--to=daniel@iogearbox.net \
--cc=javierhonduco@fb.com \
--cc=kernel-team@fb.com \
--cc=netdev@vger.kernel.org \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).