From: Anton Ivanov <anton.ivanov@cambridgegreys.com>
To: Jakub Kicinski <kuba@kernel.org>, davem@davemloft.net
Cc: jdike@addtoit.com, richard@nod.at, linux-um@lists.infradead.org,
dledford@redhat.com, jgg@ziepe.ca, leon@kernel.org,
linux-rdma@vger.kernel.org, edumazet@google.com,
jasowang@redhat.com, mkubecek@suse.cz, hayeswang@realtek.com,
doshir@vmware.com, pv-drivers@vmware.com, manishc@marvell.com,
GR-Linux-NIC-Dev@marvell.com, gregkh@linuxfoundation.org,
merez@codeaurora.org, kvalo@codeaurora.org,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH net-next 1/7] um: reject unsupported coalescing params
Date: Fri, 6 Mar 2020 06:58:07 +0000 [thread overview]
Message-ID: <fd59e667-38cb-6b16-8a27-311c7da523d0@cambridgegreys.com> (raw)
In-Reply-To: <20200306010602.1620354-2-kuba@kernel.org>
On 06/03/2020 01:05, Jakub Kicinski wrote:
> Set ethtool_ops->supported_coalesce_params to let
> the core reject unsupported coalescing parameters.
>
> This driver did not previously reject unsupported parameters.
>
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
> ---
> arch/um/drivers/vector_kern.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/um/drivers/vector_kern.c b/arch/um/drivers/vector_kern.c
> index 0ff86391f77d..e98304d0219e 100644
> --- a/arch/um/drivers/vector_kern.c
> +++ b/arch/um/drivers/vector_kern.c
> @@ -1508,6 +1508,7 @@ static int vector_set_coalesce(struct net_device *netdev,
> }
>
> static const struct ethtool_ops vector_net_ethtool_ops = {
> + .supported_coalesce_params = ETHTOOL_COALESCE_TX_USECS,
> .get_drvinfo = vector_net_get_drvinfo,
> .get_link = ethtool_op_get_link,
> .get_ts_info = ethtool_op_get_ts_info,
>
Acked-by: Anton Ivanov <anton.ivanov@cambridgegreys.com>
--
Anton R. Ivanov
Cambridgegreys Limited. Registered in England. Company Number 10273661
https://www.cambridgegreys.com/
next prev parent reply other threads:[~2020-03-06 6:58 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-06 1:05 [PATCH net-next 0/7] ethtool: consolidate irq coalescing - other drivers Jakub Kicinski
2020-03-06 1:05 ` [PATCH net-next 1/7] um: reject unsupported coalescing params Jakub Kicinski
2020-03-06 6:58 ` Anton Ivanov [this message]
2020-03-06 1:05 ` [PATCH net-next 2/7] RDMA/ipoib: " Jakub Kicinski
2020-03-06 12:09 ` Leon Romanovsky
2020-03-06 1:05 ` [PATCH net-next 3/7] tun: " Jakub Kicinski
2020-03-06 9:33 ` Jason Wang
2020-03-06 1:05 ` [PATCH net-next 4/7] r8152: " Jakub Kicinski
2020-03-06 2:19 ` Hayes Wang
2020-03-06 1:06 ` [PATCH net-next 5/7] vmxnet3: let core reject the unsupported coalescing parameters Jakub Kicinski
2020-03-06 1:06 ` [PATCH net-next 6/7] staging: qlge: reject unsupported coalescing params Jakub Kicinski
2020-03-06 1:06 ` [PATCH net-next 7/7] wil6210: " Jakub Kicinski
2020-03-06 6:33 ` Kalle Valo
2020-03-07 6:46 ` [PATCH net-next 0/7] ethtool: consolidate irq coalescing - other drivers David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fd59e667-38cb-6b16-8a27-311c7da523d0@cambridgegreys.com \
--to=anton.ivanov@cambridgegreys.com \
--cc=GR-Linux-NIC-Dev@marvell.com \
--cc=davem@davemloft.net \
--cc=dledford@redhat.com \
--cc=doshir@vmware.com \
--cc=edumazet@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=hayeswang@realtek.com \
--cc=jasowang@redhat.com \
--cc=jdike@addtoit.com \
--cc=jgg@ziepe.ca \
--cc=kuba@kernel.org \
--cc=kvalo@codeaurora.org \
--cc=leon@kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=linux-um@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=manishc@marvell.com \
--cc=merez@codeaurora.org \
--cc=mkubecek@suse.cz \
--cc=netdev@vger.kernel.org \
--cc=pv-drivers@vmware.com \
--cc=richard@nod.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).