From: Stefan Schmidt <stefan@datenfreihafen.org>
To: Ziyang Xuan <william.xuanziyang@huawei.com>,
varkabhadram@gmail.com, alex.aring@gmail.com,
davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, linux-wpan@vger.kernel.org,
netdev@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ieee802154: cc2520: Fix error return code in cc2520_hw_init()
Date: Tue, 29 Nov 2022 15:01:01 +0100 [thread overview]
Message-ID: <fdbc3c12-71c8-16da-6b69-eb235964fcd7@datenfreihafen.org> (raw)
In-Reply-To: <20221120075046.2213633-1-william.xuanziyang@huawei.com>
Hello.
On 20.11.22 08:50, Ziyang Xuan wrote:
> In cc2520_hw_init(), if oscillator start failed, the error code
> should be returned.
>
> Fixes: 0da6bc8cc341 ("ieee802154: cc2520: adds driver for TI CC2520 radio")
> Signed-off-by: Ziyang Xuan <william.xuanziyang@huawei.com>
> ---
> drivers/net/ieee802154/cc2520.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ieee802154/cc2520.c b/drivers/net/ieee802154/cc2520.c
> index c69b87d3837d..edc769daad07 100644
> --- a/drivers/net/ieee802154/cc2520.c
> +++ b/drivers/net/ieee802154/cc2520.c
> @@ -970,7 +970,7 @@ static int cc2520_hw_init(struct cc2520_private *priv)
>
> if (timeout-- <= 0) {
> dev_err(&priv->spi->dev, "oscillator start failed!\n");
> - return ret;
> + return -ETIMEDOUT;
> }
> udelay(1);
> } while (!(status & CC2520_STATUS_XOSC32M_STABLE));
This patch has been applied to the wpan tree and will be
part of the next pull request to net. Thanks!
regards
Stefan Schmidt
prev parent reply other threads:[~2022-11-29 14:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-20 7:50 [PATCH] ieee802154: cc2520: Fix error return code in cc2520_hw_init() Ziyang Xuan
2022-11-29 14:01 ` Stefan Schmidt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fdbc3c12-71c8-16da-6b69-eb235964fcd7@datenfreihafen.org \
--to=stefan@datenfreihafen.org \
--cc=alex.aring@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wpan@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=varkabhadram@gmail.com \
--cc=william.xuanziyang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).