From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.5 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B7133C433DB for ; Wed, 6 Jan 2021 06:07:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 76BB922D75 for ; Wed, 6 Jan 2021 06:07:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726370AbhAFGHl (ORCPT ); Wed, 6 Jan 2021 01:07:41 -0500 Received: from szxga05-in.huawei.com ([45.249.212.191]:10025 "EHLO szxga05-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725813AbhAFGHk (ORCPT ); Wed, 6 Jan 2021 01:07:40 -0500 Received: from DGGEMS408-HUB.china.huawei.com (unknown [172.30.72.58]) by szxga05-in.huawei.com (SkyGuard) with ESMTP id 4D9f4W0xZlzj4K4; Wed, 6 Jan 2021 14:06:03 +0800 (CST) Received: from [10.174.177.149] (10.174.177.149) by DGGEMS408-HUB.china.huawei.com (10.3.19.208) with Microsoft SMTP Server id 14.3.498.0; Wed, 6 Jan 2021 14:06:49 +0800 Subject: Re: [PATCH v2] net: qrtr: fix null pointer dereference in qrtr_ns_remove To: Markus Elfring , CC: , , , "David S. Miller" , Jakub Kicinski References: <20210105055754.16486-1-miaoqinglang@huawei.com> <4596fb37-5e74-5bf6-60e5-ded6fbb83969@web.de> From: Qinglang Miao Message-ID: Date: Wed, 6 Jan 2021 14:06:48 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <4596fb37-5e74-5bf6-60e5-ded6fbb83969@web.de> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.174.177.149] X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Hi Markus, I'd like to take some of your advice in this patch, but I noticed that this one has been applied. Some of your advice would be considered kindly on my future work. Thanks. 在 2021/1/5 21:14, Markus Elfring 写道: >> A null-ptr-deref bug is reported by Hulk Robot like this: > > Can it be clearer to use the term “null pointer dereference” for the final commit message? This advice is too detailed for 'null-ptr-deref' is known as a general phrase like 'use-after-free' for kernel developer, I think.> > >> -------------- > > I suggest to choose an other character for drawing such a text line. It's an acceptable advice, thanks. > > >> Fix it by making … > > Would you like to replace this wording by the tag “Fixes”? Sorry, I didn't get your words. 'Fix it by' follows the solution 'Fixes' follows the commit which brought the problem. In fact, I do considered using 'Fixes' on this one, but it's hard to tell which specific commit brought this null pointer dereference. > > Will an other imperative wording variant be helpful for this change description? > > > … >> +++ b/net/qrtr/qrtr.c >> @@ -1287,13 +1287,19 @@ static int __init qrtr_proto_init(void) > … >> +err_sock: >> + sock_unregister(qrtr_family.family); >> +err_proto: >> + proto_unregister(&qrtr_proto); >> return rc; >> } > > Would it be clearer to use the labels “unregister_sock” and “unregister_proto”? In fact, The reason I use 'err_sock' rather than 'unregister_sock' is to keep same in 'net/qrtr/ns.c'. I agree with you that “unregister_sock” is better in normal case. > > Regards, > Markus > . >