From: Casey Schaufler <casey@schaufler-ca.com>
To: Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp>,
David Ahern <dsahern@gmail.com>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: commit b9ef5513c99b breaks ping to ipv6 linklocal addresses on debian buster
Date: Mon, 6 Jan 2020 13:33:01 -0800 [thread overview]
Message-ID: <fe05d86a-24a2-90a4-3a7e-bfd1a7c1df72@schaufler-ca.com> (raw)
In-Reply-To: <153de016-8274-5d62-83fe-ce7d8218f906@i-love.sakura.ne.jp>
On 1/6/2020 1:03 PM, Tetsuo Handa wrote:
> On 2020/01/07 1:41, David Ahern wrote:
>>>> #ifdef SMACK_IPV6_SECMARK_LABELING
>>>> rsp = smack_ipv6host_label(sip);
>>>>
>>>>
>>>> ie., if the socket family is AF_INET6 the address length should be an
>>>> IPv6 address. The family in the sockaddr is not as important.
>>>>
>>> Commit b9ef5513c99b was wrong, but we need to also fix commit c673944347ed ?
>>>
>> not sure. I have not seen a problem related to it yet.
>>
> A sample program shown below is expected to return 0.
> Casey, what does smack wants to do for IPv4 address on IPv6 socket case?
I have to take a minute to look more closely at what's involved.
>
> ----------
> #include <sys/types.h>
> #include <sys/socket.h>
> #include <sys/un.h>
> #include <arpa/inet.h>
> #include <unistd.h>
>
> int main(int argc, char *argv[])
> {
> const int fd1 = socket(PF_INET6, SOCK_DGRAM, 0);
> const int fd2 = socket(PF_INET, SOCK_DGRAM, 0);
> struct sockaddr_in addr1 = {
> .sin_family = AF_INET,
> .sin_addr.s_addr = htonl(INADDR_LOOPBACK),
> .sin_port = htons(10000)
> };
> struct sockaddr_in addr2 = { };
> char c = 0;
> struct iovec iov1 = { "", 1 };
> struct iovec iov2 = { &c, 1 };
> const struct msghdr msg1 = {
> .msg_iov = &iov1,
> .msg_iovlen = 1,
> .msg_name = &addr1,
> .msg_namelen = sizeof(addr1)
> };
> struct msghdr msg2 = {
> .msg_iov = &iov2,
> .msg_iovlen = 1,
> .msg_name = &addr2,
> .msg_namelen = sizeof(addr2)
> };
> if (bind(fd2, (struct sockaddr *) &addr1, sizeof(addr1)))
> return 1;
> if (sendmsg(fd1, &msg1, 0) != 1 || recvmsg(fd2, &msg2, 0) != 1)
> return 1;
> if (connect(fd1, (struct sockaddr *) &addr1, sizeof(addr1)))
> return 1;
> if (send(fd1, "", 1, 0) != 1 || recv(fd2, &c, 1, 0) != 1)
> return 1;
> return 0;
> }
> ----------
next prev parent reply other threads:[~2020-01-06 21:33 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-06 1:26 commit b9ef5513c99b breaks ping to ipv6 linklocal addresses on debian buster David Ahern
2020-01-06 3:51 ` Tetsuo Handa
2020-01-06 4:20 ` David Ahern
2020-01-06 11:04 ` Tetsuo Handa
2020-01-06 16:41 ` David Ahern
2020-01-06 21:03 ` Tetsuo Handa
2020-01-06 21:33 ` Casey Schaufler [this message]
2020-01-07 18:05 ` Casey Schaufler
2020-01-07 18:40 ` Casey Schaufler
2020-01-07 18:44 ` David Ahern
2020-01-08 2:41 ` David Ahern
2020-01-08 23:06 ` Casey Schaufler
[not found] ` <CAPA1RqAqBZNeN=T_FpApLo_-oZXeFctgGHcggY6xAXV+qHYcKg@mail.gmail.com>
2020-01-09 3:39 ` David Ahern
2020-01-09 4:06 ` David Ahern
2020-01-09 9:50 ` Tetsuo Handa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fe05d86a-24a2-90a4-3a7e-bfd1a7c1df72@schaufler-ca.com \
--to=casey@schaufler-ca.com \
--cc=dsahern@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=penguin-kernel@i-love.sakura.ne.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).