From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C8796CA9ED1 for ; Fri, 1 Nov 2019 12:10:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9F74B217F9 for ; Fri, 1 Nov 2019 12:10:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727528AbfKAMKU (ORCPT ); Fri, 1 Nov 2019 08:10:20 -0400 Received: from www62.your-server.de ([213.133.104.62]:34942 "EHLO www62.your-server.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726783AbfKAMKU (ORCPT ); Fri, 1 Nov 2019 08:10:20 -0400 Received: from sslproxy06.your-server.de ([78.46.172.3]) by www62.your-server.de with esmtpsa (TLSv1.2:DHE-RSA-AES256-GCM-SHA384:256) (Exim 4.89_1) (envelope-from ) id 1iQVks-00044S-Ce; Fri, 01 Nov 2019 13:10:14 +0100 Received: from [178.197.249.38] (helo=pc-63.home) by sslproxy06.your-server.de with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.89) (envelope-from ) id 1iQVks-000Cts-2z; Fri, 01 Nov 2019 13:10:14 +0100 Subject: Re: [PATCH net 0/3] fix BPF offload related bugs To: Jakub Kicinski , davem@davemloft.net Cc: alexei.starovoitov@gmail.com, bpf@vger.kernel.org, netdev@vger.kernel.org, oss-drivers@netronome.com References: <20191101030700.13080-1-jakub.kicinski@netronome.com> From: Daniel Borkmann Message-ID: Date: Fri, 1 Nov 2019 13:10:13 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.2 MIME-Version: 1.0 In-Reply-To: <20191101030700.13080-1-jakub.kicinski@netronome.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Authenticated-Sender: daniel@iogearbox.net X-Virus-Scanned: Clear (ClamAV 0.101.4/25620/Fri Nov 1 10:04:15 2019) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 11/1/19 4:06 AM, Jakub Kicinski wrote: > Hi! > > test_offload.py catches some recently added bugs. > > First of a bug in test_offload.py itself after recent changes > to netdevsim is fixed. > > Second patch fixes a bug in cls_bpf, and last one addresses > a problem with the recently added XDP installation optimization. > > Jakub Kicinski (3): > selftests: bpf: Skip write only files in debugfs > net: cls_bpf: fix NULL deref on offload filter removal > net: fix installing orphaned programs > > net/core/dev.c | 3 ++- > net/sched/cls_bpf.c | 8 ++++++-- > tools/testing/selftests/bpf/test_offload.py | 5 +++++ > 3 files changed, 13 insertions(+), 3 deletions(-) Should this go via -bpf or -net? Either way is fine, but asking given it's BPF related fixes; planning to do a PR in the evening, set looks good to me in any case. Thanks, Daniel