From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BA842C2D0E4 for ; Fri, 20 Nov 2020 23:53:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 736122222A for ; Fri, 20 Nov 2020 23:53:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728505AbgKTXwU (ORCPT ); Fri, 20 Nov 2020 18:52:20 -0500 Received: from static-71-183-126-102.nycmny.fios.verizon.net ([71.183.126.102]:58288 "EHLO chicken.badula.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726426AbgKTXwT (ORCPT ); Fri, 20 Nov 2020 18:52:19 -0500 X-Greylist: delayed 594 seconds by postgrey-1.27 at vger.kernel.org; Fri, 20 Nov 2020 18:52:19 EST Received: from chicken.badula.org (localhost [127.0.0.1]) by chicken.badula.org (8.14.4/8.14.4) with ESMTP id 0AKNgIfo024926 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Fri, 20 Nov 2020 18:42:24 -0500 Received: (from defang@localhost) by chicken.badula.org (8.14.4/8.14.4/Submit) id 0AKNf4Pt024904; Fri, 20 Nov 2020 18:41:04 -0500 X-Authentication-Warning: chicken.badula.org: defang set sender to using -f Received: from moisil.badula.org (pool-71-187-225-100.nwrknj.fios.verizon.net [71.187.225.100]) by chicken.badula.org (envelope-sender ) (MIMEDefang) with ESMTP id 0AKNf3lq024894; Fri, 20 Nov 2020 18:41:04 -0500 Subject: Re: [PATCH] net: adaptec: remove dead code in set_vlan_mode To: Jakub Kicinski , xiakaixu1987@gmail.com Cc: leon@kernel.org, davem@davemloft.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Kaixu Xia , Arnd Bergmann References: <1605858600-7096-1-git-send-email-kaixuxia@tencent.com> <20201120151714.0cc2f00b@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> From: Ion Badulescu Message-ID: Date: Fri, 20 Nov 2020 18:41:03 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <20201120151714.0cc2f00b@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.84 on 71.183.126.100 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 11/20/20 6:17 PM, Jakub Kicinski wrote: > On Fri, 20 Nov 2020 15:50:00 +0800 xiakaixu1987@gmail.com wrote: >> From: Kaixu Xia >> >> The body of the if statement can be executed only when the variable >> vlan_count equals to 32, so the condition of the while statement can >> not be true and the while statement is dead code. Remove it. >> >> Reported-by: Tosk Robot >> Signed-off-by: Kaixu Xia >> --- >> drivers/net/ethernet/adaptec/starfire.c | 9 ++------- >> 1 file changed, 2 insertions(+), 7 deletions(-) >> >> diff --git a/drivers/net/ethernet/adaptec/starfire.c b/drivers/net/ethernet/adaptec/starfire.c >> index 555299737b51..ad27a9fa5e95 100644 >> --- a/drivers/net/ethernet/adaptec/starfire.c >> +++ b/drivers/net/ethernet/adaptec/starfire.c >> @@ -1754,14 +1754,9 @@ static u32 set_vlan_mode(struct netdev_private *np) >> filter_addr += 16; >> vlan_count++; >> } >> - if (vlan_count == 32) { >> + if (vlan_count == 32) >> ret |= PerfectFilterVlan; >> - while (vlan_count < 32) { >> - writew(0, filter_addr); >> - filter_addr += 16; >> - vlan_count++; >> - } >> - } >> + >> return ret; >> } >> #endif /* VLAN_SUPPORT */ > > This got broken back in 2011: > > commit 5da96be53a16a62488316810d0c7c5d58ce3ee4f > Author: Jiri Pirko > Date: Wed Jul 20 04:54:31 2011 +0000 > > starfire: do vlan cleanup > > - unify vlan and nonvlan rx path > - kill np->vlgrp and netdev_vlan_rx_register > > Signed-off-by: Jiri Pirko > Signed-off-by: David S. Miller > > The comparison to 32 was on a different variable before that change. > > Ion, do you think anyone is still using this driver? > > Maybe it's time we put it in the history book (by which I mean remove > from the kernel). Frankly, no, I don't know of any users, and that unfortunately includes myself. I still have two cards in my stash, but they're 64-bit PCI-X, so plugging them in would likely require taking a dremel to a 32-bit PCI slot to make it open-ended. (They do work in a 32-bit slot.) Anyway, that filter code could use some fixing in other regards. So either we fix it properly (which I can submit a patch for), or clean it out for good. -Ion