Re: [PATCH wpan-next v2 0/2] IEEE 802.15.4 PAN discovery handling

From: Stefan Schmidt <stefan@datenfreihafen.org>
To: Miquel Raynal <miquel.raynal@bootlin.com>,
	Alexander Aring <aahringo@redhat.com>
Cc: Alexander Aring <alex.aring@gmail.com>,
	linux-wpan@vger.kernel.org,
	"David S. Miller" <davem@davemloft.net>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Eric Dumazet <edumazet@google.com>,
	netdev@vger.kernel.org, David Girault <david.girault@qorvo.com>,
	Romuald Despres <romuald.despres@qorvo.com>,
	Frederic Blain <frederic.blain@qorvo.com>,
	Nicolas Schodet <nico@ni.fr.eu.org>,
	Guilhem Imberton <guilhem.imberton@qorvo.com>,
	Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Subject: Re: [PATCH wpan-next v2 0/2] IEEE 802.15.4 PAN discovery handling
Date: Tue, 29 Nov 2022 13:41:32 +0100	[thread overview]
Message-ID: <ff0e20e9-687c-75f7-12ea-c927df39a1db@datenfreihafen.org> (raw)
In-Reply-To: <20221129090321.132a4439@xps-13>

Hello.

On 29.11.22 09:03, Miquel Raynal wrote:
> Hi Alexander,
> 
> aahringo@redhat.com wrote on Mon, 28 Nov 2022 17:11:38 -0500:
> 
>> Hi,
>>
>> On Fri, Nov 18, 2022 at 5:13 PM Miquel Raynal <miquel.raynal@bootlin.com> wrote:
>>>
>>> Hello,
>>>
>>> Last preparation step before the introduction of the scanning feature
>>> (really): generic helpers to handle PAN discovery upon beacon
>>> reception. We need to tell user space about the discoveries.
>>>
>>> In all the past, current and future submissions, David and Romuald from
>>> Qorvo are credited in various ways (main author, co-author,
>>> suggested-by) depending of the amount of rework that was involved on
>>> each patch, reflecting as much as possible the open-source guidelines we
>>> follow in the kernel. All this effort is made possible thanks to Qorvo
>>> Inc which is pushing towards a featureful upstream WPAN support.
>>>   
>>
>> Acked-by: Alexander Aring <aahringo@redhat.com>
>>
>> I am sorry, I saw this series today. Somehow I mess up my mails if we
>> are still writing something on v1 but v2 is already submitted. I will
>> try to keep up next time.
> 
> Haha I was asking myself wether or not you saw it, no problem :) I did
> send it after your main review but we continued discussing on v1 (about
> the preambles) so I did not ping for the time the discussion would
> settle.

I was trying to apply these two patches, but the first one does not apply:

Failed to apply patch:
error: patch failed: include/net/nl802154.h:58
error: include/net/nl802154.h: patch does not apply
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Applying: ieee802154: Advertize coordinators discovery
Patch failed at 0001 ieee802154: Advertize coordinators discovery

It seems you need a rebase as there is commit 
8254393663f9b8cb8b84cdce1abb118833c22a54 which touches this area of the 
file and removes a comment and ifdef. Should be fine to go in after the 
rebase.

regards
Stefan Schmidt