From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CF3A8C10F00 for ; Tue, 19 Feb 2019 12:52:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A8384204EC for ; Tue, 19 Feb 2019 12:52:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728566AbfBSMwV (ORCPT ); Tue, 19 Feb 2019 07:52:21 -0500 Received: from szxga05-in.huawei.com ([45.249.212.191]:4224 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726221AbfBSMwU (ORCPT ); Tue, 19 Feb 2019 07:52:20 -0500 Received: from DGGEMS414-HUB.china.huawei.com (unknown [172.30.72.59]) by Forcepoint Email with ESMTP id E482B4785A1AF6D97E12; Tue, 19 Feb 2019 20:52:17 +0800 (CST) Received: from [127.0.0.1] (10.177.96.96) by DGGEMS414-HUB.china.huawei.com (10.3.19.214) with Microsoft SMTP Server id 14.3.408.0; Tue, 19 Feb 2019 20:52:14 +0800 Subject: Re: [PATCH v3] net: ns83820: code cleanup for ns83820_probe_phy() To: Walter Harms References: <715767253.151509.1550580124264@ox-groupware.bfs.de> CC: , , , , , , , From: maowenan Message-ID: Date: Tue, 19 Feb 2019 20:52:00 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <715767253.151509.1550580124264@ox-groupware.bfs.de> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.177.96.96] X-CFilter-Loop: Reflected Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 2019/2/19 20:42, Walter Harms wrote: > > Am 19.02.2019 10:06, schrieb Mao Wenan: >> This patch is to do code cleanup for ns83820_probe_phy(). >> It deletes unused variable 'first' and commented out code. >> >> Signed-off-by: Mao Wenan >> --- >> v2->v3: delte unused variable 'first'; change subject from >> "net: ns83820: drop pointless static qualifier in ns83820_probe_phy()" to >> "net: ns83820: code cleanup for ns83820_probe_phy()". >> drivers/net/ethernet/natsemi/ns83820.c | 18 ------------------ >> 1 file changed, 18 deletions(-) >> >> diff --git a/drivers/net/ethernet/natsemi/ns83820.c >> b/drivers/net/ethernet/natsemi/ns83820.c >> index 958fced4dacf..955d34a6f0d8 100644 >> --- a/drivers/net/ethernet/natsemi/ns83820.c >> +++ b/drivers/net/ethernet/natsemi/ns83820.c >> @@ -1869,34 +1869,16 @@ static unsigned ns83820_mii_write_reg(struct ns83820 >> *dev, unsigned phy, unsigne >> static void ns83820_probe_phy(struct net_device *ndev) >> { >> struct ns83820 *dev = PRIV(ndev); >> - static int first; >> int i; >> #define MII_PHYIDR1 0x02 >> #define MII_PHYIDR2 0x03 >> >> -#if 0 >> - if (!first) { >> - unsigned tmp; >> - ns83820_mii_read_reg(dev, 1, 0x09); >> - ns83820_mii_write_reg(dev, 1, 0x10, 0x0d3e); >> - >> - tmp = ns83820_mii_read_reg(dev, 1, 0x00); >> - ns83820_mii_write_reg(dev, 1, 0x00, tmp | 0x8000); >> - udelay(1300); >> - ns83820_mii_read_reg(dev, 1, 0x09); >> - } >> -#endif >> - first = 1; >> - >> for (i=1; i<2; i++) { > > > the loop here seems also pointless, so you can eliminate i. > (or did i muss something ?) > good point.Thank you. > just my 2 cents, > re, > wh >> int j; >> unsigned a, b; >> a = ns83820_mii_read_reg(dev, i, MII_PHYIDR1); >> b = ns83820_mii_read_reg(dev, i, MII_PHYIDR2); >> >> - //printk("%s: phy %d: 0x%04x 0x%04x\n", >> - // ndev->name, i, a, b); >> - >> for (j=0; j<0x16; j+=4) { >> dprintk("%s: [0x%02x] %04x %04x %04x %04x\n", >> ndev->name, j, > > . >