From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f52.google.com (mail-wr1-f52.google.com [209.85.221.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 87C0F56455 for ; Fri, 29 Mar 2024 15:52:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711727564; cv=none; b=isZTAuxOvjivuPPCxoe/aO2aN09XYbgE/2p/H+QaWfwZPGtJCyGofqV/VIizd5P4TpuS/cAov6xIaSkNdgxjaVBQfSNLgG6HTovI2UVcG7np5xg+0JKXtv3aKpycxr2WccBj8qe5HSJWO2nKw2HhGohN0XGQ+P9Be0Osjw1g4Aw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711727564; c=relaxed/simple; bh=93fcRAx8zC3XL/YYOz1/itnqEkVWFV9/HC+YNw2rLV4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=hTA9ISzbHK6UTj4VjW2uqQS4fgV/bxZ7/dU3pW1cot3y47OYX2/BQP7Ym3lZSWvt4ZU7VCbn/Bw1sKIRzMl9B0cNtxfu3aZ1hD+m+jLuetZtRwHan5vHgge6iJJt7MoscdFyHLJrTc7CTMIV5OCVFlUwHaSKa80s8GxUNVdmzPw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=a+ddMKtd; arc=none smtp.client-ip=209.85.221.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="a+ddMKtd" Received: by mail-wr1-f52.google.com with SMTP id ffacd0b85a97d-33ddd1624beso1295022f8f.1 for ; Fri, 29 Mar 2024 08:52:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1711727561; x=1712332361; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=DaRSKMpGgSpfDNUtqSIdr/VVtF3x8hhIBInqqXBE7qE=; b=a+ddMKtd+ox2Hv1p/kZINSH9QdrIExGhL1BaCoVO93wGXXUhFyqFidJVBEM8ZiQTIl KY7PSq/HDa9QjQ3eRlyMcEwUJRwsQmCeMc4Od+fZQARASHs5dmHxk2DJWXJ+tQbWheZ0 F56Xa0FaOw2+ozwW6shl8tDWOnXVvExZQ7N6P1GcmVRH1cw0KN/jJ6Rm9XWiSTUHza0f Kk/UxR80sC5WHcE4UXWh2CbwoTIx8/Kz2FglZSNzldPeqvigU1vzh+sePQW50bAmT1PG 6A7AH19VYwyHthVL09pz53+fMVsEWsKL/F6JHqy3lcqjP7tzY91BJSDWmcLQ3NS7N7VT dDOg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711727561; x=1712332361; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=DaRSKMpGgSpfDNUtqSIdr/VVtF3x8hhIBInqqXBE7qE=; b=fWNBlQu90/t/8ApshJpSK9jwnTS8sbY5hteQ/gIc0MSZHZaBSEr/EOhrBhNdYRd5B5 oJyocdCDwgV5gYO4XZUJVP1G6X5QoEwW8+FRuK3XepHnUodkkR8gTrd1nBuxJW7wYdLR imSSv5AwCHoGGN4d6pMKUsrAwaHznbyWxbF043C3bGq076VFnzZriV77EzaODehVO1uv XXIWeM28kYWfnwZusI6tyzdoNwv5op2da1EBDxYbfi9kdsnqAihEmAA3Vw8xRR5g1W6D mRpSljY2Db7X9bvP7RUmNPjXV/6T+gXgKuNixCg6VIPCxXpuHSV6xMnyUckNLwnpHnOR fjpA== X-Forwarded-Encrypted: i=1; AJvYcCWNe8Qu67kfoPtQjrLeud4DJjuXT4Kfh7qr03ms0dARGKgNa0ug8T2KPVkJB+W8OMG8vGerNVJzjA84qH9tt5LFYZAI2iPt X-Gm-Message-State: AOJu0Yy1NppWYTq3iWSy6MMs9oZ0J2dfJqmbTdz3Bf852NIYEVNvtKsg HJVswOAiiBMymGOcapcPebLit5/ffcRtyqjSTtwN8BSgs9W+qgb78WcBfTjzdkE= X-Google-Smtp-Source: AGHT+IGY7HPkzppphxXgM5h0At1hNgR5lKzpQA9yXBKEUqn+LOFbx8z+oJtbHZZ1I/5C6bO8uk34HQ== X-Received: by 2002:a5d:64a2:0:b0:33e:cbec:e98 with SMTP id m2-20020a5d64a2000000b0033ecbec0e98mr5944277wrp.13.1711727560893; Fri, 29 Mar 2024 08:52:40 -0700 (PDT) Received: from u94a ([2401:e180:8d50:7df:53a:80ac:6d18:d24c]) by smtp.gmail.com with ESMTPSA id m3-20020a170902f20300b001e0d6de7198sm3615107plc.283.2024.03.29.08.52.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 29 Mar 2024 08:52:40 -0700 (PDT) Date: Fri, 29 Mar 2024 23:52:31 +0800 From: Shung-Hsi Yu To: Jakub Sitnicki Cc: Alexei Starovoitov , Edward Adam Davis , John Fastabend , syzbot+c4f4d25859c2e5859988@syzkaller.appspotmail.com, 42.hyeyoo@gmail.com, andrii@kernel.org, ast@kernel.org, bpf@vger.kernel.org, daniel@iogearbox.net, davem@davemloft.net, edumazet@google.com, kafai@fb.com, kpsingh@kernel.org, kuba@kernel.org, linux-kernel@vger.kernel.org, namhyung@kernel.org, netdev@vger.kernel.org, pabeni@redhat.com, peterz@infradead.org, songliubraving@fb.com, syzkaller-bugs@googlegroups.com, yhs@fb.com, Xin Liu Subject: Re: [PATCH] bpf, sockmap: fix deadlock in rcu_report_exp_cpu_mult Message-ID: References: <000000000000dc9aca0613ec855c@google.com> <87y1a6biie.fsf@cloudflare.com> <87plvgbp15.fsf@cloudflare.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87plvgbp15.fsf@cloudflare.com> On Tue, Mar 26, 2024 at 11:15:47PM +0100, Jakub Sitnicki wrote: > On Mon, Mar 25, 2024 at 01:23 PM +01, Jakub Sitnicki wrote: > > On Sat, Mar 23, 2024 at 12:08 AM -07, Alexei Starovoitov wrote: > >> It seems this bug was causing multiple syzbot reports. > > Any chance we could disallow mutating sockhash from interrupt context? > > I've been playing with the repro from one of the other reports: > > https://lore.kernel.org/all/CABOYnLzaRiZ+M1v7dPaeObnj_=S4JYmWbgrXaYsyBbWh=553vQ@mail.gmail.com/ Possibly also related: - "A potential deadlock in sockhash map"[1] report awhile back - commit ed17aa92dc56b ("bpf, sockmap: fix deadlocks in the sockhash and sockmap") - commit 8c5c2a4898e3d ("bpf, sockmap: Revert buggy deadlock fix in the sockhash and sockmap") 1: https://lore.kernel.org/all/CABcoxUayum5oOqFMMqAeWuS8+EzojquSOSyDA3J_2omY=2EeAg@mail.gmail.com/