From: Shay Agroskin <shayagr@amazon.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: <akiyano@amazon.com>, <davem@davemloft.net>,
<netdev@vger.kernel.org>, <dwmw@amazon.com>, <zorik@amazon.com>,
<matua@amazon.com>, <saeedb@amazon.com>, <msw@amazon.com>,
<aliguori@amazon.com>, <nafea@amazon.com>, <gtzalik@amazon.com>,
<netanel@amazon.com>, <alisaidi@amazon.com>, <benh@amazon.com>,
<ndagan@amazon.com>, <sameehj@amazon.com>
Subject: Re: [PATCH V4 net-next 7/9] net: ena: introduce XDP redirect implementation
Date: Mon, 7 Dec 2020 21:18:15 +0200 [thread overview]
Message-ID: <pj41zl360hzaq0.fsf@u68c7b5b1d2d758.ant.amazon.com> (raw)
In-Reply-To: <20201205161559.3c817842@kicinski-fedora-pc1c0hjn.DHCP.thefacebook.com>
Jakub Kicinski <kuba@kernel.org> writes:
> On Fri, 4 Dec 2020 14:11:13 +0200 akiyano@amazon.com wrote:
>> + case XDP_REDIRECT:
>> + xdp_do_redirect(rx_ring->netdev, xdp, xdp_prog);
>> + xdp_stat = &rx_ring->rx_stats.xdp_redirect;
>> + break;
>
> Don't you have to check if xdp_do_redirect() returned an error
> or not?
>
> You should CC XDP maintainers on the XDP patches.
Thanks for reviewing the code (:
I'll add a return value check next patchset and CC XDP
maintainers.
next prev parent reply other threads:[~2020-12-07 19:19 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-04 12:11 [PATCH V4 net-next 0/9] XDP Redirect implementation for ENA driver akiyano
2020-12-04 12:11 ` [PATCH V4 net-next 1/9] net: ena: use constant value for net_device allocation akiyano
2020-12-04 12:11 ` [PATCH V4 net-next 2/9] net: ena: add device distinct log prefix to files akiyano
2020-12-04 12:11 ` [PATCH V4 net-next 3/9] net: ena: add explicit casting to variables akiyano
2020-12-07 19:00 ` Alexander Duyck
2020-12-07 20:19 ` Shay Agroskin
2020-12-08 18:11 ` Shay Agroskin
2020-12-04 12:11 ` [PATCH V4 net-next 4/9] net: ena: fix coding style nits akiyano
2020-12-04 12:11 ` [PATCH V4 net-next 5/9] net: ena: aggregate stats increase into a function akiyano
2020-12-04 12:11 ` [PATCH V4 net-next 6/9] net: ena: use xdp_frame in XDP TX flow akiyano
2020-12-06 20:10 ` Maciej Fijalkowski
2020-12-07 19:16 ` Shay Agroskin
2020-12-04 12:11 ` [PATCH V4 net-next 7/9] net: ena: introduce XDP redirect implementation akiyano
2020-12-06 0:15 ` Jakub Kicinski
2020-12-07 19:18 ` Shay Agroskin [this message]
2020-12-04 12:11 ` [PATCH V4 net-next 8/9] net: ena: use xdp_return_frame() to free xdp frames akiyano
2020-12-04 12:11 ` [PATCH V4 net-next 9/9] net: ena: introduce ndo_xdp_xmit() function for XDP_REDIRECT akiyano
2020-12-06 20:22 ` Maciej Fijalkowski
2020-12-07 19:28 ` Shay Agroskin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=pj41zl360hzaq0.fsf@u68c7b5b1d2d758.ant.amazon.com \
--to=shayagr@amazon.com \
--cc=akiyano@amazon.com \
--cc=aliguori@amazon.com \
--cc=alisaidi@amazon.com \
--cc=benh@amazon.com \
--cc=davem@davemloft.net \
--cc=dwmw@amazon.com \
--cc=gtzalik@amazon.com \
--cc=kuba@kernel.org \
--cc=matua@amazon.com \
--cc=msw@amazon.com \
--cc=nafea@amazon.com \
--cc=ndagan@amazon.com \
--cc=netanel@amazon.com \
--cc=netdev@vger.kernel.org \
--cc=saeedb@amazon.com \
--cc=sameehj@amazon.com \
--cc=zorik@amazon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).