From: Shay Agroskin <shayagr@amazon.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: <netdev@vger.kernel.org>, <dwmw@amazon.com>, <zorik@amazon.com>,
<matua@amazon.com>, <saeedb@amazon.com>, <msw@amazon.com>,
<aliguori@amazon.com>, <nafea@amazon.com>, <gtzalik@amazon.com>,
<netanel@amazon.com>, <alisaidi@amazon.com>, <benh@amazon.com>,
<akiyano@amazon.com>, <sameehj@amazon.com>, <ndagan@amazon.com>
Subject: Re: [PATCH V2 net 4/4] net: ena: return error code from ena_xdp_xmit_buff
Date: Sun, 22 Nov 2020 09:19:05 +0200 [thread overview]
Message-ID: <pj41zl7dqddfkm.fsf@u68c7b5b1d2d758.ant.amazon.com> (raw)
In-Reply-To: <20201121155304.1751d0c6@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Jakub Kicinski <kuba@kernel.org> writes:
> On Thu, 19 Nov 2020 22:28:51 +0200 Shay Agroskin wrote:
>> The function mistakenly returns NETDEV_TX_OK regardless of the
>> transmission success. This patch fixes this behavior by
>> returning the
>> error code from the function.
>>
>> Fixes: 548c4940b9f1 ("net: ena: Implement XDP_TX action")
>> Signed-off-by: Shay Agroskin <shayagr@amazon.com>
>
> Doesn't seem like a legitimate bug fix, since the only caller of
> this
> function ignores its return value.
Hi,
I plan to use the return value from this function in future patch
(next-net series), do you think we better send this fix with
this future patch?
Shay
next prev parent reply other threads:[~2020-11-22 7:20 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-19 20:28 [PATCH V2 net 0/4] Fixes for ENA driver Shay Agroskin
2020-11-19 20:28 ` [PATCH V2 net 1/4] net: ena: handle bad request id in ena_netdev Shay Agroskin
2020-11-19 20:28 ` [PATCH V2 net 2/4] net: ena: set initial DMA width to avoid intel iommu issue Shay Agroskin
2020-11-19 20:28 ` [PATCH V2 net 3/4] net: ena: fix packet's addresses for rx_offset feature Shay Agroskin
2020-11-19 20:28 ` [PATCH V2 net 4/4] net: ena: return error code from ena_xdp_xmit_buff Shay Agroskin
2020-11-21 23:53 ` Jakub Kicinski
2020-11-22 7:19 ` Shay Agroskin [this message]
2020-11-23 16:18 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=pj41zl7dqddfkm.fsf@u68c7b5b1d2d758.ant.amazon.com \
--to=shayagr@amazon.com \
--cc=akiyano@amazon.com \
--cc=aliguori@amazon.com \
--cc=alisaidi@amazon.com \
--cc=benh@amazon.com \
--cc=dwmw@amazon.com \
--cc=gtzalik@amazon.com \
--cc=kuba@kernel.org \
--cc=matua@amazon.com \
--cc=msw@amazon.com \
--cc=nafea@amazon.com \
--cc=ndagan@amazon.com \
--cc=netanel@amazon.com \
--cc=netdev@vger.kernel.org \
--cc=saeedb@amazon.com \
--cc=sameehj@amazon.com \
--cc=zorik@amazon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).