From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6BB89C433E9 for ; Tue, 12 Jan 2021 16:03:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 15D18221E2 for ; Tue, 12 Jan 2021 16:03:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2405687AbhALQC5 (ORCPT ); Tue, 12 Jan 2021 11:02:57 -0500 Received: from mx2.suse.de ([195.135.220.15]:46562 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2405624AbhALQC4 (ORCPT ); Tue, 12 Jan 2021 11:02:56 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 2D2C3ABD6; Tue, 12 Jan 2021 16:02:15 +0000 (UTC) Date: Tue, 12 Jan 2021 17:02:15 +0100 Message-ID: From: Takashi Iwai To: Kalle Valo Cc: linux-wireless@vger.kernel.org, netdev@vger.kernel.org, Luca Coelho Subject: Re: [PATCH 1/2] iwlwifi: dbg: Don't touch the tlv data In-Reply-To: <87turmrw9j.fsf@codeaurora.org> References: <20210112132449.22243-1-tiwai@suse.de> <20210112132449.22243-2-tiwai@suse.de> <87turmrw9j.fsf@codeaurora.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Tue, 12 Jan 2021 16:48:56 +0100, Kalle Valo wrote: > > Takashi Iwai writes: > > > The commit ba8f6f4ae254 ("iwlwifi: dbg: add dumping special device > > memory") added a termination of name string just to be sure, and this > > seems causing a regression, a GPF triggered at firmware loading. > > Basically we shouldn't modify the firmware data that may be provided > > as read-only. > > > > This patch drops the code that caused the regression and keep the tlv > > data as is. > > > > Fixes: ba8f6f4ae254 ("iwlwifi: dbg: add dumping special device memory") > > BugLink: https://bugzilla.suse.com/show_bug.cgi?id=1180344 > > BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=210733 > > Signed-off-by: Takashi Iwai > > I'm planning to queue this to v5.11. Should I add cc stable? Yes, it hits 5.10.y. > Luca, can I have your ack? It'd be great if this fix goes in quickly. BTW, I thought network people don't want to have Cc-to-stable in the patch, so I didn't put it by myself. Is this rule still valid? thanks, Takashi