From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 657FCC433E0 for ; Tue, 12 Jan 2021 16:00:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1FCC32168B for ; Tue, 12 Jan 2021 16:00:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2392176AbhALQAL (ORCPT ); Tue, 12 Jan 2021 11:00:11 -0500 Received: from mx2.suse.de ([195.135.220.15]:45076 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2392090AbhALQAK (ORCPT ); Tue, 12 Jan 2021 11:00:10 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id C46DEABD6; Tue, 12 Jan 2021 15:59:28 +0000 (UTC) Date: Tue, 12 Jan 2021 16:59:28 +0100 Message-ID: From: Takashi Iwai To: Kalle Valo Cc: Michal Kubecek , linux-wireless@vger.kernel.org, Mordechay Goodstein , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Arjen de Korte , Luca Coelho Subject: Re: regression in iwlwifi: page fault in iwl_dbg_tlv_alloc_region() (commit ba8f6f4ae254) In-Reply-To: <8735z6taya.fsf@codeaurora.org> References: <20201228115814.GA5880@lion.mk-sys.cz> <87v9c2qtj9.fsf@tynnyri.adurom.net> <87v9c2ias2.fsf@codeaurora.org> <8735z6taya.fsf@codeaurora.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Tue, 12 Jan 2021 16:46:21 +0100, Kalle Valo wrote: > > Takashi Iwai writes: > > > On Tue, 12 Jan 2021 13:45:33 +0100, > > Kalle Valo wrote: > >> > >> Takashi Iwai writes: > >> > >> > On Tue, 12 Jan 2021 12:33:14 +0100, > >> > Kalle Valo wrote: > >> >> > >> >> (adding luca) > >> >> > >> >> Michal Kubecek writes: > >> >> > >> >> > FYI, there is a regression in iwlwifi driver caused by commit > >> >> > ba8f6f4ae254 ("iwlwifi: dbg: add dumping special device memory") > >> >> > reported at > >> >> > > >> >> > https://bugzilla.kernel.org/show_bug.cgi?id=210733 > >> >> > https://bugzilla.suse.com/show_bug.cgi?id=1180344 > >> >> > > >> >> > The problem seems to be an attempt to write terminating null character > >> >> > into a string which may be read only. There is also a proposed fix. > >> >> > >> >> Can someone submit a proper patch, please? See instructions below how to > >> >> submit. > >> >> > >> >> And please add Fixes tag to the commit log: > >> >> > >> >> Fixes: ba8f6f4ae254 ("iwlwifi: dbg: add dumping special device memory") > >> > > >> > OK, I'll do it for my own > >> > >> Thanks. > >> > >> > but really I hoped that someone would have reacted on the bugzilla > >> > report before the official patch submission. So far no one from the > >> > upstream devs showed interest in the bug at all, unfortunately. > >> > >> Bugzilla is problematic as I don't know if anyone tracks it actively, at > >> least I don't have time for that. I recommend reporting all wireless > >> issues to mailing lists to make sure everyone see it. > > > > I share your feeling as a subsystem maintainer, but at the same time, > > I see it's a big problem if the whole bugzilla reports are just > > silently ignored. If it's a void, shouldn't we rather shut it down? > > I'm all for shutting down bugzilla.kernel.org as silent bug reports are > frustrating the users. But I don't know what others would think about > that, maybe some subsystems use it actively? Yes, I'm still checking bugzilla.kernel.org for sound bug reports. Not always promptly reacting like the distro bugzilla, but it's regularly scanned and covered in the best effort basis. Graphics people already moved out of bugzilla to gitlab Issues in their own gitlab.freedesktop.org. Not sure about others. > At least there should be a big warning for wireless bugs. Maybe we can ask Konstantin about that at least for wireless components? > > And, although a mailing list is fine to report via only some texts or > > some patches, it's not suitable to attach large logs or such, which is > > often essential for debugging. Thanks to lore, the archivability is > > no longer a problem with ML recently, but the lack of data assignment > > is another problem, IMO. > > Sure, I fully agree on the benefits of a bug tracker. The issue here is > the lack of people managing bug reports, not the tool. Yeah, it's not only about wireless but true in general: handling bug reports is a tough task and often annoying. Moreover, everyone of course wants to believe that their driver is bug free :) Takashi