From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 980D9C3A59F for ; Thu, 29 Aug 2019 05:20:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6FF9A2339E for ; Thu, 29 Aug 2019 05:20:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726164AbfH2FUq (ORCPT ); Thu, 29 Aug 2019 01:20:46 -0400 Received: from mx2.suse.de ([195.135.220.15]:42956 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725855AbfH2FUq (ORCPT ); Thu, 29 Aug 2019 01:20:46 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 5E0A9AE39; Thu, 29 Aug 2019 05:20:45 +0000 (UTC) Date: Thu, 29 Aug 2019 07:20:44 +0200 Message-ID: From: Takashi Iwai To: David Miller Cc: mlindner@marvell.com, stephen@networkplumber.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, swm@swm1.com Subject: Re: [PATCH] sky2: Disable MSI on yet another ASUS boards (P6Xxxx) In-Reply-To: <20190828.160937.1788181909547435040.davem@davemloft.net> References: <20190828063119.22248-1-tiwai@suse.de> <20190828.160937.1788181909547435040.davem@davemloft.net> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Thu, 29 Aug 2019 01:09:37 +0200, David Miller wrote: > > From: Takashi Iwai > Date: Wed, 28 Aug 2019 08:31:19 +0200 > > > A similar workaround for the suspend/resume problem is needed for yet > > another ASUS machines, P6X models. Like the previous fix, the BIOS > > doesn't provide the standard DMI_SYS_* entry, so again DMI_BOARD_* > > entries are used instead. > > > > Reported-and-tested-by: SteveM > > Signed-off-by: Takashi Iwai > > Applied, but this is getting suspicious. > > It looks like MSI generally is not restored properly on resume on these > boards, so maybe there simply needs to be a generic PCI quirk for that? Yes, I wondered that, too. But, e.g. HD-audio should use MSI on Intel platforms, and if the problem were generic, it must suffer from the same issue, and I haven't heard of such, so far. So it's likely specific to some limited devices, as it seems. Thanks! Takashi