From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 61B93C28CC0 for ; Wed, 29 May 2019 10:07:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 44C8F20644 for ; Wed, 29 May 2019 10:07:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726205AbfE2KHS (ORCPT ); Wed, 29 May 2019 06:07:18 -0400 Received: from mx2.suse.de ([195.135.220.15]:60502 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726326AbfE2KHR (ORCPT ); Wed, 29 May 2019 06:07:17 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id E36FFAEFF; Wed, 29 May 2019 10:07:15 +0000 (UTC) Date: Wed, 29 May 2019 12:07:13 +0200 Message-ID: From: Takashi Iwai To: "Takashi Sakamoto" Cc: "Geert Uytterhoeven" , , "Arnd Bergmann" , "David S . Miller" , "Cong Wang" , "Igor Konopko" , "Clemens Ladisch" , "Matias Bjorling" , , "Eran Ben Elisha" , "Jiri Pirko" , "Jamal Hadi Salim" , "Mohit P . Tahiliani" , "Dan Carpenter" , "Joe Perches" , "Jaroslav Kysela" , "David Howells" , , , Subject: Re: [PATCH 4/5] ALSA: fireface: Use ULL suffixes for 64-bit constants In-Reply-To: <20190529095730.GA7089@workstation> References: <20190528142424.19626-1-geert@linux-m68k.org> <20190528142424.19626-5-geert@linux-m68k.org> <20190529095730.GA7089@workstation> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Wed, 29 May 2019 11:57:31 +0200, Takashi Sakamoto wrote: > > Hi, > > On Tue, May 28, 2019 at 04:24:23PM +0200, Geert Uytterhoeven wrote: > > With gcc 4.1: > > > > sound/firewire/fireface/ff-protocol-latter.c: In function ‘latter_switch_fetching_mode’: > > sound/firewire/fireface/ff-protocol-latter.c:97: warning: integer constant is too large for ‘long’ type > > sound/firewire/fireface/ff-protocol-latter.c: In function ‘latter_begin_session’: > > sound/firewire/fireface/ff-protocol-latter.c:170: warning: integer constant is too large for ‘long’ type > > sound/firewire/fireface/ff-protocol-latter.c:197: warning: integer constant is too large for ‘long’ type > > sound/firewire/fireface/ff-protocol-latter.c:205: warning: integer constant is too large for ‘long’ type > > sound/firewire/fireface/ff-protocol-latter.c: In function ‘latter_finish_session’: > > sound/firewire/fireface/ff-protocol-latter.c:214: warning: integer constant is too large for ‘long’ type > > > > Fix this by adding the missing "ULL" suffixes. > > Add the same suffix to the last constant, to maintain consistency. > > > > Fixes: fd1cc9de64c2ca6c ("ALSA: fireface: add support for Fireface UCX") > > Signed-off-by: Geert Uytterhoeven > > --- > > sound/firewire/fireface/ff-protocol-latter.c | 10 +++++----- > > 1 file changed, 5 insertions(+), 5 deletions(-) > > Thanks for your care. > > Reviewed-by: Takashi Sakamoto Applied to sound git tree now. Thanks. Takashi