From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2CD1EC43381 for ; Tue, 19 Feb 2019 10:00:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E091F2146F for ; Tue, 19 Feb 2019 10:00:12 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=Mellanox.com header.i=@Mellanox.com header.b="qooo2q8y" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727425AbfBSKAL (ORCPT ); Tue, 19 Feb 2019 05:00:11 -0500 Received: from mail-eopbgr50061.outbound.protection.outlook.com ([40.107.5.61]:61369 "EHLO EUR03-VE1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726565AbfBSKAL (ORCPT ); Tue, 19 Feb 2019 05:00:11 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ebdrF4+VUR9UHbAy3yb5h9BRirCbMu41nY49B/Ydd5w=; b=qooo2q8yEa3J+9QWUTYg1OQmRXwFJS/1HbVu1/QOeMhyZ4xnfJ0uJ2JEmkvRWBzAgUFFK6qu69uZhUGL0Df4mlCY9M+J4arPXPQSwKbjO4FSSzBAKFL4r9AWyJ7WTuK5/2XUS77VAIQapSOFA6sVutLsIN4oKghcmAOabZPYpcI= Received: from VI1PR0502MB3647.eurprd05.prod.outlook.com (52.134.7.141) by VI1PR0502MB3934.eurprd05.prod.outlook.com (52.134.6.27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1622.19; Tue, 19 Feb 2019 10:00:07 +0000 Received: from VI1PR0502MB3647.eurprd05.prod.outlook.com ([fe80::d058:d17:78fc:969a]) by VI1PR0502MB3647.eurprd05.prod.outlook.com ([fe80::d058:d17:78fc:969a%6]) with mapi id 15.20.1622.018; Tue, 19 Feb 2019 10:00:07 +0000 From: Vlad Buslov To: Cong Wang CC: Linux Kernel Network Developers , Jamal Hadi Salim , Jiri Pirko , David Miller Subject: Re: [PATCH net-next 00/12] Refactor flower classifier to remove dependency on rtnl lock Thread-Topic: [PATCH net-next 00/12] Refactor flower classifier to remove dependency on rtnl lock Thread-Index: AQHUxDmgKTqmuTz4YECdC1pe4Gz1ZKXl9AqAgAD3RQA= Date: Tue, 19 Feb 2019 10:00:07 +0000 Message-ID: References: <20190214074712.17846-1-vladbu@mellanox.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: LO2P265CA0225.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:b::21) To VI1PR0502MB3647.eurprd05.prod.outlook.com (2603:10a6:803:f::13) authentication-results: spf=none (sender IP is ) smtp.mailfrom=vladbu@mellanox.com; x-ms-exchange-messagesentrepresentingtype: 1 x-originating-ip: [37.142.13.130] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 25877f62-bb4b-433f-489d-08d696510631 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0;PCL:0;RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600110)(711020)(4605104)(4618075)(2017052603328)(7153060)(7193020);SRVR:VI1PR0502MB3934; x-ms-traffictypediagnostic: VI1PR0502MB3934: x-microsoft-exchange-diagnostics: =?iso-8859-1?Q?1;VI1PR0502MB3934;23:oFxYiQkqFPVyGooerM1Qxgzp6gigFu50nydMM?= =?iso-8859-1?Q?uUATSqziKYBtXUeAP9fa9L7mCnDXvFxllgQeyK75XjpVuPNEX9LcuJPEV+?= =?iso-8859-1?Q?j/PpeVNkmen9j1nrs1nTPYf0q8Syy+PQL0MIH/irDHXQYR8Fw9TmgeIYur?= =?iso-8859-1?Q?DOHL7R7sdvHwuC6kscTCVeWrnl0C69BGFWwHmxw6IYwsxUhQZ4ivMBXGsE?= =?iso-8859-1?Q?76znro7Qv3KhazpspFFCqPEduCPvzJwTso0WU29D0zd0Dx7+SXKql2FMHY?= =?iso-8859-1?Q?mzLsOCmlCxoV/EaTIsdtXVg5wDGrIE7o5Jlrj67b70bpIGxhSvSfkIJ1Bd?= =?iso-8859-1?Q?PXD2dE+vCA5SjMCGCzkGLXYFxYCod+GuLqX7pd69Ki+e2hJkbH0nSQ/hJr?= =?iso-8859-1?Q?t4j+Gveur9fQem4H6wngk+uMwfAx29V/A4z72D+qXvdTzVXGtN4+CKzYZx?= =?iso-8859-1?Q?5/uuw/puQ+s6ZaiWRuROs5A3MVV3AY7D5g6BaNuUWSb12LyQt+Bfvq2fek?= =?iso-8859-1?Q?iDhMrsN54WKfpls3b8/LmxNq971XdFwJVDKrv6Ngu+Kc9jkyVqff6IKiCv?= =?iso-8859-1?Q?1kLBWZR3VXg9sLQliOAWTsYcYSKRMVIOv9V37GnHgLM3XQJTBKB0OiNwGq?= =?iso-8859-1?Q?oleCX57BInwBO1+7huYtVJfsnV3bvQEr/OcJsvGtECUg1vwq4PjzBN9gmG?= =?iso-8859-1?Q?YRS0ZvOc5ZGPvDM/4RF58L+5tp+WjVyB6yqQeHerW0C0f8sj4gndzlBc9Y?= =?iso-8859-1?Q?gSD/aREeMnyME2wHiFD3d5FMoJM8UOxN7NF+rxzec053d/YiVtfl+T9vQb?= =?iso-8859-1?Q?6T2PrR/5LwRdGgscuDfIss/7pKlveI2UAUPkJnI0RiYxBACEkWuvjVSu47?= =?iso-8859-1?Q?w1kAdJI+HzLVzwLWkwQrGzrSbkq2rrqmVwJzvaWfR0+roGvaD2ghSbiGN5?= =?iso-8859-1?Q?402J08xsNfcKkPv1LILCYI+EQdLjMkhnED7hLdEJvZW3FQsY5S3PY8VTnW?= =?iso-8859-1?Q?FfheCxuqTQaUMaqnCdZD2lUDzpXQHv8q7gz14bWiDch8al56wpUh/Ly28J?= =?iso-8859-1?Q?I+NuaA4eGn/gmaGqy+mYxOssPl9ETFWRxUXZisECfsqfZ5y0tGObaBszW+?= =?iso-8859-1?Q?/+E73z3NAkcPLoZBYU7xgY3ZugdyOIp8UbgYgnc3mKZxBv4QMxNOdbNnSK?= =?iso-8859-1?Q?+1i1cERw9jnJk6+cYYWBYGAuEGls4V8m0s1y/8d7YJ45blWaXIPbpQA2iQ?= =?iso-8859-1?Q?BdZ2GLlYEmz4dILpOx2vMQjBUtq06lh4qAj2BwmFQ=3D=3D?= x-microsoft-antispam-prvs: x-forefront-prvs: 09538D3531 x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(39860400002)(366004)(396003)(376002)(136003)(346002)(189003)(199004)(14454004)(305945005)(26005)(66066001)(99286004)(478600001)(76176011)(81156014)(2906002)(8676002)(81166006)(86362001)(5660300002)(6916009)(68736007)(6486002)(7736002)(52116002)(4744005)(6512007)(229853002)(8936002)(6436002)(11346002)(446003)(2616005)(106356001)(97736004)(3846002)(476003)(486006)(105586002)(6116002)(54906003)(36756003)(186003)(71200400001)(102836004)(71190400001)(6246003)(6506007)(386003)(316002)(25786009)(4326008)(53936002)(256004);DIR:OUT;SFP:1101;SCL:1;SRVR:VI1PR0502MB3934;H:VI1PR0502MB3647.eurprd05.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;MX:1;A:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: /ZuSTW25uQI9e85uzdbJCuu5FSE1wGZ36YTbLqugO7Wgiv/mWnnoezX6LVKnpTjEh+U7OzEa7PYTmxvCBRZIuawCBvzo9xwOCVj8uvm4VozrVtf+bUS+5jRhxo+zKJVcXPlzPzWrlteTyGuNfhSgwCODDoJitWvLqNRsvP2nTuI8PMwC824GKUyUPooF+GMol1VRcoJZuSp/kpDvJjT2h/03hKGCuUGG3/PyO1bAuG7NrY6cO85VqA9w8UrPh7EY2+AurT+AjvMoNzsW4AtWcVzKXXG6IwtLy9NeLxdVeo9cwXtfSOac9t4aukLYLE3C6qK9eCTPhHA+7Iwsl4wKz5kTsecLPQU/O+YTos5bVlM8aCPDz1nnDX68TKXtxh5ZvUghPOwz3109NTqtQzhmn4g2p7wYWE2BWowBAQNpvTQ= Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 25877f62-bb4b-433f-489d-08d696510631 X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Feb 2019 10:00:05.2969 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0502MB3934 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Mon 18 Feb 2019 at 19:15, Cong Wang wrote: > Hi, > >> net/sched/cls_flower.c | 424 +++++++++++++++++++++++++++++++++++++-----= ------- >> 1 file changed, 321 insertions(+), 103 deletions(-) >> > > Given you change cls_flower so much, please also add a test case for > verifying your changes, especially focusing on the atomicity of concurren= t > modifications. > > Thanks. Will do.