From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 319F7C4363A for ; Mon, 26 Oct 2020 17:46:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CB1E62225C for ; Mon, 26 Oct 2020 17:46:46 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=nvidia.com header.i=@nvidia.com header.b="ZYEcFh68" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1788351AbgJZRqo (ORCPT ); Mon, 26 Oct 2020 13:46:44 -0400 Received: from hqnvemgate25.nvidia.com ([216.228.121.64]:6406 "EHLO hqnvemgate25.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1788225AbgJZRqn (ORCPT ); Mon, 26 Oct 2020 13:46:43 -0400 Received: from hqmail.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate25.nvidia.com (using TLS: TLSv1.2, AES256-SHA) id ; Mon, 26 Oct 2020 10:46:47 -0700 Received: from reg-r-vrt-018-180.nvidia.com (172.20.13.39) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Mon, 26 Oct 2020 17:46:33 +0000 References: <20201016144205.21787-1-vladbu@nvidia.com> <20201016144205.21787-3-vladbu@nvidia.com> <0bb6f625-c987-03d7-7225-eee03345168e@mojatatu.com> <87a6wm15rz.fsf@buslov.dev> <877drn20h3.fsf@buslov.dev> <87362a1byb.fsf@buslov.dev> <5c79152f-1532-141a-b1d3-729fdd798b3f@mojatatu.com> <89a5434b-06e9-947a-d364-acd2a306fc4d@mojatatu.com> <370dd8e0-315b-04a5-c137-3b4f3cbd02a0@mojatatu.com> User-agent: mu4e 1.4.12; emacs 26.2.90 From: Vlad Buslov To: Jamal Hadi Salim CC: Vlad Buslov , , , , , , , , Vlad Buslov Subject: Re: [PATCH iproute2-next v3 2/2] tc: implement support for terse dump In-Reply-To: <370dd8e0-315b-04a5-c137-3b4f3cbd02a0@mojatatu.com> Date: Mon, 26 Oct 2020 19:46:30 +0200 Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [172.20.13.39] X-ClientProxiedBy: HQMAIL107.nvidia.com (172.20.187.13) To HQMAIL107.nvidia.com (172.20.187.13) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1603734407; bh=sF/ZEGVzJ6GJovhtYRNTKWOsniff6GBwDJu2O83kAuU=; h=References:User-agent:From:To:CC:Subject:In-Reply-To:Date: Message-ID:MIME-Version:Content-Type:X-Originating-IP: X-ClientProxiedBy; b=ZYEcFh68wHTZ1EJxMyCKznkBFePeYFR9OJObN2FOJg4Ut4vOaFMpaLPA+cztZyWwr GIC7+ZBUUHWgEeZ3V3vJQoWr9gwWyZyEztj00q6N419mgdARxmTAxJsJ41xuXsAd2l 9nYvFi/cIIgCPCN1MeEKkIX6626IvPRQRpa6mAPgO4GQl5tyinJZdisCc1GpaL7hGw M0nEcds7hzDw7zJDVtTddkcncPRkVs6wbXI36ei5ylIuWaQuj04Hdymr39Z4Why5nv dN09lCkDCZSbd6GJlOPaZyLN/GH0Nn0UPdoyxSaloYcaiRrUfrfbp58RLliUgU5yvN 6ejlz/O/DEFXA== Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Mon 26 Oct 2020 at 19:12, Jamal Hadi Salim wrote: > On 2020-10-26 7:28 a.m., Vlad Buslov wrote: >> >> On Sat 24 Oct 2020 at 20:40, Jamal Hadi Salim wrote: > > [..] >>>> >>>> Yes, that makes sense. I guess introducing something like 'tc action -br >>>> ls ..' mode implemented by means of existing terse flag + new 'also >>>> output action index' flag would achieve that goal. >>>> >>> >>> Right. There should be no interest in the cookie here at all. Maybe >>> it could be optional with a flag indication. >>> Have time to cook a patch? I'll taste/test it. >> >> Patch to make cookie in filter terse dump optional? That would break >> existing terse dump users that rely on it (OVS). > > Meant patch for 'tc action -br ls' > > Which by default would not include the cookie. So action-dump-specific flag that causes act api to output action index (via new attribute) and skips cookie? > > cheers, > jamal