From: Pablo Neira Ayuso <pablo@netfilter.org>
To: netfilter-devel@vger.kernel.org
Cc: davem@davemloft.net, netdev@vger.kernel.org
Subject: [PATCH 03/10] ipvs: fix ipv6 route unreach panic
Date: Thu, 23 Jul 2015 01:00:45 +0200 [thread overview]
Message-ID: <1437606052-5179-4-git-send-email-pablo@netfilter.org> (raw)
In-Reply-To: <1437606052-5179-1-git-send-email-pablo@netfilter.org>
From: Alex Gartrell <agartrell@fb.com>
Previously there was a trivial panic
unshare -n /bin/bash <<EOF
ip addr add dev lo face::1/128
ipvsadm -A -t [face::1]:15213
ipvsadm -a -t [face::1]:15213 -r b00c::1
echo boom | nc face::1 15213
EOF
This patch allows us to replicate the net logic above and simply capture
the skb_dst(skb)->dev and use that for the purpose of the invocation.
Signed-off-by: Alex Gartrell <agartrell@fb.com>
Acked-by: Julian Anastasov <ja@ssi.bg>
Signed-off-by: Simon Horman <horms@verge.net.au>
---
net/netfilter/ipvs/ip_vs_xmit.c | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/net/netfilter/ipvs/ip_vs_xmit.c b/net/netfilter/ipvs/ip_vs_xmit.c
index bf66a86..b99d806 100644
--- a/net/netfilter/ipvs/ip_vs_xmit.c
+++ b/net/netfilter/ipvs/ip_vs_xmit.c
@@ -505,6 +505,13 @@ err_put:
return -1;
err_unreach:
+ /* The ip6_link_failure function requires the dev field to be set
+ * in order to get the net (further for the sake of fwmark
+ * reflection).
+ */
+ if (!skb->dev)
+ skb->dev = skb_dst(skb)->dev;
+
dst_link_failure(skb);
return -1;
}
--
1.7.10.4
next prev parent reply other threads:[~2015-07-22 23:00 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-22 23:00 [PATCH 00/10] Netfilter/IPVS fixes for net Pablo Neira Ayuso
2015-07-22 23:00 ` [PATCH 01/10] netfilter: ctnetlink: put back references to master ct and expect objects Pablo Neira Ayuso
2015-07-22 23:00 ` [PATCH 02/10] netfilter: IDLETIMER: fix lockdep warning Pablo Neira Ayuso
2015-07-22 23:00 ` Pablo Neira Ayuso [this message]
2015-07-22 23:00 ` [PATCH 04/10] ipvs: do not use random local source address for tunnels Pablo Neira Ayuso
2015-07-22 23:00 ` [PATCH 05/10] ipvs: fix crash if scheduler is changed Pablo Neira Ayuso
2015-07-22 23:00 ` [PATCH 06/10] ipvs: skb_orphan in case of forwarding Pablo Neira Ayuso
2015-07-22 23:00 ` [PATCH 07/10] ipvs: fix crash with sync protocol v0 and FTP Pablo Neira Ayuso
2015-07-22 23:00 ` [PATCH 08/10] ipvs: call skb_sender_cpu_clear Pablo Neira Ayuso
2015-07-22 23:00 ` [PATCH 09/10] netfilter: fix netns dependencies with conntrack templates Pablo Neira Ayuso
2015-07-22 23:00 ` [PATCH 10/10] netfilter: nf_conntrack: Support expectations in different zones Pablo Neira Ayuso
2015-07-25 7:18 ` [PATCH 00/10] Netfilter/IPVS fixes for net David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1437606052-5179-4-git-send-email-pablo@netfilter.org \
--to=pablo@netfilter.org \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).