From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joe Perches Subject: Re: [PATCH 02/29] netfilter: physdev: add missed blank Date: Mon, 05 Sep 2016 10:43:17 -0700 Message-ID: <1473097397.1992.3.camel@perches.com> References: <1473073124-5015-1-git-send-email-pablo@netfilter.org> <1473073124-5015-3-git-send-email-pablo@netfilter.org> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 8bit Cc: davem@davemloft.net, netdev@vger.kernel.org To: Pablo Neira Ayuso , netfilter-devel@vger.kernel.org Return-path: In-Reply-To: <1473073124-5015-3-git-send-email-pablo@netfilter.org> Sender: netdev-owner@vger.kernel.org List-Id: netfilter-devel.vger.kernel.org On Mon, 2016-09-05 at 12:58 +0200, Pablo Neira Ayuso wrote: [] > diff --git a/net/netfilter/xt_physdev.c b/net/netfilter/xt_physdev.c [] > @@ -107,8 +107,8 @@ static int physdev_mt_check(const struct xt_mtchk_param *par) >        info->invert & XT_PHYSDEV_OP_BRIDGED) && >       par->hook_mask & ((1 << NF_INET_LOCAL_OUT) | >       (1 << NF_INET_FORWARD) | (1 << NF_INET_POST_ROUTING))) { > - pr_info("using --physdev-out and --physdev-is-out are only" > - "supported in the FORWARD and POSTROUTING chains with" > + pr_info("using --physdev-out and --physdev-is-out are only " > + "supported in the FORWARD and POSTROUTING chains with " >   "bridged traffic.\n"); >   if (par->hook_mask & (1 << NF_INET_LOCAL_OUT)) >   return -EINVAL; Perhaps it would be reasonable at some point to coalesce all the string fragments. Maybe using this could help: $ git ls-files -- "net/netfilter/*.[ch]" | \ xargs ./scripts/checkpatch.pl -f --types=split_string --fix-inplace