From: Paul Gortmaker <paul.gortmaker@windriver.com>
To: <netdev@vger.kernel.org>
Cc: Paul Gortmaker <paul.gortmaker@windriver.com>,
"David S. Miller" <davem@davemloft.net>,
Florian Westphal <fw@strlen.de>,
Jozsef Kadlecsik <kadlec@blackhole.kfki.hu>,
Pablo Neira Ayuso <pablo@netfilter.org>,
<netfilter-devel@vger.kernel.org>, <coreteam@netfilter.org>
Subject: [PATCH -next 0/3] netfilter: header cleanup
Date: Mon, 15 Apr 2019 16:43:13 -0400 [thread overview]
Message-ID: <1555360996-23684-1-git-send-email-paul.gortmaker@windriver.com> (raw)
Having core header files in include/linux that in turn include other
headers with a high number of includes implicitly degenerates into
a formalism that hides what amounts to #include <linux/everything.h>
Some headers, like module.h and device.h are good examples that will
essentially drag in almost everything.
There is nothing module specific about netfilter, but before we try
and stop nf_tables.h from including module.h, we have to fix two
instances of code which are implicitly relying on that module.h
inclusion, so as to not introduce build regressions.
---
Cc: "David S. Miller" <davem@davemloft.net>
Cc: Florian Westphal <fw@strlen.de>
Cc: Jozsef Kadlecsik <kadlec@blackhole.kfki.hu>
Cc: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: netfilter-devel@vger.kernel.org
Cc: coreteam@netfilter.org
Paul Gortmaker (3):
netfilter: nf_tables: relocate header content to consumer
netfilter: nf_tables: fix implicit include of module.h
netfilter: nf_tables: drop include of module.h from nf_tables.h
include/net/netfilter/nf_tables.h | 20 ++------------------
net/netfilter/nf_tables_set_core.c | 1 +
net/netfilter/nft_dynset.c | 17 +++++++++++++++++
3 files changed, 20 insertions(+), 18 deletions(-)
--
2.7.4
next reply other threads:[~2019-04-15 20:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-15 20:43 Paul Gortmaker [this message]
2019-04-15 20:43 ` [PATCH -next 1/3] netfilter: nf_tables: relocate header content to consumer Paul Gortmaker
2019-04-15 20:43 ` [PATCH -next 2/3] netfilter: nf_tables: fix implicit include of module.h Paul Gortmaker
2019-04-15 20:43 ` [PATCH -next 3/3] netfilter: nf_tables: drop include of module.h from nf_tables.h Paul Gortmaker
2019-04-30 11:39 ` [PATCH -next 0/3] netfilter: header cleanup Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1555360996-23684-1-git-send-email-paul.gortmaker@windriver.com \
--to=paul.gortmaker@windriver.com \
--cc=coreteam@netfilter.org \
--cc=davem@davemloft.net \
--cc=fw@strlen.de \
--cc=kadlec@blackhole.kfki.hu \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).