From mboxrd@z Thu Jan  1 00:00:00 1970
From: Pablo Neira Ayuso <pablo@netfilter.org>
Subject: Re: [PATCH 2/4] netfilter: avoid build error if TPROXY/SOCKET=y &&
 NF_DEFRAG_IPV6=m
Date: Sat, 16 May 2015 21:24:05 +0200
Message-ID: <20150516192405.GA5349@salvia>
References: <1431802038-4502-1-git-send-email-pablo@netfilter.org>
 <1431802038-4502-3-git-send-email-pablo@netfilter.org>
 <5557956F.9050508@cogentembedded.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: netfilter-devel@vger.kernel.org, davem@davemloft.net,
	netdev@vger.kernel.org
To: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Return-path: <netdev-owner@vger.kernel.org>
Content-Disposition: inline
In-Reply-To: <5557956F.9050508@cogentembedded.com>
Sender: netdev-owner@vger.kernel.org
List-Id: netfilter-devel.vger.kernel.org

On Sat, May 16, 2015 at 10:07:27PM +0300, Sergei Shtylyov wrote:
> Hello.
> 
> On 05/16/2015 09:47 PM, Pablo Neira Ayuso wrote:
> 
> >From: Florian Westphal <fw@strlen.de>
> 
> >With TPROXY=y but DEFRAG_IPV6=m we get build failure:
> 
> >net/built-in.o: In function `tproxy_tg_init':
> >net/netfilter/xt_TPROXY.c:588: undefined reference to `nf_defrag_ipv6_enable'
> 
> >If DEFRAG_IPV6 is modular, TPROXY must be too.
> >(or both must be builtin).
> 
> >This enforces =m for both.
> 
> >Reported-and-tested-by: Liu Hua <liusdu@126.com>
> >Signed-off-by: Florian Westphal <fw@strlen.de>
> >Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
> >---
> >  net/netfilter/Kconfig |    2 ++
> >  1 file changed, 2 insertions(+)
> 
> >diff --git a/net/netfilter/Kconfig b/net/netfilter/Kconfig
> >index f70e34a..a0f3e6a3 100644
> >--- a/net/netfilter/Kconfig
> >+++ b/net/netfilter/Kconfig
> >@@ -863,6 +863,7 @@ config NETFILTER_XT_TARGET_TPROXY
> >  	depends on NETFILTER_XTABLES
> >  	depends on NETFILTER_ADVANCED
> >  	depends on (IPV6 || IPV6=n)
> >+	depends on (IP6_NF_IPTABLES || IP6_NF_IPTABLES=n)
> >  	depends on IP_NF_MANGLE
> >  	select NF_DEFRAG_IPV4
> >  	select NF_DEFRAG_IPV6 if IP6_NF_IPTABLES
> >@@ -1356,6 +1357,7 @@ config NETFILTER_XT_MATCH_SOCKET
> >  	depends on NETFILTER_ADVANCED
> >  	depends on !NF_CONNTRACK || NF_CONNTRACK
> >  	depends on (IPV6 || IPV6=n)
> >+	depends on (IP6_NF_IPTABLES || IP6_NF_IPTABLES=n)
> 
>    Parens not needed here and in the previous hunk.

OK, but we've been using parens in quite many other spots in the
Netfilter Kconfig files. So if you don't mind, we'll send follow up
large patch to sort out this for net-next.

Thank you.