From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Jan Engelhardt <jengelh@inai.de>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH 2/2] extensions: restore matching any SPI id by default
Date: Wed, 15 Jul 2015 18:55:15 +0200 [thread overview]
Message-ID: <20150715165515.GA4177@salvia> (raw)
In-Reply-To: <alpine.LSU.2.20.1507151837110.15534@nerf40.vanv.qr>
On Wed, Jul 15, 2015 at 06:41:54PM +0200, Jan Engelhardt wrote:
>
> On Wednesday 2015-07-15 18:24, Pablo Neira Ayuso wrote:
> >On Wed, Jul 15, 2015 at 02:53:39PM +0200, Jan Engelhardt wrote:
> >[...]
> >> diff --git a/extensions/libxt_esp.t b/extensions/libxt_esp.t
> >> index 008013b..f207def 100644
> >> --- a/extensions/libxt_esp.t
> >> +++ b/extensions/libxt_esp.t
> >> @@ -4,6 +4,7 @@
> >> -p esp -m esp --espspi 0:4294967295;-p esp -m esp;OK
> >> -p esp -m esp ! --espspi 0:4294967294;=;OK
> >> -p esp -m esp --espspi -1;;FAIL
> >> +-p esp -m esp;-p esp -m esp --espspi 0;FAIL
> >> # should fail?
> >> -p esp -m esp;=;OK
> >
> >This line looks very similar to the one above the comment, but it says OK.
>
> Indeed the FAIL line is indeed mirroring the OK line, the latter of
> which should have failed the testsuite previously.
Right.
Given that this is changing the behaviour again, I would suggest that
-p esp -m esp displays -p -m esp --espspi 0:4294967295 via
iptables-save.
I think this default behaviour is less obscure which they can still
type less from the command line.
next prev parent reply other threads:[~2015-07-15 16:49 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-15 12:53 iptables: AH/ESP init fix, and a build fix Jan Engelhardt
2015-07-15 12:53 ` [PATCH 1/2] build: resolve build error involving libnftnl Jan Engelhardt
2015-07-15 16:28 ` Pablo Neira Ayuso
2015-07-15 12:53 ` [PATCH 2/2] extensions: restore matching any SPI id by default Jan Engelhardt
2015-07-15 16:24 ` Pablo Neira Ayuso
2015-07-15 16:41 ` Jan Engelhardt
2015-07-15 16:55 ` Pablo Neira Ayuso [this message]
2015-07-15 17:10 ` Jan Engelhardt
2015-07-15 17:30 ` Pablo Neira Ayuso
2015-07-15 17:46 ` Jan Engelhardt
2015-08-07 11:07 ` Pablo Neira Ayuso
2015-08-07 11:38 ` Jan Engelhardt
2015-08-10 12:04 ` Pablo Neira Ayuso
2015-08-10 12:15 ` Jan Engelhardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150715165515.GA4177@salvia \
--to=pablo@netfilter.org \
--cc=jengelh@inai.de \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).