From: Patrick McHardy <kaber@trash.net>
To: Phil Sutter <phil@nwl.cc>
Cc: pablo@netfilter.org, netdev@vger.kernel.org,
netfilter-devel@vger.kernel.org
Subject: Re: [PATCH 1/2] netfilter: ip6t_SYNPROXY: fix NULL pointer dereference
Date: Sat, 8 Aug 2015 17:57:46 +0200 [thread overview]
Message-ID: <20150808155746.GC29362@acer.localdomain> (raw)
In-Reply-To: <1438864497-3767-1-git-send-email-phil@nwl.cc>
On 06.08, Phil Sutter wrote:
> This happens when networking namespaces are enabled.
Thanks, just one minor request:
> synproxy_send_tcp(const struct sk_buff *skb, struct sk_buff *nskb,
> struct nf_conntrack *nfct, enum ip_conntrack_info ctinfo,
> struct ipv6hdr *niph, struct tcphdr *nth,
> - unsigned int tcp_hdr_size)
> + unsigned int tcp_hdr_size, struct synproxy_net *snet)
Logically the synproxy_net pointer should come before all other arguments
since its the container for a lot of the following arguments.
next prev parent reply other threads:[~2015-08-08 15:57 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1438037606-5462-1-git-send-email-phil@nwl.cc>
2015-08-04 17:53 ` [PATCH] netfilter: ipt_SYNPROXY: fix sending window update to client Pablo Neira Ayuso
2015-08-06 12:34 ` [PATCH 1/2] netfilter: ip6t_SYNPROXY: fix NULL pointer dereference Phil Sutter
2015-08-06 12:34 ` [PATCH 2/2] netfilter: ip6t_SYNPROXY: fix sending window update to client Phil Sutter
2015-08-08 15:57 ` Patrick McHardy [this message]
2015-08-09 11:14 ` [PATCH v2 1/2] netfilter: ip6t_SYNPROXY: fix NULL pointer dereference Phil Sutter
2015-08-09 11:14 ` [PATCH v2 2/2] netfilter: ip6t_SYNPROXY: fix sending window update to client Phil Sutter
2015-08-10 8:06 ` Patrick McHardy
2015-08-10 11:58 ` Pablo Neira Ayuso
2015-08-10 7:57 ` [PATCH v2 1/2] netfilter: ip6t_SYNPROXY: fix NULL pointer dereference Patrick McHardy
2015-08-10 11:58 ` Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150808155746.GC29362@acer.localdomain \
--to=kaber@trash.net \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
--cc=phil@nwl.cc \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).