From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Patrick McHardy <kaber@trash.net>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH nf-next 1/3] netfilter: nf_tables: add generation mask to table objects
Date: Mon, 10 Aug 2015 20:37:15 +0200 [thread overview]
Message-ID: <20150810183715.GA12171@salvia> (raw)
In-Reply-To: <20150810075646.GA20899@acer.localdomain>
On Mon, Aug 10, 2015 at 09:56:46AM +0200, Patrick McHardy wrote:
> On 06.08, Pablo Neira Ayuso wrote:
> > On Wed, Aug 05, 2015 at 11:09:16AM +0200, Patrick McHardy wrote:
[...]
> > > > - preparation phase -
> > > > delete table y
> > > > create table y
> > > > create set x
> > > > - commit phase -
> > > > send NEWGEN, attribute type: begin
> > > > delete table y
> > > > create table y
> > > > create set x
> > > > send NEWGEN, attribute type: end
> > > >
> > > > Thanks for your feedback!
> > >
> > > That might work if the message ordering is then guaranteed. However I think
> > > we can fix this case without changing NEWGEN. Let me think about that a bit,
> > > for now just taking care of the genid checks correctly seems like a good
> > > step forward.
> >
> > But we can catch this problem through ->res_id, OK?
>
> I guess we could with a unique res_id per object, but how would this work
> with multiple object types? Any change bumps res_id, so we'd invalidate
> the full dump for any change.
I see, if we want to be able to invalidate caches at per-object level,
then I think we have to recover the idea of having a netlink attribute
for the per-object generation counter.
next prev parent reply other threads:[~2015-08-10 18:31 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-04 9:05 [PATCH nf-next 1/3] netfilter: nf_tables: add generation mask to table objects Pablo Neira Ayuso
2015-08-04 9:05 ` [PATCH nf-next 2/3] netfilter: nf_tables: add generation mask to chain objects Pablo Neira Ayuso
2015-08-04 9:05 ` [PATCH nf-next 3/3] netfilter: nf_tables: add generation mask to set objects Pablo Neira Ayuso
2015-08-04 9:12 ` Patrick McHardy
2015-08-04 9:29 ` Pablo Neira Ayuso
2015-08-04 10:38 ` Patrick McHardy
2015-08-04 17:23 ` Pablo Neira Ayuso
2015-08-04 9:09 ` [PATCH nf-next 1/3] netfilter: nf_tables: add generation mask to table objects Patrick McHardy
2015-08-04 9:29 ` Pablo Neira Ayuso
2015-08-04 10:26 ` Patrick McHardy
2015-08-04 17:04 ` Pablo Neira Ayuso
2015-08-05 9:09 ` Patrick McHardy
2015-08-06 10:20 ` Pablo Neira Ayuso
2015-08-08 15:53 ` Patrick McHardy
2015-08-10 7:56 ` Patrick McHardy
2015-08-10 18:37 ` Pablo Neira Ayuso [this message]
2015-08-04 18:21 ` Pablo Neira Ayuso
2015-08-05 8:41 ` Patrick McHardy
2015-08-06 10:21 ` Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150810183715.GA12171@salvia \
--to=pablo@netfilter.org \
--cc=kaber@trash.net \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).