From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Ken-ichirou MATSUZAWA <chamaken@gmail.com>
Cc: The netfilter developer mailinglist <netfilter-devel@vger.kernel.org>
Subject: Re: [lnf-log RFC PATCH 2/2] utils: take a example from libmnl and use nflog_nlmsg_parse
Date: Thu, 20 Aug 2015 00:04:03 +0200 [thread overview]
Message-ID: <20150819220403.GA5220@salvia> (raw)
In-Reply-To: <20150819071103.GA15064@gmail.com>
On Wed, Aug 19, 2015 at 04:11:03PM +0900, Ken-ichirou MATSUZAWA wrote:
[...]
> Would you confirm the functions for nlmsg building which you suggested
> to add because it's a little different from you suggested. I am worried
> about it's in accodance with your intention.
I suggest you remove the nflog_data_init(), nflog_data_alloc(),
nflog_data_free() and nflog_nlmsg_parse().
Those are part of the old API, we should focus on API that we can
combine with libmnl.
More comments below:
> In addition, I added NFLOG_DATA_SIZE as is, the size of struct
> nflog_data. This enables to preallocate buffer, and I added
> functions which initialize a buffer based on this.
>
> Would you see it again?
>
> Changes from previous:
> * introduce nlmsg three build functions:
> struct nlmsghdr *
> nfnl_nlmsg_put_header(char *buf, uint8_t type, uint8_t family, uint16_t qnum);
> int nfnl_attr_put_cfg_mode(struct nlmsghdr *nlh, struct nfulnl_msg_config_mode *mode);
> int nfnl_attr_put_cfg_cmd(struct nlmsghdr *nlh, struct nfulnl_msg_config_cmd *cmd);
One small change more, please change this interface from:
+ nfcmd.command = NFULNL_CFG_CMD_PF_UNBIND;
+ if (nfnl_attr_put_cfg_cmd(nlh, &nfcmd) < 0) {
to:
if (nfnl_attr_put_cfg_cmd(nlh, NFULNL_CFG_CMD_PF_UNBIND) < 0) {
Same thing with nfnl_attr_put_cfg_mode(), replace this:
+ nfmode.copy_mode = NFULNL_COPY_PACKET;
+ nfmode.copy_range = 0xFFFF;
+ if (nfnl_attr_put_cfg_mode(nlh, &nfmode) < 0) {
to:
if (nfnl_attr_put_cfg_mode(nlh, NFULNL_COPY_PACKET, 0xffff)
> * introduce NFLOG_DATA_SIZE macro and use it at allocate functions.
You can remove NFLOG_DATA_SIZE, this is only needed by the old API,
not for libmnl.
> * update utils/nf-log to fit with the above.
Thanks a lot!
next prev parent reply other threads:[~2015-08-19 21:57 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-10 8:13 [lnf-log RFC PATCH 0/2] introduce new functions to use without nflog_handle Ken-ichirou MATSUZAWA
2015-08-10 8:15 ` [lnf-log RFC PATCH 1/2] " Ken-ichirou MATSUZAWA
2015-08-18 5:48 ` Pablo Neira Ayuso
2015-08-10 8:17 ` [lnf-log RFC PATCH 2/2] utils: take a example from libmnl and use nflog_nlmsg_parse Ken-ichirou MATSUZAWA
2015-08-18 6:04 ` Pablo Neira Ayuso
2015-08-19 7:11 ` Ken-ichirou MATSUZAWA
2015-08-19 7:13 ` [lnf-log RFC PATCH v2 1/2] introduce new functions independent from libnfnetlink Ken-ichirou MATSUZAWA
2015-08-19 7:15 ` [lnf-log RFC PATCH v2 2/2] utils: take a example from libmnl and use new functions Ken-ichirou MATSUZAWA
2015-08-19 22:04 ` Pablo Neira Ayuso [this message]
2015-08-20 7:26 ` [lnf-log RFC PATCH 2/2] utils: take a example from libmnl and use nflog_nlmsg_parse Ken-ichirou MATSUZAWA
2015-08-20 7:29 ` [lnf-log PATCH 1/2] introduce new functions independent from libnfnetlink Ken-ichirou MATSUZAWA
2015-08-20 7:31 ` [lnf-log PATCH 2/2] utils: take a example from libmnl and use new functions Ken-ichirou MATSUZAWA
2015-08-20 18:16 ` [lnf-log RFC PATCH 2/2] utils: take a example from libmnl and use nflog_nlmsg_parse Pablo Neira Ayuso
2015-08-21 0:23 ` Ken-ichirou MATSUZAWA
2015-08-21 0:26 ` [lnf-log PATCHv2 1/3] introduce new functions independent from libnfnetlink Ken-ichirou MATSUZAWA
2015-08-26 19:01 ` Pablo Neira Ayuso
2015-08-21 0:27 ` [lnf-log PATCHv2 2/3] utils: take a example from libmnl and use new functions Ken-ichirou MATSUZAWA
2015-08-26 19:01 ` Pablo Neira Ayuso
2015-08-21 0:30 ` [lnf-log PATCHv2 3/3] nlmsg: add printf function in conjunction with libmnl Ken-ichirou MATSUZAWA
2015-08-26 19:01 ` Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150819220403.GA5220@salvia \
--to=pablo@netfilter.org \
--cc=chamaken@gmail.com \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).