From: Florian Westphal <fw@strlen.de>
To: Phil Sutter <phil@nwl.cc>,
Pablo Neira Ayuso <pablo@netfilter.org>,
Florian Westphal <fw@strlen.de>,
netfilter-devel@vger.kernel.org
Subject: Re: [iptables PATCH 5/5] iptables-test: Make use of sample connlabel.conf
Date: Mon, 4 Mar 2019 16:02:42 +0100 [thread overview]
Message-ID: <20190304150242.e66i4zj25jj2jt2q@breakpoint.cc> (raw)
In-Reply-To: <20190304145901.GN2478@orbyte.nwl.cc>
Phil Sutter <phil@nwl.cc> wrote:
> libnetfilter_conntrack once again to be sure, I noticed that it doesn't
> accept bit values unless they appear in connlabel.conf. Now I start
> changing functional behaviour and dropping label name test becomes a
> larger change than supporting connlabel.conf in non-standard path. /o\
I think it would make sense to accept raw numbers as well as a fallback.
We accept it from nftables, and IIRC the extension will print the raw
hex value if it can't map it back to a name on -save.
next prev parent reply other threads:[~2019-03-04 15:02 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20190219193953.29066-1-phil@nwl.cc>
[not found] ` <20190219193953.29066-4-phil@nwl.cc>
2019-03-01 12:52 ` [iptables PATCH 3/5] extensions: connlabel: Allow connlabel.conf override Pablo Neira Ayuso
2019-03-01 18:08 ` Phil Sutter
[not found] ` <20190219193953.29066-6-phil@nwl.cc>
2019-03-03 21:03 ` [iptables PATCH 5/5] iptables-test: Make use of sample connlabel.conf Florian Westphal
2019-03-04 12:43 ` Phil Sutter
2019-03-04 13:07 ` Pablo Neira Ayuso
2019-03-04 14:59 ` Phil Sutter
2019-03-04 15:02 ` Florian Westphal [this message]
2019-03-04 15:53 ` [iptables PATCH] extensions: connlabel: Fallback on missing connlabel.conf Phil Sutter
2019-03-08 19:20 ` Florian Westphal
2019-03-08 18:12 ` [iptables PATCH 5/5] iptables-test: Make use of sample connlabel.conf Pablo Neira Ayuso
2019-03-09 10:51 ` [libnetfilter_conntrack PATCH] Rename 'qa' directory to 'tests' Phil Sutter
2019-03-09 10:56 ` [libnetfilter_conntrack PATCH v2] " Phil Sutter
2019-03-11 12:36 ` Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190304150242.e66i4zj25jj2jt2q@breakpoint.cc \
--to=fw@strlen.de \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
--cc=phil@nwl.cc \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).