From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED,USER_AGENT_NEOMUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AD940C43381 for ; Fri, 8 Mar 2019 12:02:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 861E320684 for ; Fri, 8 Mar 2019 12:02:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726340AbfCHMCV (ORCPT ); Fri, 8 Mar 2019 07:02:21 -0500 Received: from Chamillionaire.breakpoint.cc ([146.0.238.67]:34282 "EHLO Chamillionaire.breakpoint.cc" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726286AbfCHMCV (ORCPT ); Fri, 8 Mar 2019 07:02:21 -0500 Received: from fw by Chamillionaire.breakpoint.cc with local (Exim 4.89) (envelope-from ) id 1h2ECh-00053F-QY; Fri, 08 Mar 2019 13:02:19 +0100 Date: Fri, 8 Mar 2019 13:02:19 +0100 From: Florian Westphal To: Pablo Neira Ayuso Cc: netfilter-devel@vger.kernel.org, fw@strlen.de Subject: Re: [PATCH nf,v2] netfilter: nf_tables: fix set double-free in abort path Message-ID: <20190308120219.7duuia7bil4hxdxn@breakpoint.cc> References: <20190308111646.8830-1-pablo@netfilter.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190308111646.8830-1-pablo@netfilter.org> User-Agent: NeoMutt/20170113 (1.7.2) Sender: netfilter-devel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netfilter-devel@vger.kernel.org Pablo Neira Ayuso wrote: > The abort path can cause a double-free of an anonymous set. > Added-and-to-be-aborted rule looks like this: > > udp dport { 137, 138 } drop [..] Acked-by: Florian Westphal