From: Phil Sutter <phil@nwl.cc>
To: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: netfilter-devel@vger.kernel.org
Subject: [iptables PATCH] xtables: Fix typo in nft_rebuild_cache()
Date: Tue, 14 May 2019 10:51:33 +0200 [thread overview]
Message-ID: <20190514085133.32674-1-phil@nwl.cc> (raw)
Conditional cache flush logic was inverted.
Fixes: 862818ac3a0de ("xtables: add and use nft_build_cache")
Signed-off-by: Phil Sutter <phil@nwl.cc>
---
iptables/nft.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/iptables/nft.c b/iptables/nft.c
index 6354b7e8e72fe..83e0d9a69b37c 100644
--- a/iptables/nft.c
+++ b/iptables/nft.c
@@ -1541,7 +1541,7 @@ void nft_build_cache(struct nft_handle *h)
void nft_rebuild_cache(struct nft_handle *h)
{
- if (!h->have_cache)
+ if (h->have_cache)
flush_chain_cache(h, NULL);
__nft_build_cache(h);
--
2.21.0
next reply other threads:[~2019-05-14 8:51 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-14 8:51 Phil Sutter [this message]
2019-05-14 11:45 ` [iptables PATCH] xtables: Fix typo in nft_rebuild_cache() Phil Sutter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190514085133.32674-1-phil@nwl.cc \
--to=phil@nwl.cc \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).