From: Florian Westphal <fw@strlen.de>
To: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: Stephen Suryaputra <ssuryaextr@gmail.com>,
netfilter-devel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH nf-next] netfilter: add support for matching IPv4 options
Date: Sat, 1 Jun 2019 10:27:32 +0200 [thread overview]
Message-ID: <20190601082732.fpgrqtcj7i7g6wek@breakpoint.cc> (raw)
In-Reply-To: <20190601002230.bo6dhdf3lhlkknqq@salvia>
Pablo Neira Ayuso <pablo@netfilter.org> wrote:
> > » iph = skb_header_pointer(skb, *offset, sizeof(_iph), &_iph);
> > » if (!iph || skb->protocol != htons(ETH_P_IP))
> > » » return -EBADMSG;
>
> I mean, you make this check upfront from the _eval() path, ie.
>
> static void nft_exthdr_ipv4_eval(const struct nft_expr *expr,
> ...
> {
> ...
>
> if (skb->protocol != htons(ETH_P_IP))
> goto err;
Wouldn't it be preferable to just use nft_pf() != NFPROTO_IPV4?
next prev parent reply other threads:[~2019-06-01 8:27 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-23 9:38 [PATCH nf-next] netfilter: add support for matching IPv4 options Stephen Suryaputra
2019-05-31 17:11 ` Pablo Neira Ayuso
2019-05-31 19:35 ` Stephen Suryaputra
2019-06-01 0:22 ` Pablo Neira Ayuso
2019-06-01 8:27 ` Florian Westphal [this message]
2019-06-01 8:40 ` Pablo Neira Ayuso
2019-06-01 8:53 ` Florian Westphal
2019-06-01 15:04 ` Stephen Suryaputra
2019-06-03 12:30 ` Pablo Neira Ayuso
2019-06-02 2:27 ` Stephen Suryaputra
2019-06-10 15:50 ` Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190601082732.fpgrqtcj7i7g6wek@breakpoint.cc \
--to=fw@strlen.de \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
--cc=ssuryaextr@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).