From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 66398C74A3F for ; Thu, 11 Jul 2019 00:19:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 42B0921019 for ; Thu, 11 Jul 2019 00:19:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727928AbfGKATC (ORCPT ); Wed, 10 Jul 2019 20:19:02 -0400 Received: from mail.us.es ([193.147.175.20]:35620 "EHLO mail.us.es" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727325AbfGKATB (ORCPT ); Wed, 10 Jul 2019 20:19:01 -0400 Received: from antivirus1-rhel7.int (unknown [192.168.2.11]) by mail.us.es (Postfix) with ESMTP id 7489780D10 for ; Thu, 11 Jul 2019 02:18:59 +0200 (CEST) Received: from antivirus1-rhel7.int (localhost [127.0.0.1]) by antivirus1-rhel7.int (Postfix) with ESMTP id 65582DA4D0 for ; Thu, 11 Jul 2019 02:18:59 +0200 (CEST) Received: by antivirus1-rhel7.int (Postfix, from userid 99) id 536F21021A7; Thu, 11 Jul 2019 02:18:59 +0200 (CEST) Received: from antivirus1-rhel7.int (localhost [127.0.0.1]) by antivirus1-rhel7.int (Postfix) with ESMTP id 0FE7BDA708; Thu, 11 Jul 2019 02:18:57 +0200 (CEST) Received: from 192.168.1.97 (192.168.1.97) by antivirus1-rhel7.int (F-Secure/fsigk_smtp/550/antivirus1-rhel7.int); Thu, 11 Jul 2019 02:18:57 +0200 (CEST) X-Virus-Status: clean(F-Secure/fsigk_smtp/550/antivirus1-rhel7.int) Received: from us.es (unknown [31.4.194.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: 1984lsi) by entrada.int (Postfix) with ESMTPSA id A4A804265A32; Thu, 11 Jul 2019 02:18:56 +0200 (CEST) Date: Thu, 11 Jul 2019 02:18:55 +0200 X-SMTPAUTHUS: auth mail.us.es From: Pablo Neira Ayuso To: Jiri Pirko Cc: netdev@vger.kernel.org, davem@davemloft.net, thomas.lendacky@amd.com, f.fainelli@gmail.com, ariel.elior@cavium.com, michael.chan@broadcom.com, madalin.bucur@nxp.com, yisen.zhuang@huawei.com, salil.mehta@huawei.com, jeffrey.t.kirsher@intel.com, tariqt@mellanox.com, saeedm@mellanox.com, jiri@mellanox.com, idosch@mellanox.com, jakub.kicinski@netronome.com, peppe.cavallaro@st.com, grygorii.strashko@ti.com, andrew@lunn.ch, vivien.didelot@gmail.com, alexandre.torgue@st.com, joabreu@synopsys.com, linux-net-drivers@solarflare.com, ogerlitz@mellanox.com, Manish.Chopra@cavium.com, marcelo.leitner@gmail.com, mkubecek@suse.cz, venkatkumar.duvvuru@broadcom.com, maxime.chevallier@bootlin.com, cphealy@gmail.com, phil@nwl.cc, netfilter-devel@vger.kernel.org Subject: Re: [PATCH net-next,v4 12/12] netfilter: nf_tables: add hardware offload support Message-ID: <20190711001855.clnckjanuouik7aw@salvia> References: <20190709205550.3160-1-pablo@netfilter.org> <20190709205550.3160-13-pablo@netfilter.org> <20190710075227.GA4362@nanopsycho> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190710075227.GA4362@nanopsycho> User-Agent: NeoMutt/20170113 (1.7.2) X-Virus-Scanned: ClamAV using ClamSMTP Sender: netfilter-devel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netfilter-devel@vger.kernel.org On Wed, Jul 10, 2019 at 09:52:27AM +0200, Jiri Pirko wrote: > Tue, Jul 09, 2019 at 10:55:50PM CEST, pablo@netfilter.org wrote: > > [...] > > >+ if (!dev || !dev->netdev_ops->ndo_setup_tc) > > Why didn't you rename ndo_setup_tc? I put a comment about it in the > previous version thread. I expect that you can at least write why it is > a wrong idea. This is a good idea. It happened that I read this email by when my new patch series was ready. I will follow up with a patch to address this rename as soon as the bug fixes are sorted out. Thanks.