From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9F9D0C76188 for ; Sun, 21 Jul 2019 10:43:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 78AD42085A for ; Sun, 21 Jul 2019 10:43:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726319AbfGUKnM (ORCPT ); Sun, 21 Jul 2019 06:43:12 -0400 Received: from orbyte.nwl.cc ([151.80.46.58]:42900 "EHLO orbyte.nwl.cc" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726131AbfGUKnL (ORCPT ); Sun, 21 Jul 2019 06:43:11 -0400 Received: from n0-1 by orbyte.nwl.cc with local (Exim 4.91) (envelope-from ) id 1hp9J7-0005vO-JV; Sun, 21 Jul 2019 12:43:09 +0200 Date: Sun, 21 Jul 2019 12:43:09 +0200 From: Phil Sutter To: Fernando Fernandez Mancera Cc: netfilter-devel@vger.kernel.org, Florian Westphal Subject: Re: [PATCH nft] src: osf: fix snprintf -Wformat-truncation warning Message-ID: <20190721104309.GD22661@orbyte.nwl.cc> Mail-Followup-To: Phil Sutter , Fernando Fernandez Mancera , netfilter-devel@vger.kernel.org, Florian Westphal References: <20190718110145.13361-1-ffmancera@riseup.net> <20190720202157.GB22661@orbyte.nwl.cc> <00a4ebbb-a571-b00a-83ac-ad198ccbd263@riseup.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <00a4ebbb-a571-b00a-83ac-ad198ccbd263@riseup.net> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: netfilter-devel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netfilter-devel@vger.kernel.org Hi, On Sun, Jul 21, 2019 at 11:59:14AM +0200, Fernando Fernandez Mancera wrote: [...] > I think your code is more readable than mine. I am going to send a v2 > patch with your code but also adding the following fix. > > - while (tmp && tmp + 1 && isspace(*(tmp + 1))) > + while (tmp && isspace(*(tmp + 1))) > > I am going to send a similar patch for the iptables tree because this > file was imported from iptables.git/utils/nfnl_osf.c. Sounds great, thanks a lot! Cheers, Phil