From: Florian Westphal <fw@strlen.de>
To: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: Florian Westphal <fw@strlen.de>, netfilter-devel@vger.kernel.org
Subject: Re: [PATCH nft 3/3] src: evaluate: return immediately if no op was requested
Date: Sun, 21 Jul 2019 20:50:40 +0200 [thread overview]
Message-ID: <20190721185040.5ueush32pe7zta2k@breakpoint.cc> (raw)
In-Reply-To: <20190721184901.n5ea7kpn246bddnb@salvia>
Pablo Neira Ayuso <pablo@netfilter.org> wrote:
> On Sun, Jul 21, 2019 at 02:14:07AM +0200, Florian Westphal wrote:
> > This makes nft behave like 0.9.0 -- the ruleset
> >
> > flush ruleset
> > table inet filter {
> > }
> > table inet filter {
> > chain test {
> > counter
> > }
> > }
> >
> > loads again without generating an error message.
> > I've added a test case for this, without this it will create an error,
> > and with a checkout of the 'fixes' tag we get crash.
> >
> > Closes: https://bugzilla.netfilter.org/show_bug.cgi?id=1351
> > Fixes: e5382c0d08e3c ("src: Support intra-transaction rule references")
>
> This one is causing the cache corruption, right?
There is no cache corruption. This patch makes us enter a code
path that we did not take before.
next prev parent reply other threads:[~2019-07-21 18:50 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-21 0:14 [PATCH nft 0/3] fix crash bug during rule restore Florian Westphal
2019-07-21 0:14 ` [PATCH nft 1/3] src: erec: fall back to internal location if its null Florian Westphal
2019-07-21 18:46 ` Pablo Neira Ayuso
2019-07-21 18:50 ` Florian Westphal
2019-07-23 19:19 ` Pablo Neira Ayuso
2019-07-21 0:14 ` [PATCH nft 2/3] src: evaluate: don't rely on global chain ctx for error reporting Florian Westphal
2019-07-21 0:14 ` [PATCH nft 3/3] src: evaluate: return immediately if no op was requested Florian Westphal
2019-07-21 18:49 ` Pablo Neira Ayuso
2019-07-21 18:50 ` Florian Westphal [this message]
2019-07-22 21:25 ` Pablo Neira Ayuso
2019-07-23 13:11 ` Phil Sutter
2019-07-23 13:52 ` Pablo Neira Ayuso
2019-07-23 19:18 ` Pablo Neira Ayuso
2019-07-23 22:44 ` Florian Westphal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190721185040.5ueush32pe7zta2k@breakpoint.cc \
--to=fw@strlen.de \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).