From: Phil Sutter <phil@nwl.cc>
To: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [iptables PATCH 4/5] xtables-monitor: Support ARP and bridge families
Date: Thu, 1 Aug 2019 14:58:00 +0200 [thread overview]
Message-ID: <20190801125800.GU14469@orbyte.nwl.cc> (raw)
In-Reply-To: <20190801124738.pnfo4zsypkqiaonm@salvia>
On Thu, Aug 01, 2019 at 02:47:38PM +0200, Pablo Neira Ayuso wrote:
> On Thu, Aug 01, 2019 at 02:41:07PM +0200, Phil Sutter wrote:
> > Hi,
> >
> > On Thu, Aug 01, 2019 at 02:30:40PM +0200, Pablo Neira Ayuso wrote:
> > > On Thu, Aug 01, 2019 at 02:00:48PM +0200, Phil Sutter wrote:
> [...]
> > > I think users will end up using --arp and --bridge for this. I myself
> > > will not remember this -0 and -1 thing.
> >
> > That's correct. So I guess changing cmdline flags to -a/-b makes sense
> > either way.
>
> In the rule side, getopt_long() is already pretty overloaded, just
> double check these are spare.
This is only about xtables-monitor cmdline, or am I missing something?
> > > Feel free to explore any possibility, probably leaving the existing -0
> > > and -1 in place if you're afraid of breaking anything, add aliases and
> > > only document the more intuitive one. If you think this is worth
> > > exploring, of course.
> >
> > I would omit the prefix from output if a family was selected. For
> > unfiltered xtables-monitor output, I would change the prefix to
> > something more readable, e.g.:
> >
> > 'ip: ',
> > 'ip6: ',
> > 'arp: ',
> > 'eb: '
> >
> > What do you think?
>
> Probably use the long option name, which seems more readable to me:
>
> EVENT: --ipv4 -t filter -A INPUT -j ACCEPT
Ah, good idea!
> I like that the event is printed using the {ip,...}tables syntax.
OK. --arp/--bridge won't work there, obviously. We could of course try
to change that, but I guess it's not feasible. Also, IIRC 'iptables -6'
was buggy in that it should fail but does not. This is a compatibility
issue I didn't get to fix yet.
Cheers, Phil
next prev parent reply other threads:[~2019-08-01 12:58 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-31 16:39 [iptables PATCH 0/5] xtables-monitor enhancements Phil Sutter
2019-07-31 16:39 ` [iptables PATCH 1/5] doc: Clean generated *-restore-translate man pages Phil Sutter
2019-07-31 16:39 ` [iptables PATCH 2/5] doc: Fix xtables-monitor man page Phil Sutter
2019-07-31 16:39 ` [iptables PATCH 3/5] xtables-monitor: Improve error messages Phil Sutter
2019-07-31 16:39 ` [iptables PATCH 4/5] xtables-monitor: Support ARP and bridge families Phil Sutter
2019-08-01 11:20 ` Pablo Neira Ayuso
2019-08-01 12:00 ` Phil Sutter
2019-08-01 12:30 ` Pablo Neira Ayuso
2019-08-01 12:33 ` Pablo Neira Ayuso
2019-08-01 12:41 ` Phil Sutter
2019-08-01 12:47 ` Pablo Neira Ayuso
2019-08-01 12:58 ` Phil Sutter [this message]
2019-08-01 13:03 ` Pablo Neira Ayuso
2019-08-01 14:20 ` Phil Sutter
2019-07-31 16:39 ` [iptables PATCH 5/5] xtables-monitor: Add family-specific aliases Phil Sutter
2019-07-31 17:45 ` Phil Sutter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190801125800.GU14469@orbyte.nwl.cc \
--to=phil@nwl.cc \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).