From: Florian Westphal <fw@strlen.de>
To: Dirk Morris <dmorris@metaloft.com>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH net v3] Use consistent ct id hash calculation
Date: Fri, 9 Aug 2019 00:04:12 +0200 [thread overview]
Message-ID: <20190808220412.nissxcfgwc36rswz@breakpoint.cc> (raw)
In-Reply-To: <51ae3971-1374-c8d0-e848-6574a5cdf4c1@metaloft.com>
Dirk Morris <dmorris@metaloft.com> wrote:
> Change ct id hash calculation to only use invariants.
>
> Currently the ct id hash calculation is based on some fields that can
> change in the lifetime on a conntrack entry in some corner cases. The
> current hash uses the whole tuple which contains an hlist pointer
> which will change when the conntrack is placed on the dying list
> resulting in a ct id change.
>
> This patch also removes the reply-side tuple and extension pointer
> from the hash calculation so that the ct id will will not change from
> initialization until confirmation.
>
> Fixes: 3c79107631db1f7 ("netfilter: ctnetlink: don't use conntrack/expect object addresses as id")
> Signed-off-by: Dirk Morris <dmorris@metaloft.com>
Looks good, thanks Dirk.
Acked-by: Florian Westphal <fw@strlen.de>
next prev parent reply other threads:[~2019-08-08 22:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-08 20:57 [PATCH net v3] Use consistent ct id hash calculation Dirk Morris
2019-08-08 22:04 ` Florian Westphal [this message]
2019-08-13 15:54 ` Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190808220412.nissxcfgwc36rswz@breakpoint.cc \
--to=fw@strlen.de \
--cc=dmorris@metaloft.com \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).