netfilter-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: kbuild test robot <lkp@intel.com>
To: Ander Juaristi <a@juaristi.eus>
Cc: kbuild-all@01.org, netfilter-devel@vger.kernel.org,
	Ander Juaristi <a@juaristi.eus>
Subject: Re: [PATCH] netfilter: nft_dynset: support for element deletion
Date: Fri, 9 Aug 2019 04:41:40 +0800	[thread overview]
Message-ID: <201908090448.oB3ZefdR%lkp@intel.com> (raw)
In-Reply-To: <20190713160302.31308-1-a@juaristi.eus>

[-- Attachment #1: Type: text/plain, Size: 1723 bytes --]

Hi Ander,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on linus/master]
[cannot apply to v5.3-rc3 next-20190808]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Ander-Juaristi/netfilter-nft_dynset-support-for-element-deletion/20190714-122358
config: x86_64-rhel-7.6 (attached as .config)
compiler: gcc-7 (Debian 7.4.0-10) 7.4.0
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   net/netfilter/nft_dynset.c: In function 'nft_dynset_eval':
>> net/netfilter/nft_dynset.c:115:2: error: expected ';' before '}' token
     } else {
     ^

vim +115 net/netfilter/nft_dynset.c

   106	
   107	void nft_dynset_eval(const struct nft_expr *expr,
   108			     struct nft_regs *regs, const struct nft_pktinfo *pkt)
   109	{
   110		const struct nft_dynset *priv = nft_expr_priv(expr);
   111		struct nft_set *set = priv->set;
   112	
   113		if (priv->op == NFT_DYNSET_OP_DELETE) {
   114			set->ops->delete(set, &regs->data[priv->sreg_key])
 > 115		} else {
   116			if (nft_dynset_update(priv->sreg_key, priv->op, priv->timeout, expr, pkt, regs, set)) {
   117				if (priv->invert)
   118					regs->verdict.code = NFT_BREAK;
   119				return;
   120			}
   121	
   122			if (!priv->invert)
   123				regs->verdict.code = NFT_BREAK;
   124		}
   125	}
   126	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 47827 bytes --]

      parent reply	other threads:[~2019-08-08 20:42 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-13 16:03 [PATCH] netfilter: nft_dynset: support for element deletion Ander Juaristi
2019-07-13 16:59 ` Florian Westphal
2019-07-15 16:22   ` Ander Juaristi
2019-07-15 19:54     ` Florian Westphal
2019-08-08 20:41 ` kbuild test robot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201908090448.oB3ZefdR%lkp@intel.com \
    --to=lkp@intel.com \
    --cc=a@juaristi.eus \
    --cc=kbuild-all@01.org \
    --cc=netfilter-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).