From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C4F28C32750 for ; Tue, 13 Aug 2019 09:57:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9AE9620663 for ; Tue, 13 Aug 2019 09:57:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728542AbfHMJ5B (ORCPT ); Tue, 13 Aug 2019 05:57:01 -0400 Received: from correo.us.es ([193.147.175.20]:34980 "EHLO mail.us.es" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727908AbfHMJ5B (ORCPT ); Tue, 13 Aug 2019 05:57:01 -0400 Received: from antivirus1-rhel7.int (unknown [192.168.2.11]) by mail.us.es (Postfix) with ESMTP id 9C08AFC5ED for ; Tue, 13 Aug 2019 11:56:58 +0200 (CEST) Received: from antivirus1-rhel7.int (localhost [127.0.0.1]) by antivirus1-rhel7.int (Postfix) with ESMTP id 8E64D115101 for ; Tue, 13 Aug 2019 11:56:58 +0200 (CEST) Received: by antivirus1-rhel7.int (Postfix, from userid 99) id 7D473576C8; Tue, 13 Aug 2019 11:56:58 +0200 (CEST) Received: from antivirus1-rhel7.int (localhost [127.0.0.1]) by antivirus1-rhel7.int (Postfix) with ESMTP id 821DA1150DD; Tue, 13 Aug 2019 11:56:56 +0200 (CEST) Received: from 192.168.1.97 (192.168.1.97) by antivirus1-rhel7.int (F-Secure/fsigk_smtp/550/antivirus1-rhel7.int); Tue, 13 Aug 2019 11:56:56 +0200 (CEST) X-Virus-Status: clean(F-Secure/fsigk_smtp/550/antivirus1-rhel7.int) Received: from us.es (unknown [31.4.218.116]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: 1984lsi) by entrada.int (Postfix) with ESMTPSA id 557474265A2F; Tue, 13 Aug 2019 11:56:56 +0200 (CEST) Date: Tue, 13 Aug 2019 11:56:55 +0200 X-SMTPAUTHUS: auth mail.us.es From: Pablo Neira Ayuso To: Valdis =?utf-8?Q?Kl=C4=93tnieks?= Cc: Jozsef Kadlecsik , Florian Westphal , netfilter-devel@vger.kernel.org, coreteam@netfilter.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] net/netfilter - add missing prototypes. Message-ID: <20190813095655.qkitgdvfeyuhy4ga@salvia> References: <54079.1565242088@turing-police> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <54079.1565242088@turing-police> User-Agent: NeoMutt/20170113 (1.7.2) X-Virus-Scanned: ClamAV using ClamSMTP Sender: netfilter-devel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netfilter-devel@vger.kernel.org On Thu, Aug 08, 2019 at 01:28:08AM -0400, Valdis Klētnieks wrote: > Sparse rightly complains about undeclared symbols. > > CHECK net/netfilter/nft_set_hash.c > net/netfilter/nft_set_hash.c:647:21: warning: symbol 'nft_set_rhash_type' was not declared. Should it be static? > net/netfilter/nft_set_hash.c:670:21: warning: symbol 'nft_set_hash_type' was not declared. Should it be static? > net/netfilter/nft_set_hash.c:690:21: warning: symbol 'nft_set_hash_fast_type' was not declared. Should it be static? > CHECK net/netfilter/nft_set_bitmap.c > net/netfilter/nft_set_bitmap.c:296:21: warning: symbol 'nft_set_bitmap_type' was not declared. Should it be static? > CHECK net/netfilter/nft_set_rbtree.c > net/netfilter/nft_set_rbtree.c:470:21: warning: symbol 'nft_set_rbtree_type' was not declared. Should it be static? > > Include nf_tables_core.h rather than nf_tables.h to pick up the additional definitions. Applied, thanks.